From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53430C7EE2F for ; Thu, 4 May 2023 12:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230057AbjEDMcL (ORCPT ); Thu, 4 May 2023 08:32:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbjEDMcK (ORCPT ); Thu, 4 May 2023 08:32:10 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31ECA6185 for ; Thu, 4 May 2023 05:32:06 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-95369921f8eso69784666b.0 for ; Thu, 04 May 2023 05:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683203524; x=1685795524; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CrbpIEMptg8Nu95mNsBTQ6WaBBHC6A4oRrtY3eFlfqs=; b=a5ecuECdq5V5WZ2pb8QPbrLujAGXrAJwfWNwdXd7bm+tmCsthMP1e33cpqChSe6GKk l3RYFR9DdDqdUmwY7nZFqa8sBo4+02hL1qBqzrWqLBC4JGVxIPsU9/X2AvC8Eef9x9OY fpIoUfyyNMuFs76uH/mU9MGTUbS0b4QoZ8+Esgft/09YyNJHZ8J//KlZQMRG+1rs0ehU s3f8N4Fe9FjBbz5jM1ZfJ15RayFLThFsuNXRam4v1H1c++tVDQaLCWuAQqt7NFhyBDGl QcADV5f8ovZfMd131yznZHQ4KqwBL95gmzGZBKWrMASnNSL9OvaV29Iz/Jb1kD49cc1f L5fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683203524; x=1685795524; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CrbpIEMptg8Nu95mNsBTQ6WaBBHC6A4oRrtY3eFlfqs=; b=GON9dho6KOwClBRFbZG83q5+dkMQzVVZeq77wq/gON06buQ7qFy8XXPbSu1FoTgcx3 6slLkJQaMNkgl4gDo9frvwUKD511d8NIQdUSpAAIaqxj0WkAWWWCgLPSvjW8K7azDDGG w/jtjZRDDP3MVrUEcZMTYE12FajNt4u3ur4s9q5CuA29NuP6228beXVdfv7PNLHtVlyN IahZ0L+m306yLi0s0lEEA/48EgDk76NLDdcynP+WZ9SSHNwG1CnJ8S31NGSi2MDC9zCI DE28jocEqR8bGkw6nM1qDdOR0VLfPZJYRO0/O155mUvTwLrco2Rqw6n6eef+xUfE3aOR D4zg== X-Gm-Message-State: AC+VfDy+BHdQIVjGqfDEfKc7YRpVzHHdv7hF9ndlH3puvG2UGML+GcLa 2/Vxg8ymhR/rK65hxSWFRuYH/A== X-Google-Smtp-Source: ACHHUZ7WP/SrQkpuJ4nYDyrtOsN3LKp6lH6RSLgSvg/FR7Pb9OEgE0TBtEvtuxZc4ExAKCwQHhpMDQ== X-Received: by 2002:a17:906:ef08:b0:94f:3b83:a4d1 with SMTP id f8-20020a170906ef0800b0094f3b83a4d1mr5816986ejs.50.1683203524601; Thu, 04 May 2023 05:32:04 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:cbf1:e7ef:fb81:e912? ([2a02:810d:15c0:828:cbf1:e7ef:fb81:e912]) by smtp.gmail.com with ESMTPSA id sk19-20020a170906631300b009572a8f86fbsm17151363ejc.165.2023.05.04.05.32.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 05:32:03 -0700 (PDT) Message-ID: Date: Thu, 4 May 2023 14:32:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 07/18] arm64: defconfig: Enable Qualcomm minidump driver Content-Language: en-US To: Mukesh Ojha , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, corbet@lwn.net, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, catalin.marinas@arm.com, will@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, srinivas.kandagatla@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org References: <1683133352-10046-1-git-send-email-quic_mojha@quicinc.com> <1683133352-10046-8-git-send-email-quic_mojha@quicinc.com> <4325c2e7-8ca1-7e45-db14-5ba8bc83f5d7@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <4325c2e7-8ca1-7e45-db14-5ba8bc83f5d7@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 04/05/2023 13:45, Mukesh Ojha wrote: > > > On 5/4/2023 4:53 PM, Krzysztof Kozlowski wrote: >> On 03/05/2023 19:02, Mukesh Ojha wrote: >>> Previous patches add the Qualcomm minidump driver support, so >>> lets enable minidump config so that it can be used by kernel >>> clients. >>> >>> Signed-off-by: Mukesh Ojha >> >> This patchset is split too much. Defconfig change is one change. Not two >> or three. >> >>> --- >>> arch/arm64/configs/defconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >>> index a24609e..831c942 100644 >>> --- a/arch/arm64/configs/defconfig >>> +++ b/arch/arm64/configs/defconfig >>> @@ -1250,6 +1250,7 @@ CONFIG_QCOM_STATS=m >>> CONFIG_QCOM_WCNSS_CTRL=m >>> CONFIG_QCOM_APR=m >>> CONFIG_QCOM_ICC_BWMON=m >>> +CONFIG_QCOM_MINIDUMP=y >> >> This must be a module. > > Why do you think this should be a module ? > > Is it because, it is lying here among others '=m' ? Because we want and insist on everything being a module. That's the generic rule. There are exceptions, so if this justifies being an exception, please bring appropriate arguments. > > Or you have some other reasoning ? like it is for qcom specific > soc and can not be used outside ? but that is not true for > all configs mentioned here. > > The reason behind making it as '=y' was, to collect information from > core kernel data structure as well as the information like percpu data, > run queue, irq stat kind of information on kernel crash on a target > running some perf configuration(android phone). I don't understand why =m stops you from all that. What's more, I don't understand why do you refer to the Android here. This is a development and debugging Linux defconfig, not Android reference config for vendors... Best regards, Krzysztof