From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>,
<manivannan.sadhasivam@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>, <hemantk@codeaurora.org>,
<linux-kernel@vger.kernel.org>, <loic.poulain@linaro.org>,
<linux-wireless@vger.kernel.org>, <kvalo@codeaurora.org>,
<ath11k@lists.infradead.org>
Subject: Re: [PATCH v1 6/6] bus: mhi: core: Add range checks for BHI and BHIe
Date: Tue, 4 May 2021 11:30:59 -0600 [thread overview]
Message-ID: <a5e8cd2e-2863-f88b-8344-021d90a68131@quicinc.com> (raw)
In-Reply-To: <1618598825-18629-7-git-send-email-bbhatt@codeaurora.org>
On 4/16/2021 12:47 PM, Bhaumik Bhatt wrote:
> When obtaining the BHI or BHIe offsets during the power up
> preparation phase, range checks are missing. These can help
> controller drivers avoid accessing any address outside of the
> MMIO region. Ensure that mhi_cntrl->reg_len is set before MHI
> registration as it is a required field and range checks will
> fail without it.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> ---
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
prev parent reply other threads:[~2021-05-04 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 18:46 [PATCH v1 0/6] BHI/BHIe improvements for MHI power purposes Bhaumik Bhatt
2021-04-16 18:47 ` [PATCH v1 1/6] bus: mhi: core: Set BHI/BHIe offsets on power up preparation Bhaumik Bhatt
2021-05-04 17:22 ` Jeffrey Hugo
2021-04-16 18:47 ` [PATCH v1 2/6] bus: mhi: core: Set BHI and BHIe pointers to NULL in clean-up Bhaumik Bhatt
2021-05-04 17:26 ` Jeffrey Hugo
2021-04-16 18:47 ` [PATCH v1 3/6] bus: mhi: Add MMIO region length to controller structure Bhaumik Bhatt
2021-05-04 17:28 ` Jeffrey Hugo
2021-05-04 23:04 ` Bhaumik Bhatt
2021-04-16 18:47 ` [PATCH v1 4/6] ath11k: set register access length for MHI driver Bhaumik Bhatt
2021-04-16 18:47 ` [PATCH v1 5/6] bus: mhi: pci_generic: Set " Bhaumik Bhatt
2021-04-16 18:47 ` [PATCH v1 6/6] bus: mhi: core: Add range checks for BHI and BHIe Bhaumik Bhatt
2021-05-04 17:30 ` Jeffrey Hugo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5e8cd2e-2863-f88b-8344-021d90a68131@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=ath11k@lists.infradead.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).