From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C174C2B9F7 for ; Fri, 28 May 2021 17:21:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1121C613D1 for ; Fri, 28 May 2021 17:21:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230215AbhE1RXK (ORCPT ); Fri, 28 May 2021 13:23:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230193AbhE1RXJ (ORCPT ); Fri, 28 May 2021 13:23:09 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D35F5C061760 for ; Fri, 28 May 2021 10:21:34 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id l18-20020a1c79120000b0290181c444b2d0so2788882wme.5 for ; Fri, 28 May 2021 10:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=scHG+8hUPjtbaxqAIRrNTESjQXzSH5JKl2wenbFc2w8=; b=eFsE+o2qmtozyY3vcZ5kChHif66Zz7w0LGa+0qR/yny+Eq63joHpR0T9uLI7KYeDwe E/97imlGcQldR/Xs1VjBGkSKYHemWveFoMY1O4VqByLTtJKKSK6tZ31V4nclGy66T01h 3kt+osmVafd4clK7SkYS0fM4BhQniaKp5vg+5iOM44Zxdx2VW3oTmd9r2KLRpcQg28QU IMX5ajbh8K8O+uf/aqgjf7IsS5wqUrsoSjtQUbApxNSNZHHm7FTKQ0Hs6uMWGZ7PpiEs LsTQURHghAxQmEg8EaZu/1n+ZzI0d/7fCxWVszp59txlXGMQlipYpQgRHUruRizU2epx 9nQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=scHG+8hUPjtbaxqAIRrNTESjQXzSH5JKl2wenbFc2w8=; b=RmRVPDZGgOUQjBxK1m37SHvcYhW4Or2K7nKWDQR5PrpJnZ1GPwWhxPs6GFEIQ/amgV WIoq/9soIaPKQSZ2OzOf16xzSiA8CAl7LABH44l6MyZ2gL+aOdytCUKS0LtexB2tj7yy aKNOrMX9R8luH+tlu9UpAT7/fDq9YBacTMyXEtX0iEAJdmz+A/lnIAkgvtjicC1gC1p1 UO/uBKAT/m0xhhqw9de6VLX4nKrS98qZQ5FPweW45IZabfEJ63vQLSNUL8e4uagMehyR rbSFEdy2oWdDPZjC+f2HZhnnl6p9CiBSbX5klZjWxFP6fPZvpkI45vrbtgEJlB57TMHr EmGw== X-Gm-Message-State: AOAM530Z+ML6bByFeFnqiMI+9Ws9TC/EXX1hI8dZ9+/pStxMWpdCYSga NkeYAY2K0oc+IE2ALucrdrIQ3A== X-Google-Smtp-Source: ABdhPJwDSWZ04EbaFWGZL6KGWkl1fL/jAW11ceb1vkO71Tn+4xdhReJ0jxgiwkSAbkpbB5CyCxToAw== X-Received: by 2002:a05:600c:21c3:: with SMTP id x3mr9311858wmj.131.1622222493417; Fri, 28 May 2021 10:21:33 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id z17sm8767546wrt.81.2021.05.28.10.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 May 2021 10:21:32 -0700 (PDT) Subject: Re: [PATCH] venus: helper: do not set constrained format for UBWC To: Mansur Alisha Shaik , linux-media@vger.kernel.org, stanimir.varbanov@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org, dikshita@codeaurora.org References: <1622195288-18541-1-git-send-email-mansur@codeaurora.org> From: Bryan O'Donoghue Message-ID: Date: Fri, 28 May 2021 18:23:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1622195288-18541-1-git-send-email-mansur@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 28/05/2021 10:48, Mansur Alisha Shaik wrote: > Do not set constrained format explicitly for UBWC > > Signed-off-by: Mansur Alisha Shaik Could you give a little bit more detail on why, what the side effects are ? Should this be a Fixes: ? > --- > drivers/media/platform/qcom/venus/helpers.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c > index b813d6dba..e4b8a2a 100644 > --- a/drivers/media/platform/qcom/venus/helpers.c > +++ b/drivers/media/platform/qcom/venus/helpers.c > @@ -1138,8 +1138,12 @@ int venus_helper_set_format_constraints(struct venus_inst *inst) > if (!IS_V6(inst->core)) > return 0; > > + if (inst->opb_fmt == HFI_COLOR_FORMAT_NV12_UBWC) > + return 0; > + > pconstraint.buffer_type = HFI_BUFFER_OUTPUT2; > pconstraint.num_planes = 2; > + Additional newline should be removed. > pconstraint.plane_format[0].stride_multiples = 128; > pconstraint.plane_format[0].max_stride = 8192; > pconstraint.plane_format[0].min_plane_buffer_height_multiple = 32; > --- bod