linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Gross <agross@kernel.org>
Subject: Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
Date: Tue, 21 May 2019 14:03:36 +0200	[thread overview]
Message-ID: <a7514c68-d2d3-ce9e-bc4b-f484bb5bf3cf@free.fr> (raw)
In-Reply-To: <49cf5d94beb9af9ef4e78d4c52f3b0ad20b7c63f.1558430617.git.amit.kucheria@linaro.org>

On 21/05/2019 11:35, Amit Kucheria wrote:

> Add device bindings for cpuidle states for cpu devices.
> 
> Cc: Marc Gonzalez <marc.w.gonzalez@free.fr>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/msm8998.dtsi | 50 +++++++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index 3fd0769fe648..54810980fcf9 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -78,6 +78,7 @@
>  			compatible = "arm,armv8";
>  			reg = <0x0 0x0>;
>  			enable-method = "psci";
> +			cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>;
>  			efficiency = <1024>;
>  			next-level-cache = <&L2_0>;
>  			L2_0: l2-cache {


NB: this patch does not apply cleanly to v5.2-rc1  ;-)

86f93c93dd50 arm64: dts: msm8998: efficiency is not valid property

commit 86f93c93dd5005f0aeb8ce84c2113e21a6006c7d
Author:     Amit Kucheria <amit.kucheria@linaro.org>
AuthorDate: Fri Mar 29 15:42:08 2019 +0530
Commit:     Andy Gross <agross@kernel.org>
CommitDate: Tue Apr 9 23:08:17 2019 -0500

After manually fixing up the trivial conflict, the DTB builds without errors.

I then enable
+CONFIG_CPU_IDLE=y
+CONFIG_ARM_CPUIDLE=y

(because I'm using a board-specific tiny defconfig)

And... the system starts to boot, hangs a few seconds, then silently reboots:

scsi 0:0:0:3: Direct-Access     SAMSUNG  KLUBG4G1CE-B0B1  0800 PQ: 0 ANSI: 6
sd 0:0:0:1: [sdb] 16384-byte physical blocks
sd 0:0:0:2: [sdc] 2048 4096-byte logical blocks: (8.39 MB/8.00 MiB)
sd 0:0:0:2: [sdc] 16384-byte physical blocks

Format: Log Type - Time(microsec) - Message - Optional Info
Log Type: B - Since Boot(Power On Reset),  D - Delta,  S - Statistic
S - QC_IMAGE_VERSION_STRING=BOOT.XF.1.2.2-00157-M8998LZB-1
S - IMAGE_VARIANT_STRING=Msm8998LA


Looks like the "helpful" behavior of the secure OS...

Regards.

  reply	other threads:[~2019-05-21 12:03 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  9:35 [PATCH v2 0/9] qcom: Add cpuidle to some platforms Amit Kucheria
2019-05-21  9:35 ` [PATCH v2 1/9] arm64: dts: fsl: ls1028a: Fix entry-method property to reflect documentation Amit Kucheria
2019-05-21  9:35 ` [PATCH v2 2/9] Documentation: arm: Link idle-states binding to "enable-method" property Amit Kucheria
2019-05-21 10:34   ` Marc Gonzalez
2019-06-13 23:13   ` Rob Herring
2019-05-21  9:35 ` [PATCH v2 3/9] arm64: dts: qcom: msm8916: Add entry-method property for the idle-states node Amit Kucheria
2019-05-22  3:30   ` Bjorn Andersson
2019-05-21  9:35 ` [PATCH v2 4/9] arm64: dts: qcom: msm8916: Use more generic idle state names Amit Kucheria
2019-05-22  3:30   ` Bjorn Andersson
2019-05-21  9:35 ` [PATCH v2 5/9] arm64: dts: qcom: qcs404: Add PSCI cpuidle low power states Amit Kucheria
2019-05-22  3:31   ` Bjorn Andersson
2019-05-21  9:35 ` [PATCH v2 6/9] arm64: dts: qcom: msm8996: " Amit Kucheria
2019-05-21 10:13   ` Daniel Lezcano
2019-05-22  3:49   ` Bjorn Andersson
2019-05-23 21:24   ` Niklas Cassel
2019-05-21  9:35 ` [PATCH v2 7/9] arm64: dts: qcom: msm8998: " Amit Kucheria
2019-05-21 12:03   ` Marc Gonzalez [this message]
2019-05-21 16:10     ` Marc Gonzalez
2019-05-22  9:17     ` Marc Gonzalez
2019-05-22  9:35       ` Marc Zyngier
2019-05-22 15:39         ` Marc Gonzalez
2019-05-22 14:48       ` Marc Gonzalez
2019-09-30 22:20   ` Jeffrey Hugo
2019-09-30 22:44     ` Amit Kucheria
2019-10-01 14:21       ` Jeffrey Hugo
2019-10-02  9:19     ` Niklas Cassel
2019-10-02  9:27       ` Niklas Cassel
2019-10-02 18:18         ` Jeffrey Hugo
2019-10-04  1:36           ` Amit Kucheria
2019-10-04  3:14             ` Jeffrey Hugo
2019-05-21  9:35 ` [PATCH v2 8/9] arm64: dts: qcom: sdm845: " Amit Kucheria
2019-05-22  3:59   ` Bjorn Andersson
2019-05-21  9:35 ` [PATCH v2 9/9] arm64: dts: msm8996: Add proper capacity scaling for the cpus Amit Kucheria
2019-05-21 10:14   ` Daniel Lezcano
2019-05-22  3:50   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7514c68-d2d3-ce9e-bc4b-f484bb5bf3cf@free.fr \
    --to=marc.w.gonzalez@free.fr \
    --cc=agross@kernel.org \
    --cc=amit.kucheria@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).