From: skakit@codeaurora.org
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kgunda@codeaurora.org
Subject: Re: [PATCH V4 7/8] arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp
Date: Mon, 17 May 2021 10:58:37 +0530 [thread overview]
Message-ID: <a835d67abc8509f1e7de5f0afd330a1c@codeaurora.org> (raw)
In-Reply-To: <YJKvtLMPCg56DO1E@google.com>
On 2021-05-05 20:16, Matthias Kaehlcke wrote:
> On Wed, May 05, 2021 at 12:25:25PM +0530, satya priya wrote:
>
>> Subject: arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp
>
> nit: just 'channel nodes' is a bit vague. In case you respin maybe
> change it to something like 'Add ADC channel nodes for PMIC
> temperatures to sc7280-idp'
>
Okay will change it and resend v4.
> In any case it doesn't seem worth to respin just for this.
>
>>
>> Add channel nodes for the on die temperatures of PMICS
>> pmk8350, pm8350, pmr735a and pmr735b.
>>
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2021-05-17 5:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 6:55 [PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
2021-05-05 6:55 ` [PATCH V4 1/8] arm64: dts: qcom: sm8350: Add label for thermal-zones node satya priya
2021-05-05 13:33 ` Matthias Kaehlcke
2021-05-05 6:55 ` [PATCH V4 2/8] arm64: dts: qcom: sc7280: Add " satya priya
2021-05-05 13:41 ` Matthias Kaehlcke
2021-05-05 6:55 ` [PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file satya priya
2021-05-05 6:55 ` [PATCH V4 4/8] arm64: dts: qcom: pm8350c: Add temp-alarm support satya priya
2021-05-05 6:55 ` [PATCH V4 5/8] arm64: dts: qcom: pmr735a: " satya priya
2021-05-05 6:55 ` [PATCH V4 6/8] arm64: dts: qcom: pmk8350: Add peripherals for pmk8350 satya priya
2021-05-05 14:35 ` Matthias Kaehlcke
2021-05-05 6:55 ` [PATCH V4 7/8] arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp satya priya
2021-05-05 14:46 ` Matthias Kaehlcke
2021-05-17 5:28 ` skakit [this message]
2021-05-05 6:55 ` [PATCH V4 8/8] arm64: dts: qcom: sc7280: Include PMIC DT files " satya priya
2021-05-05 14:57 ` Matthias Kaehlcke
2021-05-17 5:27 ` skakit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a835d67abc8509f1e7de5f0afd330a1c@codeaurora.org \
--to=skakit@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--subject='Re: [PATCH V4 7/8] arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).