Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs
@ 2019-07-06 20:31 ` Rob Clark
  2019-07-11 16:43   ` Bjorn Andersson
                     ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Rob Clark @ 2019-07-06 20:31 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-arm-msm, Rob Clark, Laurent Pinchart, Andrzej Hajda,
	Laurent Pinchart, David Airlie, Daniel Vetter, linux-kernel

From: Rob Clark <robdclark@chromium.org>

This should be more future-proof if we ever encounter a device with two
of these bridges.

Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index c8fb45e7b06d..9f4ff88d4a10 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -204,7 +204,7 @@ DEFINE_SHOW_ATTRIBUTE(status);
 
 static void ti_sn_debugfs_init(struct ti_sn_bridge *pdata)
 {
-	pdata->debugfs = debugfs_create_dir("ti_sn65dsi86", NULL);
+	pdata->debugfs = debugfs_create_dir(dev_name(pdata->dev), NULL);
 
 	debugfs_create_file("status", 0600, pdata->debugfs, pdata,
 			&status_fops);
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs
  2019-07-06 20:31 ` [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs Rob Clark
@ 2019-07-11 16:43   ` Bjorn Andersson
  2019-07-11 16:49   ` Laurent Pinchart
  2019-07-16  7:55   ` Andrzej Hajda
  2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2019-07-11 16:43 UTC (permalink / raw)
  To: Rob Clark
  Cc: dri-devel, linux-arm-msm, Rob Clark, Laurent Pinchart,
	Andrzej Hajda, David Airlie, Daniel Vetter, linux-kernel

On Sat 06 Jul 13:31 PDT 2019, Rob Clark wrote:

> From: Rob Clark <robdclark@chromium.org>
> 
> This should be more future-proof if we ever encounter a device with two
> of these bridges.
> 
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Rob Clark <robdclark@chromium.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index c8fb45e7b06d..9f4ff88d4a10 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -204,7 +204,7 @@ DEFINE_SHOW_ATTRIBUTE(status);
>  
>  static void ti_sn_debugfs_init(struct ti_sn_bridge *pdata)
>  {
> -	pdata->debugfs = debugfs_create_dir("ti_sn65dsi86", NULL);
> +	pdata->debugfs = debugfs_create_dir(dev_name(pdata->dev), NULL);
>  
>  	debugfs_create_file("status", 0600, pdata->debugfs, pdata,
>  			&status_fops);
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs
  2019-07-06 20:31 ` [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs Rob Clark
  2019-07-11 16:43   ` Bjorn Andersson
@ 2019-07-11 16:49   ` Laurent Pinchart
  2019-07-11 17:42     ` Rob Clark
  2019-07-16  7:55   ` Andrzej Hajda
  2 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2019-07-11 16:49 UTC (permalink / raw)
  To: Rob Clark
  Cc: dri-devel, linux-arm-msm, Rob Clark, Andrzej Hajda, David Airlie,
	Daniel Vetter, linux-kernel

Hi Rob,

Thank you for the patch.

On Sat, Jul 06, 2019 at 01:31:02PM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
> 
> This should be more future-proof if we ever encounter a device with two
> of these bridges.
> 
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index c8fb45e7b06d..9f4ff88d4a10 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -204,7 +204,7 @@ DEFINE_SHOW_ATTRIBUTE(status);
>  
>  static void ti_sn_debugfs_init(struct ti_sn_bridge *pdata)
>  {
> -	pdata->debugfs = debugfs_create_dir("ti_sn65dsi86", NULL);
> +	pdata->debugfs = debugfs_create_dir(dev_name(pdata->dev), NULL);

That should work, but won't it become quite confusing for users ? I
wonder if the directory name shouldn't be prefixed with the driver name.
Something like "ti_sn65dsi86:%s", dev_name(pdata->dev).

>  	debugfs_create_file("status", 0600, pdata->debugfs, pdata,
>  			&status_fops);

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs
  2019-07-11 16:49   ` Laurent Pinchart
@ 2019-07-11 17:42     ` Rob Clark
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Clark @ 2019-07-11 17:42 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: dri-devel, linux-arm-msm, Rob Clark, Andrzej Hajda, David Airlie,
	Daniel Vetter, Linux Kernel Mailing List

On Thu, Jul 11, 2019 at 9:49 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Rob,
>
> Thank you for the patch.
>
> On Sat, Jul 06, 2019 at 01:31:02PM -0700, Rob Clark wrote:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > This should be more future-proof if we ever encounter a device with two
> > of these bridges.
> >
> > Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> >  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > index c8fb45e7b06d..9f4ff88d4a10 100644
> > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > @@ -204,7 +204,7 @@ DEFINE_SHOW_ATTRIBUTE(status);
> >
> >  static void ti_sn_debugfs_init(struct ti_sn_bridge *pdata)
> >  {
> > -     pdata->debugfs = debugfs_create_dir("ti_sn65dsi86", NULL);
> > +     pdata->debugfs = debugfs_create_dir(dev_name(pdata->dev), NULL);
>
> That should work, but won't it become quite confusing for users ? I
> wonder if the directory name shouldn't be prefixed with the driver name.
> Something like "ti_sn65dsi86:%s", dev_name(pdata->dev).

*maybe*, if they are badly named in dt?  In the end the target
audience is really to help developers and people bringing up a new
board, so maybe my way encourages them to use sensible names in dt ;-)

BR,
-R


>
> >       debugfs_create_file("status", 0600, pdata->debugfs, pdata,
> >                       &status_fops);
>
> --
> Regards,
>
> Laurent Pinchart

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs
  2019-07-06 20:31 ` [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs Rob Clark
  2019-07-11 16:43   ` Bjorn Andersson
  2019-07-11 16:49   ` Laurent Pinchart
@ 2019-07-16  7:55   ` Andrzej Hajda
  2 siblings, 0 replies; 5+ messages in thread
From: Andrzej Hajda @ 2019-07-16  7:55 UTC (permalink / raw)
  To: Rob Clark, dri-devel
  Cc: linux-arm-msm, Rob Clark, Laurent Pinchart, David Airlie,
	Daniel Vetter, linux-kernel

On 06.07.2019 22:31, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> This should be more future-proof if we ever encounter a device with two
> of these bridges.
>
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Rob Clark <robdclark@chromium.org>

Queued to drm-misc-next.


Regards

Andrzej




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20190706203123epcas2p4094186d4d2d9954d6068c03b99df07a2@epcas2p4.samsung.com>
2019-07-06 20:31 ` [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs Rob Clark
2019-07-11 16:43   ` Bjorn Andersson
2019-07-11 16:49   ` Laurent Pinchart
2019-07-11 17:42     ` Rob Clark
2019-07-16  7:55   ` Andrzej Hajda

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org linux-arm-msm@archiver.kernel.org
	public-inbox-index linux-arm-msm


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox