From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53D8DC433B4 for ; Sat, 15 May 2021 17:41:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BDEF61057 for ; Sat, 15 May 2021 17:41:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231482AbhEORnA (ORCPT ); Sat, 15 May 2021 13:43:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230307AbhEORm6 (ORCPT ); Sat, 15 May 2021 13:42:58 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 476CEC061573 for ; Sat, 15 May 2021 10:41:44 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id v6so2237627ljj.5 for ; Sat, 15 May 2021 10:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=b7eX77q8eKbpdnMvJxfoJvBkAq9vgiVC8Eptr8qHOxM=; b=IHGdBBzTmj0VpkUBKhTvgL7ff21LY6rZpUEOV3viZVLWRG8L747QMqM1X1LPtFkbZh EJvhV8MZPe7isHM0+kW+Yoey9ivxWHwnk/JMSgWgkVw4cnAZdYpRK5KzLhwTZuhyo+Nn Olms4DtUW52q+cHwHUSZSkId+NnfvpdrA65XHDr5qXEE/UaFnAkOwT+kESdSE8/g0WLY jJUmQ5VkyZDBeoAKNelXs1BQOA4sdFn9nTYGnkX+Aj8MAi1PsEVp6pJP5nxZebo+tx+r taRE2AgAWsf1M4OApV4dm7YYBO2l5DMWCyekP73xI7v9FWHCA8U/FajH4mLMYnI5VrVV Q6dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=b7eX77q8eKbpdnMvJxfoJvBkAq9vgiVC8Eptr8qHOxM=; b=gYmM4tlNFeWGu+sk7VBPA1dX3++U78ZRMnH7T3qZ7WjwfGb4hGbh9WTAKKG/+fDFJx Qoqu9C1/0TZkOtUrc/bb2XBmwWV5eZPFPmp6Ss2BOnwz4wUjwPOQpPcfDkztj6EaC3zE FuwwGx3LcqqaJIxikfehj3CCPIUb7WXC1raEMaqWc3mBFQQGgWguH9X2KTiNuknWUEYW D3ce6r1dHkHAn/osY0Cm3IyPLDjXOHvHB7+gBKFFDFsYTukPhmm4dx0QGj+uX1Tz2NDu 7+6aApBomhD7BkS1Hqj2Y040QhCjSqj2Eg539p3+ROAezJIbb+mgWKwTSteW9r7JWWpW VJ9w== X-Gm-Message-State: AOAM532wUiPZldfrYi6Iz3+Mja2kf6Mqy2ULmQhC3ie7d2K+NGZY1egv nvl8ubWEwc4dhPDd0SodwDYLGw== X-Google-Smtp-Source: ABdhPJywo+0YyXrXkHIsvx+8Y2y5PtGhqM4kuVUcPeW2DVE2rC9aZH144ekNIyXTmHQxnYIgvKLC3w== X-Received: by 2002:a2e:9215:: with SMTP id k21mr42376171ljg.224.1621100502083; Sat, 15 May 2021 10:41:42 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id z20sm952196ljk.123.2021.05.15.10.41.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 May 2021 10:41:41 -0700 (PDT) Subject: Re: [PATCH 1/1] drm/msm: Fix error return code in msm_drm_init() To: Zhen Lei , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Jeykumar Sankaran , linux-arm-msm , dri-devel , freedreno , linux-kernel References: <20210508022836.1777-1-thunder.leizhen@huawei.com> From: Dmitry Baryshkov Message-ID: Date: Sat, 15 May 2021 20:41:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210508022836.1777-1-thunder.leizhen@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 08/05/2021 05:28, Zhen Lei wrote: > Fix to return a negative error code from the error handling case instead > of 0, as done elsewhere in this function. > > Fixes: 7f9743abaa79 ("drm/msm: validate display and event threads") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index e1104d2454e2..ebd856dde1f1 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -523,6 +523,7 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv) > priv->event_thread[i].worker = kthread_create_worker(0, > "crtc_event:%d", priv->event_thread[i].crtc_id); > if (IS_ERR(priv->event_thread[i].worker)) { > + ret = PTR_ERR(priv->event_thread[i].worker); > DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n"); > goto err_msm_uninit; > } > -- With best wishes Dmitry