From: Steev Klimaszewski <steev@kali.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
~postmarketos/upstreaming@lists.sr.ht
Cc: martin.botka@somainline.org,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: qcom: sdm845: Disable Adreno, modem and Venus by default
Date: Tue, 5 Oct 2021 08:28:48 -0500 [thread overview]
Message-ID: <afcde09c-c930-ca6c-9ccc-7888d86a150a@kali.org> (raw)
In-Reply-To: <255059cf-b91c-1d29-0474-6b4b8fcef141@somainline.org>
On 10/2/21 5:51 PM, Konrad Dybcio wrote:
> On 03.10.2021 00:25, Steev Klimaszewski wrote:
>> This missed the Lenovo Yoga C630 inherits from sdm845 and breaks it.
> Welp, qcom decided to give laptops +5 sdm points and that made me overlook it :P
>
>
> If the rest of the patch looks good, could you add this diff Bjorn to fix that?:
>
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index a3b61cb3cfad..b96ecf537ff1 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -343,7 +343,12 @@ &gcc {
> <GCC_LPASS_SWAY_CLK>;
> };
>
> +&gmu {
> + status = "okay";
> +};
> +
> &gpu {
> + status = "okay";
> zap-shader {
> memory-region = <&gpu_mem>;
> firmware-name = "qcom/LENOVO/81JL/qcdxkmsuc850.mbn";
> @@ -461,6 +466,7 @@ &mdss {
> };
>
> &mss_pil {
> + status = "okay";
> firmware-name = "qcom/LENOVO/81JL/qcdsp1v2850.mbn", "qcom/LENOVO/81JL/qcdsp2850.mbn";
> };
>
> @@ -722,6 +728,10 @@ &usb_2_qmpphy {
> vdda-pll-supply = <&vdda_usb2_ss_core>;
> };
>
> +&venus {
> + status = "okay";
> +};
> +
> &wcd9340{
> pinctrl-0 = <&wcd_intr_default>;
> pinctrl-names = "default";
>
>
> Konrad
>
With the above applied, all is well on the Lenovo Yoga C630.
Tested-By: Steev Klimaszewski <steev@kali.org>
next prev parent reply other threads:[~2021-10-05 13:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211002001358.45920-1-konrad.dybcio@somainline.org>
2021-10-02 0:13 ` [PATCH 1/5] arm64: dts: qcom: sdm845: Add XO clock to SDHCI Konrad Dybcio
2021-10-02 0:13 ` [PATCH 2/5] arm64: dts: qcom: sdm845: Disable Adreno, modem and Venus by default Konrad Dybcio
2021-10-02 22:25 ` Steev Klimaszewski
2021-10-02 22:51 ` Konrad Dybcio
2021-10-05 13:28 ` Steev Klimaszewski [this message]
2021-10-02 0:13 ` [PATCH 3/5] arm64: dts: qcom: sdm845: Don't disable MDP explicitly Konrad Dybcio
2021-10-02 0:13 ` [PATCH 4/5] arm64: dts: qcom: sdm845: Add size/address-cells to dsi[01] Konrad Dybcio
2021-10-02 0:13 ` [PATCH 5/5] arm64: dts: qcom: sdm845: Move gpio.h inclusion to SoC DTSI Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afcde09c-c930-ca6c-9ccc-7888d86a150a@kali.org \
--to=steev@kali.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).