From: schowdhu@codeaurora.org
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
Sibi Sankar <sibis@codeaurora.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Subject: Re: [PATCH V0 1/6] dt-bindings: Added the yaml bindings for DCC
Date: Wed, 17 Feb 2021 18:50:20 +0530 [thread overview]
Message-ID: <b0a01a37aedde4b2da2edd7032dd7627@codeaurora.org> (raw)
In-Reply-To: <20210217110214.GR2774@vkoul-mobl.Dlink>
On 2021-02-17 16:32, Vinod Koul wrote:
> On 17-02-21, 12:18, Souradeep Chowdhury wrote:
>> Documentation for Data Capture and Compare(DCC) device tree bindings
>> in yaml format.
>>
>> Signed-off-by: Souradeep Chowdhury <schowdhu@codeaurora.org>
>> ---
>> .../devicetree/bindings/arm/msm/qcom,dcc.yaml | 49
>> ++++++++++++++++++++++
>> 1 file changed, 49 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
>> b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
>> new file mode 100644
>> index 0000000..8f09578
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
>> @@ -0,0 +1,49 @@
>> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Data Capture and Compare
>> +
>> +maintainers:
>> + - Souradeep Chowdhury <schowdhu@codeaurora.org>
>> +
>> +description: |
>> + DCC (Data Capture and Compare) is a DMA engine which is used to
>> save
>> + configuration data or system memory contents during catastrophic
>> failure
>> + or SW trigger.DCC is used to capture and store data for debugging
>> purpose
>
> space after .
Ack
>
>> +
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - qcom,sm8150-dcc
>> + - const: qcom,dcc
>> +
>> + reg:
>> + items:
>> + - description: DCC base register region
>> + - description: DCC RAM base register region
>> +
>> + reg-names:
>> + items:
>> + - const: dcc-base
>> + - const: dcc-ram-base
>
> drop dcc from names
Since DCC has a dedicated SRAM, this has been named like this as
only base and ram-base are generic names. Let me know if this is
still required to be changed.
>
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + dcc@010a2000{
>> + compatible = "qcom,sm8150-dcc";
>
> should this not be:
> compatible = "qcom,sm8150-dcc", "qcom,dcc";
Ack
>
>> + reg = <0 0x010a2000 0 0x1000>,
>> + <0 0x010ae000 0 0x2000>;
>> + reg-names = "dcc-base", "dcc-ram-base";
>> + };
>> --
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
>> member
>> of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2021-02-17 13:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 6:48 [PATCH V0 0/6] Add driver support for Data Capture and Compare Engine(DCC) for SM8150 Souradeep Chowdhury
2021-02-17 6:48 ` [PATCH V0 1/6] dt-bindings: Added the yaml bindings for DCC Souradeep Chowdhury
2021-02-17 11:02 ` Vinod Koul
2021-02-17 13:20 ` schowdhu [this message]
2021-02-17 20:24 ` Rob Herring
2021-02-17 6:48 ` [PATCH V0 2/6] arm64: dts: qcom: sm8150: Add Data Capture and Compare(DCC) support node Souradeep Chowdhury
2021-02-17 11:03 ` Vinod Koul
2021-02-17 13:10 ` schowdhu
2021-02-17 6:48 ` [PATCH V0 3/6] soc: qcom: dcc:Add driver support for Data Capture and Compare unit(DCC) Souradeep Chowdhury
2021-02-17 8:08 ` kernel test robot
2021-02-18 6:59 ` Vinod Koul
2021-02-18 11:51 ` schowdhu
2021-02-17 6:48 ` [PATCH V0 4/6] soc: qcom: dcc:Add the sysfs variables to the Data Capture and Compare driver(DCC) Souradeep Chowdhury
2021-02-17 6:48 ` [PATCH V0 5/6] DCC:Added the sysfs entries for DCC(Data Capture and Compare) driver Souradeep Chowdhury
2021-02-17 6:48 ` [PATCH V0 6/6] MAINTAINERS:Added the entry for DCC(Data Capture and Compare) driver support Souradeep Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0a01a37aedde4b2da2edd7032dd7627@codeaurora.org \
--to=schowdhu@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).