From: rajeevny@codeaurora.org
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, sean@poorly.run,
robdclark@gmail.com, robh+dt@kernel.org, abhinavk@codeaurora.org,
kalyan_t@codeaurora.org, mkrishn@codeaurora.org,
jonathan@marek.ca
Subject: Re: [v1 2/3] drm/msm/dsi: Add PHY configuration for SC7280
Date: Tue, 01 Jun 2021 17:52:44 +0530 [thread overview]
Message-ID: <b37617c61fbdb11dc2c903878c05e0ac@codeaurora.org> (raw)
In-Reply-To: <7a3facb5-d118-f81b-65f8-381b0d56a23b@linaro.org>
On 31-05-2021 23:27, Dmitry Baryshkov wrote:
> On 31/05/2021 16:33, Rajeev Nandan wrote:
>> + .min_pll_rate = 600000000UL,
>> + .max_pll_rate = (5000000000ULL < ULONG_MAX) ? 5000000000ULL :
>> ULONG_MAX,
>
> Could you please follow the patch by Arnd here?
> https://lore.kernel.org/linux-arm-msm/20210514213032.575161-1-arnd@kernel.org/
>
>
>
>> + .io_start = { 0xae94400, 0xae96400 },
>> + .num_dsi_phy = 2,
>
> Judging from the next patch, you have one DSI host and one DSI PHY.
> Could you please correct io_start / num_dsi_phy here?
>
>> + .quirks = DSI_PHY_7NM_QUIRK_V4_1,
>> +};
>
>
> With these two issues fixed:
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Thank you very much for your review :) I have incorporated the
review comments. I am waiting for comments on my DT bindings patch (1/3)
and
will send v2 in a day or two.
Thanks,
Rajeev
next prev parent reply other threads:[~2021-06-01 12:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 13:33 [v1 0/3] drm/msm/dsi: Add display DSI support for SC7280 target Rajeev Nandan
2021-05-31 13:33 ` [v1 1/3] dt-bindings: msm/dsi: Add yaml schema for 7nm DSI PHY Rajeev Nandan
2021-06-01 13:32 ` Rob Herring
2021-06-01 20:58 ` Rob Herring
2021-06-02 20:02 ` rajeevny
2021-06-16 5:50 ` rajeevny
2021-06-17 15:07 ` Jonathan Marek
2021-06-18 10:39 ` rajeevny
2021-05-31 13:33 ` [v1 2/3] drm/msm/dsi: Add PHY configuration for SC7280 Rajeev Nandan
2021-05-31 17:57 ` Dmitry Baryshkov
2021-06-01 12:22 ` rajeevny [this message]
2021-05-31 13:33 ` [v1 3/3] drm/msm/dsi: Add DSI support " Rajeev Nandan
2021-05-31 17:57 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b37617c61fbdb11dc2c903878c05e0ac@codeaurora.org \
--to=rajeevny@codeaurora.org \
--cc=abhinavk@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrishn@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).