From: mansur@codeaurora.org
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: Bryan O'Donoghue <pure.logic@nexus-software.ie>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org,
dikshita@codeaurora.org
Subject: Re: [PATCH] venus: helper: do not set constrained format for UBWC
Date: Mon, 14 Jun 2021 11:55:25 +0530 [thread overview]
Message-ID: <b649a7ecb3feb1fdf6d0743135814840@codeaurora.org> (raw)
In-Reply-To: <17aaec56-bfad-63a6-b1c4-7562dedb3137@linaro.org>
On 2021-06-02 15:23, Stanimir Varbanov wrote:
> Mansur, could you answer to Bryan's comments?
>
>> On 5/28/21 8:23 PM, Bryan O'Donoghue wrote:
>>> On 28/05/2021 10:48, Mansur Alisha Shaik wrote:
>>>> Do not set constrained format explicitly for UBWC
>>>>
>>>> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
>>>
>>> Could you give a little bit more detail on why, what the side effects
>>> are ?
>>>
Sorry for late response, by default for NV12_UBWC is 128x32
>>> Should this be a Fixes: ?
>>>
without this fix on V6, firmware throws below SFR
qcom-venus aa00000.video-codec: SFR message from FW:
QC_IMAGE_VERSION_STRING=video-firmware.1.0-df9cb37cf8e507a4468265658702247652351a49
Err_Fatal -
/local/mnt/workspace/pkg/builds/dynamic_timely/tree2/vendor/qcom/proprietary/video-firmware-noship/venus_proc/venus/decoders/common/src/video_decoder.c:6644:2fef3
which result in playback happens through Software codec.
>>>> ---
>>>> drivers/media/platform/qcom/venus/helpers.c | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/drivers/media/platform/qcom/venus/helpers.c
>>>> b/drivers/media/platform/qcom/venus/helpers.c
>>>> index b813d6dba..e4b8a2a 100644
>>>> --- a/drivers/media/platform/qcom/venus/helpers.c
>>>> +++ b/drivers/media/platform/qcom/venus/helpers.c
>>>> @@ -1138,8 +1138,12 @@ int
>>>> venus_helper_set_format_constraints(struct
>>>> venus_inst *inst)
>>>> if (!IS_V6(inst->core))
>>>> return 0;
>>>> + if (inst->opb_fmt == HFI_COLOR_FORMAT_NV12_UBWC)
>>>> + return 0;
>>>> +
>>>> pconstraint.buffer_type = HFI_BUFFER_OUTPUT2;
>>>> pconstraint.num_planes = 2;
>>>> +
>>>
>>> Additional newline should be removed.
>>>
>>>> pconstraint.plane_format[0].stride_multiples = 128;
>>>> pconstraint.plane_format[0].max_stride = 8192;
>>>> pconstraint.plane_format[0].min_plane_buffer_height_multiple =
>>>> 32;
>>>>
>>>
>>> ---
>>> bod
next prev parent reply other threads:[~2021-06-14 6:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 9:48 [PATCH] venus: helper: do not set constrained format for UBWC Mansur Alisha Shaik
2021-05-28 17:23 ` Bryan O'Donoghue
2021-06-02 9:53 ` Stanimir Varbanov
2021-06-14 6:25 ` mansur [this message]
2021-06-14 11:56 ` Bryan O'Donoghue
2021-06-19 5:52 ` vgarodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b649a7ecb3feb1fdf6d0743135814840@codeaurora.org \
--to=mansur@codeaurora.org \
--cc=dikshita@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).