From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA873C433B4 for ; Wed, 12 May 2021 11:38:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C8D6613DA for ; Wed, 12 May 2021 11:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230190AbhELLjL (ORCPT ); Wed, 12 May 2021 07:39:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbhELLjL (ORCPT ); Wed, 12 May 2021 07:39:11 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E270C06175F for ; Wed, 12 May 2021 04:38:02 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id r11so2614664edt.13 for ; Wed, 12 May 2021 04:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UpD/+YrtaMz5PR2dtvL4t8j/9dEXdGpQf09tWS3r5rw=; b=udp+4TRpeviOuAnt7FrqJRRV1+zXYBvVGgv4Cz5Y9t6zBLVwFUjA59+uUeEwQsnDVl 45kremyM0hZhUJwpcJJndt7S+Noq8tnCrzEYIlw6h6IiqlOfuxtXfabUemdEoHfc7ZbB NY8gqtrb1Ww2H3NrVEKy7yMCzFLqzZ5kHFN6JbVAVVZwFfmzC9uOLg/oEN4+cil3XjJY 25zZuHHEdtYO/jywa5VbIs/rqluxihlrXKZvZHU/vTttl5N3NXiLaW3AamRoqatv3TtA 0tdJzU5NYRSjtKOgfNOSgKToLFC4LsOj5kuJWApynOclcwkDO/usuo86Uk9pJF4oJLzw T48g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UpD/+YrtaMz5PR2dtvL4t8j/9dEXdGpQf09tWS3r5rw=; b=q6GGun9oj5bVVxww8SOnYIbMD16VQuAN7LIoefFlMl+tRWWzBqFqS6tpfuGR4IAlwj Ye98G/C9GsPTK7pQjI0iJnJp2kk+V2O2ou9pJ/PJgv91sogEOxGMlyVomKKl+AKfIeUV 7i+QUDuOvZ5RGOM9MtYo+STcFCcmCxjoH0pUU5bQa6QNpUGa9dKONdx5luo0ZPTnxYnJ 9NdXHzN+ZFZV+xAgQ630bRNzGsKx2e3glsY6bVEhLTifE4oWfJthO7FwmuhnZZiWNJCb ZSIWBz9s9CwXcJDBVIWwnfBoHunU8HEJBn+cLZleM32RRCQGKcYu5z4zoPuBIfjxABzc ctNA== X-Gm-Message-State: AOAM533qhFGJOJPCYysLzojofmPyY5MqP8i5PuYx8Z/GQZHDEZtZcHoT rXTzzCkHzy0SFVVp4GlrdLjDdg== X-Google-Smtp-Source: ABdhPJyGFxPE/N7ZciKy727EOs4Kgvddr2+YwvncA1HKgg5RKfV3yiczKlNpu+zaRQ+rWwGx1RIcdA== X-Received: by 2002:a05:6402:2548:: with SMTP id l8mr43334868edb.208.1620819480745; Wed, 12 May 2021 04:38:00 -0700 (PDT) Received: from [192.168.1.14] ([195.24.90.54]) by smtp.googlemail.com with ESMTPSA id w6sm11802898edc.25.2021.05.12.04.37.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 May 2021 04:38:00 -0700 (PDT) Subject: Re: [PATCH][next] media: venus: hfi_cmds.h: Replace one-element array with flexible-array member To: "Gustavo A. R. Silva" , "Gustavo A. R. Silva" , Stanimir Varbanov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20210210225720.GA13710@embeddedor> <6081fb66-7f43-cab4-b7ff-ce4b291b8865@embeddedor.com> From: Stanimir Varbanov Message-ID: Date: Wed, 12 May 2021 14:37:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <6081fb66-7f43-cab4-b7ff-ce4b291b8865@embeddedor.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On 5/11/21 6:44 PM, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: > > We are about to be able to globally enable -Warray-bounds and, this is one of the > last out-of-bounds warnings in linux-next. > > Could someone take this, please? I'll take this for 5.14. > > Thanks > -- > Gustavo > > On 2/10/21 16:57, Gustavo A. R. Silva wrote: >> There is a regular need in the kernel to provide a way to declare having >> a dynamically sized set of trailing elements in a structure. Kernel code >> should always use “flexible array members”[1] for these cases. The older >> style of one-element or zero-length arrays should no longer be used[2]. >> >> Use flexible-array member in struct hfi_sys_set_property_pkt instead of >> one-element array. >> >> Also, this helps with the ongoing efforts to enable -Warray-bounds and >> fix the following warnings: >> >> drivers/media/platform/qcom/venus/hfi_cmds.c: In function ‘pkt_sys_coverage_config’: >> drivers/media/platform/qcom/venus/hfi_cmds.c:57:11: warning: array subscript 1 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds] >> 57 | pkt->data[1] = mode; >> | ~~~~~~~~~^~~ >> >> [1] https://en.wikipedia.org/wiki/Flexible_array_member >> [2] https://www.kernel.org/doc/html/v5.9/process/deprecated.html#zero-length-and-one-element-arrays >> >> Link: https://github.com/KSPP/linux/issues/79 >> Link: https://github.com/KSPP/linux/issues/109 >> Build-tested-by: kernel test robot >> Link: https://lore.kernel.org/lkml/602416da.iZqae7Dbk7nyl6OY%25lkp@intel.com/ >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h >> index 83705e237f1c..327ed90a2788 100644 >> --- a/drivers/media/platform/qcom/venus/hfi_cmds.h >> +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h >> @@ -68,7 +68,7 @@ struct hfi_sys_release_resource_pkt { >> struct hfi_sys_set_property_pkt { >> struct hfi_pkt_hdr hdr; >> u32 num_properties; >> - u32 data[1]; >> + u32 data[]; >> }; >> >> struct hfi_sys_get_property_pkt { >> -- regards, Stan