From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70B17C433DB for ; Fri, 26 Feb 2021 10:26:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 170AA64EC4 for ; Fri, 26 Feb 2021 10:26:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbhBZK0h (ORCPT ); Fri, 26 Feb 2021 05:26:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230083AbhBZK0e (ORCPT ); Fri, 26 Feb 2021 05:26:34 -0500 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58EF2C061574 for ; Fri, 26 Feb 2021 02:25:54 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id l12so10310482edt.3 for ; Fri, 26 Feb 2021 02:25:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5rKpGoiRrT+bkmlgbReBpLp1vitCMiQU7wBDSXEmNTA=; b=p6VVeTkcR4B2rlycKujGM5IcMvd+H2V1Dc+iXTjc+Vuk0hkW6RAyt/43lpuMO8HYN7 JEssIDXeBnRDoHJaEUSDzl4iUsOZXj0tQr2z8OnXvdQ3J1IGFS0q48bFduqysfrQLKHm 3N/q5HzXVj+Dnhe0rmyO2MFYv1x9xHINL433/umoihi4e5r9uwIz+2fDUicumPuTBOfD nAFSmuq3Q+CESZRAt0sF5D+Tjr9olpKs1jAqONhllTPJPQ9NNXIrshlTumcvVnDI/KC7 1wWPXG0H588hEpmgqTFu/aCEYVcQbP8uyz7eN+3Rb/WWq4l5uFpBbeI4GWVTP21Soy7h JgTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5rKpGoiRrT+bkmlgbReBpLp1vitCMiQU7wBDSXEmNTA=; b=ffLkvO/06r7QSAB6Vlx8ioOqSEdJvUcKpgaVp7INML1/V0evR/uIQgwGIJSW22IsVN UkfVCD2gG/MpCsGVp1Of69Kv450K2X1Y9NxaJ6A7cIjQUGi3LxZMBMdPs2WzTbp0KlUx nxDIIfvYxK1vqZ+t1VsTn+oud+29/InmiBaHEk+rGJEXume8TvnxwREvemfk76zB5L+c p4RgQzITOzwAdLITSg9SbQ0x4JVPFHulO4psropPcOpUs/j4QpzmAzuCX12I42ait22y 1cPYC83aq9zcd9t4QMG+iIKNWd6aD1pVz/F0zodyTYIZOjjM5B7pZqeQakXypVpYwnP8 9onQ== X-Gm-Message-State: AOAM530ACtaNUykci/Ly64QAWHXQOwxxrvTudphkwU4s9hAnbhvlnKjO Wa8HP3dNJYNtPzCtUQxEHvVQng== X-Google-Smtp-Source: ABdhPJyiBVBAnEA3oza8gnERr+ycgJz8KJVEFDYTjuf7W3oxJsZ+5aeTp/c//dphLxLYiueU8twFBg== X-Received: by 2002:aa7:d0d7:: with SMTP id u23mr27635edo.255.1614335153065; Fri, 26 Feb 2021 02:25:53 -0800 (PST) Received: from [192.168.0.4] ([84.238.208.204]) by smtp.googlemail.com with ESMTPSA id z2sm4494691eju.55.2021.02.26.02.25.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Feb 2021 02:25:52 -0800 (PST) Subject: Re: [PATCH 25/25] media: venus: vdec: Fix decoder cmd STOP issue To: Bryan O'Donoghue , agross@kernel.org, bjorn.andersson@linaro.org, mchehab@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: dikshita@codeaurora.org, jonathan@marek.ca, vgarodia@codeaurora.org References: <20210222160300.1811121-1-bryan.odonoghue@linaro.org> <20210222160300.1811121-26-bryan.odonoghue@linaro.org> From: Stanimir Varbanov Message-ID: Date: Fri, 26 Feb 2021 12:25:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210222160300.1811121-26-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2/22/21 6:03 PM, Bryan O'Donoghue wrote: > From: Stanimir Varbanov > > Fixes an issue when issuing a stop command to the controller, negating the > following firmware error. > > "SFR message from FW: Exception: TID = Unknown IP = 0x3b7dc FA = 0x0 > cause = 0x6" > > Signed-off-by: Stanimir Varbanov > Signed-off-by: Bryan O'Donoghue > --- > drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +- > drivers/media/platform/qcom/venus/vdec.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/platform/qcom/venus/hfi_cmds.c > index cc282b0df8c3..0a32bb44506c 100644 > --- a/drivers/media/platform/qcom/venus/hfi_cmds.c > +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c > @@ -254,7 +254,7 @@ int pkt_session_unset_buffers(struct hfi_session_release_buffer_pkt *pkt, > int pkt_session_etb_decoder(struct hfi_session_empty_buffer_compressed_pkt *pkt, > void *cookie, struct hfi_frame_data *in_frame) > { > - if (!cookie || !in_frame->device_addr) > + if (!cookie) > return -EINVAL; > > pkt->shdr.hdr.size = sizeof(*pkt); > diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c > index 903443a7a757..9fbff40c4568 100644 > --- a/drivers/media/platform/qcom/venus/vdec.c > +++ b/drivers/media/platform/qcom/venus/vdec.c > @@ -515,7 +515,7 @@ vdec_decoder_cmd(struct file *file, void *fh, struct v4l2_decoder_cmd *cmd) > > fdata.buffer_type = HFI_BUFFER_INPUT; > fdata.flags |= HFI_BUFFERFLAG_EOS; > - fdata.device_addr = 0xdeadb000; > + fdata.device_addr = 0; This should be 0 for v6 only until we find some better way for this EOS packet. > > ret = hfi_session_process_buf(inst, &fdata); > > -- regards, Stan