From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C1B1C433E0 for ; Mon, 1 Jun 2020 23:24:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE24D20663 for ; Mon, 1 Jun 2020 23:24:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728077AbgFAXYf (ORCPT ); Mon, 1 Jun 2020 19:24:35 -0400 Received: from mga04.intel.com ([192.55.52.120]:59378 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725802AbgFAXYf (ORCPT ); Mon, 1 Jun 2020 19:24:35 -0400 IronPort-SDR: Pk3CRkESY+6R3LlhLKn9/9iAUFjqRmArbIr3amp12PWVcazjGrMY0xWVy6Q4S49uyQ5lxS+CJH +txN7sobXNPQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2020 16:24:34 -0700 IronPort-SDR: JUrubKqZ3F7uGT4bgd8rDXSYuTz0v1ViuP4XLx4HCS0DJFWRtTu6O81cWlFvWumpfvKQwJQ2yp fW6OmojLAXPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,462,1583222400"; d="scan'208";a="293361052" Received: from allen-box.sh.intel.com (HELO [10.239.159.139]) ([10.239.159.139]) by fmsmga004.fm.intel.com with ESMTP; 01 Jun 2020 16:24:27 -0700 Cc: baolu.lu@linux.intel.com Subject: Re: [PATCH v2 00/33] iommu: Move iommu_group setup to IOMMU core code To: Joerg Roedel , Will Deacon , Robin Murphy , Marek Szyprowski , Kukjin Kim , Krzysztof Kozlowski , David Woodhouse , Andy Gross , Bjorn Andersson , Matthias Brugger , Rob Clark , Heiko Stuebner , Gerald Schaefer , Thierry Reding , Jonathan Hunter , Jean-Philippe Brucker , linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-rockchip@lists.infradead.org, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org References: <20200414131542.25608-1-joro@8bytes.org> <20200529221623.qc6twmpzryh7nkvb@cantor> <20200601104240.7f5xhz7gooqhaq4n@cantor> <20200601131702.4ksimsjvnsmo3mvn@cantor> From: Lu Baolu Message-ID: Date: Tue, 2 Jun 2020 07:20:41 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200601131702.4ksimsjvnsmo3mvn@cantor> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Jerry, On 6/1/20 9:17 PM, Jerry Snitselaar wrote: > On Mon Jun 01 20, Jerry Snitselaar wrote: >> On Fri May 29 20, Jerry Snitselaar wrote: >>> On Tue Apr 14 20, Joerg Roedel wrote: >>>> Hi, >>>> >>>> here is the second version of this patch-set. The first version with >>>> some more introductory text can be found here: >>>> >>>>     https://lore.kernel.org/lkml/20200407183742.4344-1-joro@8bytes.org/ >>>> >>>> Changes v1->v2: >>>> >>>>     * Rebased to v5.7-rc1 >>>> >>>>     * Re-wrote the arm-smmu changes as suggested by Robin Murphy >>>> >>>>     * Re-worked the Exynos patches to hopefully not break the >>>>       driver anymore >>>> >>>>     * Fixed a missing mutex_unlock() reported by Marek Szyprowski, >>>>       thanks for that. >>>> >>>> There is also a git-branch available with these patches applied: >>>> >>>>     https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2 >>>> >>>> >>>> Please review. >>>> >>>> Thanks, >>>> >>>>     Joerg >>>> >>>> Joerg Roedel (32): >>>> iommu: Move default domain allocation to separate function >>>> iommu/amd: Implement iommu_ops->def_domain_type call-back >>>> iommu/vt-d: Wire up iommu_ops->def_domain_type >>>> iommu/amd: Remove dma_mask check from check_device() >>>> iommu/amd: Return -ENODEV in add_device when device is not handled by >>>>  IOMMU >>>> iommu: Add probe_device() and remove_device() call-backs >>>> iommu: Move default domain allocation to iommu_probe_device() >>>> iommu: Keep a list of allocated groups in __iommu_probe_device() >>>> iommu: Move new probe_device path to separate function >>>> iommu: Split off default domain allocation from group assignment >>>> iommu: Move iommu_group_create_direct_mappings() out of >>>>  iommu_group_add_device() >>>> iommu: Export bus_iommu_probe() and make is safe for re-probing >>>> iommu/amd: Remove dev_data->passthrough >>>> iommu/amd: Convert to probe/release_device() call-backs >>>> iommu/vt-d: Convert to probe/release_device() call-backs >>>> iommu/arm-smmu: Convert to probe/release_device() call-backs >>>> iommu/pamu: Convert to probe/release_device() call-backs >>>> iommu/s390: Convert to probe/release_device() call-backs >>>> iommu/virtio: Convert to probe/release_device() call-backs >>>> iommu/msm: Convert to probe/release_device() call-backs >>>> iommu/mediatek: Convert to probe/release_device() call-backs >>>> iommu/mediatek-v1 Convert to probe/release_device() call-backs >>>> iommu/qcom: Convert to probe/release_device() call-backs >>>> iommu/rockchip: Convert to probe/release_device() call-backs >>>> iommu/tegra: Convert to probe/release_device() call-backs >>>> iommu/renesas: Convert to probe/release_device() call-backs >>>> iommu/omap: Remove orphan_dev tracking >>>> iommu/omap: Convert to probe/release_device() call-backs >>>> iommu/exynos: Use first SYSMMU in controllers list for IOMMU core >>>> iommu/exynos: Convert to probe/release_device() call-backs >>>> iommu: Remove add_device()/remove_device() code-paths >>>> iommu: Unexport iommu_group_get_for_dev() >>>> >>>> Sai Praneeth Prakhya (1): >>>> iommu: Add def_domain_type() callback in iommu_ops >>>> >>>> drivers/iommu/amd_iommu.c       |  97 ++++---- >>>> drivers/iommu/amd_iommu_types.h |   1 - >>>> drivers/iommu/arm-smmu-v3.c     |  38 +-- >>>> drivers/iommu/arm-smmu.c        |  39 ++-- >>>> drivers/iommu/exynos-iommu.c    |  24 +- >>>> drivers/iommu/fsl_pamu_domain.c |  22 +- >>>> drivers/iommu/intel-iommu.c     |  68 +----- >>>> drivers/iommu/iommu.c           | 393 +++++++++++++++++++++++++------- >>>> drivers/iommu/ipmmu-vmsa.c      |  60 ++--- >>>> drivers/iommu/msm_iommu.c       |  34 +-- >>>> drivers/iommu/mtk_iommu.c       |  24 +- >>>> drivers/iommu/mtk_iommu_v1.c    |  50 ++-- >>>> drivers/iommu/omap-iommu.c      |  99 ++------ >>>> drivers/iommu/qcom_iommu.c      |  24 +- >>>> drivers/iommu/rockchip-iommu.c  |  26 +-- >>>> drivers/iommu/s390-iommu.c      |  22 +- >>>> drivers/iommu/tegra-gart.c      |  24 +- >>>> drivers/iommu/tegra-smmu.c      |  31 +-- >>>> drivers/iommu/virtio-iommu.c    |  41 +--- >>>> include/linux/iommu.h           |  21 +- >>>> 20 files changed, 533 insertions(+), 605 deletions(-) >>>> >>>> -- >>>> 2.17.1 >>>> >>>> _______________________________________________ >>>> iommu mailing list >>>> iommu@lists.linux-foundation.org >>>> https://lists.linuxfoundation.org/mailman/listinfo/iommu >>>> >>> >>> Hi Joerg, >>> >>> With this patchset, I have an epyc system where if I boot with >>> iommu=nopt and force a dump I will see some io page faults for a nic >>> on the system. The vmcore is harvested and the system reboots. I >>> haven't reproduced it on other systems yet, but without the patchset I >>> don't see the io page faults during the kdump. >>> >>> Regards, >>> Jerry >> >> I just hit an issue on a separate intel based system (kdump iommu=nopt), >> where it panics in during intel_iommu_attach_device, in is_aux_domain, >> due to device_domain_info being DEFER_DEVICE_DOMAIN_INFO. That doesn't >> get set to a valid address until the domain_add_dev_info call. >> >> Is it as simple as the following? >> >> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c >> index 29d3940847d3..f1bbeed46a4c 100644 >> --- a/drivers/iommu/intel-iommu.c >> +++ b/drivers/iommu/intel-iommu.c >> @@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct >> iommu_domain *domain) >> { >>        struct device_domain_info *info = dev->archdata.iommu; >> -       return info && info->auxd_enabled && >> -                       domain->type == IOMMU_DOMAIN_UNMANAGED; >> +       return info && info != DEFER_DEVICE_DOMAIN_INFO && >> +               info->auxd_enabled && domain->type == >> IOMMU_DOMAIN_UNMANAGED; >> } >> static void auxiliary_link_device(struct dmar_domain *domain, >> >> >> Regards, >> Jerry >> > > With the patch, I avoid the panic, but I'm seeing an issue similar to > the epyc system. > I'm getting dmar faults from a couple of nics and the hp ilo. The > addresses in question > were in e820 reserved sections, but there aren't rmrr covering those > addresses. The system > manages to harvest the vmcore and reboot like the epyc. Without the > patches I don't see > the dmar faults. I needed to give this system back, but I'll try to poke > at it some more > in the next couple of days. Thanks and looking forward to further debugging information. Best regards, baolu