From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B13FC43461 for ; Fri, 16 Apr 2021 09:52:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E37D86115B for ; Fri, 16 Apr 2021 09:52:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242198AbhDPJwe (ORCPT ); Fri, 16 Apr 2021 05:52:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242204AbhDPJwc (ORCPT ); Fri, 16 Apr 2021 05:52:32 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4611C061574 for ; Fri, 16 Apr 2021 02:52:06 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id w4so22343922wrt.5 for ; Fri, 16 Apr 2021 02:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=/JSJp+Tkpj2oHC+t+aQ3pMzn5E4MQekWdcaHODVVDPs=; b=Zd2CpPg+2KjAqulL9Rnwmz6bHroGJTQVRiJWLNk6QjtL+9aK70oyA+gP4hUZ+xNgCX pblmTtjslgvg8A8RxjsWDlJEFQMqHBya+h5w7Rm7lasOTgQ9+vpvbBBQMs3jcUk3PjkT iLnDhBZbsW7QPC1t+byTsyp9j+4phtKgSYLmbZdM8wSxjwCbl1lz2MArmvahFC70AXZW 7Su7vcoeaspUdvfq681Z9k8KOmn/m1Cnv6y/9qacbQQCd/mTmGwxhY3Tf3TFePhfx6Qp jsDLIv5iTGqcB1UdAuEykG5TfmkdzTUy0XxwkqpSjNuEK1JU9Y+WPf3GdnHJnw2gHU5a acyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/JSJp+Tkpj2oHC+t+aQ3pMzn5E4MQekWdcaHODVVDPs=; b=FjcsHiQnnQam+BMn2jGC0WlpKZKwaCgMlWDWfBSNXljz91wr8rwDIy3YxX6/52EN6L wZVb0OTMAOPgh1lvIdrkLkmulT57jOfgMCzasrfyt4h+NJEz3OWVCaiSb41UfEygBfXA uU2x7/kUDRRkkxGvZGFsWQMcZknB9TrpY08zIXTU5TlMaynqOj/t4tEaZB7cSMcqgQFF nYdizpZ8RL2+b1YqAi0UuKB2GybLu1WNMo+BAAI9t4FMVknyAg1pbIzrG52o/MMMexSi IXTszAM2h5jjuFNuJPTL9zUMRjxtUBkUSWNInXpqAxQKPWF0G30QBhRDxX8wN2TtJ/4r RAvg== X-Gm-Message-State: AOAM5333HaIlBo//uksKq4KCyK46CG29ptx3Ud524cjqFSakeS5KAvUC /kh+rYb264CF6BPHn6GjSXBRhA== X-Google-Smtp-Source: ABdhPJwLeVjxevDvuRkaNwCHgSj2pf06ftSAwKCQNXwuAPm7bmGh/kmcoaI44wdJF08QBoLbr7t2yQ== X-Received: by 2002:adf:fbcc:: with SMTP id d12mr8031032wrs.151.1618566725566; Fri, 16 Apr 2021 02:52:05 -0700 (PDT) Received: from MacBook-Pro.local ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id h17sm9483596wru.67.2021.04.16.02.52.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Apr 2021 02:52:05 -0700 (PDT) Subject: Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card To: Doug Anderson , Shaik Sajida Bhanu Cc: Veerabhadrarao Badiganti , Adrian Hunter , Ulf Hansson , Rob Herring , Asutosh Das , Sahitya Tummala , Ram Prakash Gupta , Sayali Lokhande , sartgarg@codeaurora.org, Rajendra Nayak , Sai Prakash Ranjan , Sibi Sankar , cang@codeaurora.org, pragalla@codeaurora.org, nitirawa@codeaurora.org, Linux MMC List , LKML , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Andy Gross , Bjorn Andersson , Evan Green , okukatla@codeaurora.org References: <1616264220-25825-1-git-send-email-sbhanu@codeaurora.org> <6fdf704c4716f5873d413229ca8adc57@codeaurora.org> <8126e130e5c0ea1e7ea867414f0510c0@codeaurora.org> From: Georgi Djakov Message-ID: Date: Fri, 16 Apr 2021 12:52:02 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On 14.04.21 23:25, Doug Anderson wrote: > Hi, > > On Tue, Apr 13, 2021 at 3:59 AM wrote: >> >>>>>>> + required-opps = >>>>>>> <&rpmhpd_opp_low_svs>; >>>>>>> + opp-peak-kBps = <1200000 >>>>>>> 76000>; >>>>>>> + opp-avg-kBps = <1200000 >>>>>>> 50000>; >>>>>> Why are the kBps numbers so vastly different than the ones on sc7180 >>>>>> for the same OPP point. That implies: >>>>>> >>>>>> a) sc7180 is wrong. >>>>>> >>>>>> b) This patch is wrong. >>>>>> >>>>>> c) The numbers are essentially random and don't really matter. >>>>>> >>>>>> Can you identify which of a), b), or c) is correct, or propose an >>>>>> alternate explanation of the difference? >>>>>> >>>> >>>> We calculated bus votes values for both sc7180 and sc7280 with ICB >>>> tool, >>>> above mentioned values we got for sc7280. >>> >>> I don't know what an ICB tool is. Please clarify. >>> >>> Also: just because a tool spits out numbers that doesn't mean it's >>> correct. Presumably the tool could be wrong or incorrectly configured. >>> We need to understand why these numbers are different. >>> >> we checked with ICB tool team on this they conformed as Rennell & Kodiak >> are different chipsets, >> we might see delta in ib/ab values due to delta in scaling factors. If the scaling factor is different, maybe this should be reflected in the BCM data, where we have the following: @vote_scale: scaling factor for vote_x and vote_y This is 1000 by default, but maybe we should set it to some different value for some of the BCMs? I'm adding Odelu, who is more familiar with this platform. > > ...but these numbers are in kbps, aren't they? As I understand it > these aren't supposed to be random numbers spit out by a tool but are > supposed to be understandable by how much bandwidth an IP block (like > MMC) needs from the busses it's connected to. Since the MMC IP block > on sc7180 and sc7280 is roughly the same there shouldn't be a big > difference in numbers. > > Something smells wrong. > > Adding a few people who understand interconnects better than I do, though. > Thanks! Georgi