From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 893BCC433ED for ; Wed, 7 Apr 2021 18:00:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D2FA6128A for ; Wed, 7 Apr 2021 18:00:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355046AbhDGSBF (ORCPT ); Wed, 7 Apr 2021 14:01:05 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:38235 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355040AbhDGSBE (ORCPT ); Wed, 7 Apr 2021 14:01:04 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1617818455; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Uf0AVv8aqmiXb0YftRz/h5+MlBMvFR0+UaFhKIo1nCw=; b=IC+x7+EUXUII52G4Lt8kGoR5bO+bytmG2paru2Ewy+20EoNg+giyc/uppfDAvvO2d7v6wF1Z 1nlSGSyrcM+RECYGuGbvxALTnZT1dAXIqtP+DGGrWnEVPFm83b0k3pcPd8lEW0YwxD+Eavtq Oaf3yZXc5N5lI9Srkslq2sivhDE= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 606df34c2cc44d3aea5126f5 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 07 Apr 2021 18:00:44 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 19114C43462; Wed, 7 Apr 2021 18:00:44 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1C2BCC43461; Wed, 7 Apr 2021 18:00:43 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 07 Apr 2021 11:00:43 -0700 From: abhinavk@codeaurora.org To: Zhen Lei Cc: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm , dri-devel , freedreno , linux-kernel , AngeloGioacchino Del Regno Subject: Re: [PATCH 1/1] drm/msm/dpu: remove unused local variable 'cmd_enc' In-Reply-To: <20210407083334.2762-1-thunder.leizhen@huawei.com> References: <20210407083334.2762-1-thunder.leizhen@huawei.com> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-04-07 01:33, Zhen Lei wrote: > Fixes the following W=1 kernel build warning: > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function > ‘dpu_encoder_phys_cmd_wait_for_commit_done’: > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning: > variable ‘cmd_enc’ set but not used [-Wunused-but-set-variable] > > Fixes: fe286893ed34 ("drm/msm/dpu: Remove unused call in > wait_for_commit_done") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > index b2be39b9144e449..088900841bf8baa 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > @@ -685,10 +685,6 @@ static int > dpu_encoder_phys_cmd_wait_for_tx_complete( > static int dpu_encoder_phys_cmd_wait_for_commit_done( > struct dpu_encoder_phys *phys_enc) > { > - struct dpu_encoder_phys_cmd *cmd_enc; > - > - cmd_enc = to_dpu_encoder_phys_cmd(phys_enc); > - > /* only required for master controller */ > if (!dpu_encoder_phys_cmd_is_master(phys_enc)) > return 0;