From: Prasad Malisetty <pmaliset@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: agross@kernel.org, bhelgaas@google.com,
bjorn.andersson@linaro.org, lorenzo.pieralisi@arm.com,
robh+dt@kernel.org, svarbanov@mm-sol.com,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
dianders@chromium.org, mka@chromium.org, vbadigan@codeaurora.org,
sallenki@codeaurora.org, manivannan.sadhasivam@linaro.org
Subject: Re: [PATCH v5 2/4] arm64: dts: qcom: sc7280: Add PCIe and PHY related nodes
Date: Tue, 17 Aug 2021 13:33:28 +0530 [thread overview]
Message-ID: <c13f2cad016c3ed5b7d70abdc9c7f812@codeaurora.org> (raw)
In-Reply-To: <CAE-0n51uQJ4VDDbmpu18mJw4zcDhD-tvUDgi0LQ4-zAgBUKJ6A@mail.gmail.com>
On 2021-08-11 01:01, Stephen Boyd wrote:
> Quoting Prasad Malisetty (2021-08-09 21:08:34)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 53a21d0..4500d88 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -1598,6 +1712,18 @@
>> bias-bus-hold;
>> };
>> };
>> +
>> + pcie1_default_state: pcie1-default-state {
>> + clkreq {
>> + pins = "gpio79";
>> + function = "pcie1_clkreqn";
>> + };
>> +
>> + wake-n {
>> + pins = "gpio3";
>> + function = "gpio";
>
> This is function gpio, so presumably board designers could decide to
> change the wake gpio to something else, right? I'd prefer we move
> wake-n
> to the board level (idp) as well. gpio79 looks fine as it is muxed to
> be
> the pcie1_clkreqn function, not gpio, so it seems to be a dedicated pin
> for this purpose.
Sure, I will move it IDP file in next version.
next prev parent reply other threads:[~2021-08-17 8:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 4:08 [PATCH v5 0/4] Add DT bindings and DT nodes for PCIe and PHY in SC7280 Prasad Malisetty
2021-08-10 4:08 ` [PATCH v5 1/4] dt-bindings: pci: qcom: Document PCIe bindings for SC7280 Prasad Malisetty
2021-08-10 4:08 ` [PATCH v5 2/4] arm64: dts: qcom: sc7280: Add PCIe and PHY related nodes Prasad Malisetty
2021-08-10 19:25 ` Stephen Boyd
2021-08-10 19:31 ` Stephen Boyd
2021-08-17 8:03 ` Prasad Malisetty [this message]
2021-08-12 6:07 ` Manivannan Sadhasivam
2021-08-17 6:00 ` Prasad Malisetty
2021-08-10 4:08 ` [PATCH v5 3/4] arm64: dts: qcom: sc7280: Add PCIe nodes for IDP board Prasad Malisetty
2021-08-10 19:32 ` Stephen Boyd
2021-08-10 4:08 ` [PATCH v5 4/4] PCI: qcom: Switch pcie_1_pipe_clk_src after PHY init in SC7280 Prasad Malisetty
2021-08-10 19:37 ` Stephen Boyd
2021-08-17 6:40 ` Prasad Malisetty
2021-08-12 6:11 ` Manivannan Sadhasivam
2021-08-17 6:37 ` Prasad Malisetty
2021-08-17 17:26 ` Prasad Malisetty
2021-08-24 8:10 ` Prasad Malisetty
2021-08-25 19:30 ` Stephen Boyd
2021-08-25 21:25 ` Bjorn Helgaas
2021-08-26 7:21 ` Prasad Malisetty
2021-08-26 12:37 ` Rob Herring
2021-08-31 6:37 ` Prasad Malisetty
2021-08-31 15:37 ` Bjorn Helgaas
2021-09-09 17:51 ` Prasad Malisetty
2021-09-09 18:08 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c13f2cad016c3ed5b7d70abdc9c7f812@codeaurora.org \
--to=pmaliset@codeaurora.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sallenki@codeaurora.org \
--cc=svarbanov@mm-sol.com \
--cc=swboyd@chromium.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).