From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40B98C04AAC for ; Mon, 20 May 2019 13:20:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14EFD20815 for ; Mon, 20 May 2019 13:20:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732217AbfETNUJ (ORCPT ); Mon, 20 May 2019 09:20:09 -0400 Received: from foss.arm.com ([217.140.101.70]:45734 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727319AbfETNUJ (ORCPT ); Mon, 20 May 2019 09:20:09 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 00BC880D; Mon, 20 May 2019 06:20:09 -0700 (PDT) Received: from [10.1.196.50] (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BF2183F5AF; Mon, 20 May 2019 06:20:07 -0700 (PDT) Subject: Re: [PATCH 1/3] firmware: qcom_scm: Use proper types for dma mappings To: Ian Jackson , Stephen Boyd Cc: Andy Gross , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , Bjorn Andersson , Avaneesh Kumar Dwivedi References: <23774.56553.445601.436491@mariner.uk.xensource.com> <20190517210923.202131-2-swboyd@chromium.org> <23778.30265.117488.781364@mariner.uk.xensource.com> From: Julien Grall Message-ID: Date: Mon, 20 May 2019 14:20:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <23778.30265.117488.781364@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Ian, On 20/05/2019 10:41, Ian Jackson wrote: > Stephen Boyd writes ("[PATCH 1/3] firmware: qcom_scm: Use proper types for dma mappings"): >> We need to use the proper types and convert between physical addresses >> and dma addresses here to avoid mismatch warnings. This is especially >> important on systems with a different size for dma addresses and >> physical addresses. Otherwise, we get the following warning: > > Thanks. Do you expect this to be a backport candidate and if so how > far back do you think it will go ? To be honest, I am not really > convinced that backporting this would be a service to users. The > situation I have, where I changed the compiler but kept the old kernel > code and old configuration, is going to be fairly rare. I will leave the maintainers answering to that. > > I think I should probably therefore disable this driver in the config > on stable branches of Linux, at least. If we decide to disable the driver, then we would need to add in our .config, then we would need to disable completely the support for Qualcomm (i.e CONFIG_ARCH_QCOM=n) on Arm32. This should not be an issue in osstest as we don't test any qualcomm board so far. Cheers, -- Julien Grall