From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FEA9C7EE29 for ; Fri, 2 Jun 2023 13:18:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236126AbjFBNSU (ORCPT ); Fri, 2 Jun 2023 09:18:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236103AbjFBNST (ORCPT ); Fri, 2 Jun 2023 09:18:19 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD5FBE69 for ; Fri, 2 Jun 2023 06:18:06 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-974265a1a40so704341066b.0 for ; Fri, 02 Jun 2023 06:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685711885; x=1688303885; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=CJSu3AsQZdRU5oftVTGS98fipTM8z81jlREGCoePaq8=; b=zYpO1qHsCCwzE2/eTnIcPKIG2K3q0mciYhit910x9u42eD0LqBJWbl4j5xmQ8KzT5f aSJT0zNPVKjH6V7GKwZi0Zxkq8/7BI9AFCQjKcMpZA8gqdBDuGNaYNkVgbgrltxxhs+e RxejqCVcp2oN4PsPM2mNuoKOOvddKnWdvFKjk8bY2b4fFUBO1oItkcQ3fcJz7PbyKyZb NK3PQL9jK3RLntkG8PBppCO9YQqp6Wk9eHv5d60ubdobGYG1AktwVC9JCTOZTzwuuprR MV79fpfPw+xwxepbKTbe6QPIBuYK/xrRB5FDgssKEjGYWJNLtIjEZLeLwmo3f3nhXpq0 Y1Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685711885; x=1688303885; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CJSu3AsQZdRU5oftVTGS98fipTM8z81jlREGCoePaq8=; b=CZSmabtZjpERHuhddli4x0VfDc9DrGy691qXpx5ltxm0DbrkQhwTPANGwO9X7yrFgE fhrGKeSE6ebwd4b4/keGZyoqZZg6Qyn0pzAkUoeU0NHEEjGVsZmN5luWPl6SUQU5l4uF Aap38Nhhq7eZJOOvjPqrA7DDwZz9oE0VBkFdR+7ugVGy6Wmh8ldvr898INQ8J/FMn5Zm IV04xLivvjOqaL7U2QsZt64Q6z9dfz2VwNIfo3pTGq3lz+N1JKoucswxlhEEZx20a8RE eG/q51TyQ1Qp5iG4+U5e8MzqGQJMA1PFufKZnwtcGAx6GcAZckn5wb1fzAyOTzHDGyt8 qixg== X-Gm-Message-State: AC+VfDzLs5jrxk7tw05/if8DWnkVN7McJPt8clvUbHNCGWvEK7vKyPIh q/57WQzx1JqMy0QWgIgryeyw0Q== X-Google-Smtp-Source: ACHHUZ4a3PczmBUd5Upr++tQnwXTM68qCwyR1itmINtvHFgnQ04yVJDTQSYcKtYDnQU8UkPzft2Frw== X-Received: by 2002:a17:907:9289:b0:96f:ddaa:c30d with SMTP id bw9-20020a170907928900b0096fddaac30dmr4502642ejc.26.1685711885389; Fri, 02 Jun 2023 06:18:05 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id sa25-20020a170906edb900b00965f98eefc1sm742937ejb.116.2023.06.02.06.18.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 06:18:04 -0700 (PDT) Message-ID: Date: Fri, 2 Jun 2023 15:18:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 5/6] arm64: dts: qcom: sc8280xp: add resets for soundwire controllers To: Srinivas Kandagatla , andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: johan+linaro@kernel.org, agross@kernel.org, konrad.dybcio@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230525122930.17141-1-srinivas.kandagatla@linaro.org> <20230525122930.17141-6-srinivas.kandagatla@linaro.org> Content-Language: en-US In-Reply-To: <20230525122930.17141-6-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Resending as my previous email probably got lost. If you got it twice, apologies. On 25/05/2023 14:29, Srinivas Kandagatla wrote: > Soundwire controllers on sc8280xp needs an explicit reset, add > support for this. > > Signed-off-by: Srinivas Kandagatla > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 6730349e34f4..39be2e89ce05 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -6,6 +6,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -2560,6 +2561,8 @@ > interrupts = ; > clocks = <&rxmacro>; > clock-names = "iface"; > + resets = <&lpass_audiocc LPASS_AUDIO_SWR_RX_CGCR>; > + reset-names = "swr_audio_cgcr"; > label = "RX"; > > qcom,din-ports = <0>; > @@ -2634,6 +2637,8 @@ > interrupts = ; > clocks = <&wsamacro>; > clock-names = "iface"; > + resets = <&lpass_audiocc LPASS_AUDIO_SWR_WSA_CGCR>; > + reset-names = "swr_audio_cgcr"; > label = "WSA"; > > qcom,din-ports = <2>; > @@ -2656,6 +2661,14 @@ > status = "disabled"; > }; > > + lpass_audiocc: clock-controller@32a9000 { > + compatible = "qcom,sc8280xp-lpassaudiocc"; > + reg = <0 0x032a9000 0 0x1000>; > + qcom,adsp-pil-mode; Here and... > + #clock-cells = <1>; > + #reset-cells = <1>; > + }; > + > swr2: soundwire-controller@3330000 { > compatible = "qcom,soundwire-v1.6.0"; > reg = <0 0x03330000 0 0x2000>; > @@ -2665,6 +2678,8 @@ > > clocks = <&txmacro>; > clock-names = "iface"; > + resets = <&lpasscc LPASS_AUDIO_SWR_TX_CGCR>; > + reset-names = "swr_audio_cgcr"; > label = "TX"; > #sound-dai-cells = <1>; > #address-cells = <2>; > @@ -2901,6 +2916,14 @@ > }; > }; > > + lpasscc: clock-controller@33e0000 { > + compatible = "qcom,sc8280xp-lpasscc"; > + reg = <0 0x033e0000 0 0x12000>; > + qcom,adsp-pil-mode; ... here - where do you use these properties? Driver ignores them. AFAIR, these were only for sc7280 where we supported two variants for audio. Best regards, Krzysztof