From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Guenter Roeck <linux@roeck-us.net>,
"agross@kernel.org" <agross@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-power <linux-power@fi.rohmeurope.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Amit Kucheria <amitk@kernel.org>,
Matteo Croce <mcroce@microsoft.com>,
Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Mike Rapoport <rppt@kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v8 03/10] thermal: Use generic HW-protection shutdown API
Date: Thu, 22 Apr 2021 10:10:41 +0200 [thread overview]
Message-ID: <c9b61f91-301b-92a2-f5e7-e8b8e2373040@linaro.org> (raw)
In-Reply-To: <3b62226e320ab412357e102baf6d628e354a0b61.1618832466.git.matti.vaittinen@fi.rohmeurope.com>
On 19/04/2021 13:49, Matti Vaittinen wrote:
> The hardware shutdown function was exported from kernel/reboot for
> other subsystems to use. Logic is copied from the thermal_core. The
> protection mutex is replaced by an atomic_t to allow calls also from
> an IRQ context.
>
> Use the exported API instead of implementing own just for the
> thermal_core.
Can you update the documentation:
Documentation/driver-api/thermal/sysfs-api.rst
5. thermal_emergency_poweroff
Thanks
-- Daniel
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
>
> ---
> Changelog:
> v8:
> - new patch (change added in v7, splitted in own patch at v8)
>
> Use the exported API instead
> ---
> drivers/thermal/thermal_core.c | 63 +++-------------------------------
> 1 file changed, 4 insertions(+), 59 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 996c038f83a4..b1444845af38 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -36,10 +36,8 @@ static LIST_HEAD(thermal_governor_list);
>
> static DEFINE_MUTEX(thermal_list_lock);
> static DEFINE_MUTEX(thermal_governor_lock);
> -static DEFINE_MUTEX(poweroff_lock);
>
> static atomic_t in_suspend;
> -static bool power_off_triggered;
>
> static struct thermal_governor *def_governor;
>
> @@ -327,70 +325,18 @@ static void handle_non_critical_trips(struct thermal_zone_device *tz, int trip)
> def_governor->throttle(tz, trip);
> }
>
> -/**
> - * thermal_emergency_poweroff_func - emergency poweroff work after a known delay
> - * @work: work_struct associated with the emergency poweroff function
> - *
> - * This function is called in very critical situations to force
> - * a kernel poweroff after a configurable timeout value.
> - */
> -static void thermal_emergency_poweroff_func(struct work_struct *work)
> -{
> - /*
> - * We have reached here after the emergency thermal shutdown
> - * Waiting period has expired. This means orderly_poweroff has
> - * not been able to shut off the system for some reason.
> - * Try to shut down the system immediately using kernel_power_off
> - * if populated
> - */
> - WARN(1, "Attempting kernel_power_off: Temperature too high\n");
> - kernel_power_off();
> -
> - /*
> - * Worst of the worst case trigger emergency restart
> - */
> - WARN(1, "Attempting emergency_restart: Temperature too high\n");
> - emergency_restart();
> -}
> -
> -static DECLARE_DELAYED_WORK(thermal_emergency_poweroff_work,
> - thermal_emergency_poweroff_func);
> -
> -/**
> - * thermal_emergency_poweroff - Trigger an emergency system poweroff
> - *
> - * This may be called from any critical situation to trigger a system shutdown
> - * after a known period of time. By default this is not scheduled.
> - */
> -static void thermal_emergency_poweroff(void)
> +void thermal_zone_device_critical(struct thermal_zone_device *tz)
> {
> - int poweroff_delay_ms = CONFIG_THERMAL_EMERGENCY_POWEROFF_DELAY_MS;
> /*
> * poweroff_delay_ms must be a carefully profiled positive value.
> - * Its a must for thermal_emergency_poweroff_work to be scheduled
> + * Its a must for forced_emergency_poweroff_work to be scheduled.
> */
> - if (poweroff_delay_ms <= 0)
> - return;
> - schedule_delayed_work(&thermal_emergency_poweroff_work,
> - msecs_to_jiffies(poweroff_delay_ms));
> -}
> + int poweroff_delay_ms = CONFIG_THERMAL_EMERGENCY_POWEROFF_DELAY_MS;
>
> -void thermal_zone_device_critical(struct thermal_zone_device *tz)
> -{
> dev_emerg(&tz->device, "%s: critical temperature reached, "
> "shutting down\n", tz->type);
>
> - mutex_lock(&poweroff_lock);
> - if (!power_off_triggered) {
> - /*
> - * Queue a backup emergency shutdown in the event of
> - * orderly_poweroff failure
> - */
> - thermal_emergency_poweroff();
> - orderly_poweroff(true);
> - power_off_triggered = true;
> - }
> - mutex_unlock(&poweroff_lock);
> + hw_protection_shutdown("Temperature too high", poweroff_delay_ms);
> }
> EXPORT_SYMBOL(thermal_zone_device_critical);
>
> @@ -1549,7 +1495,6 @@ static int __init thermal_init(void)
> ida_destroy(&thermal_cdev_ida);
> mutex_destroy(&thermal_list_lock);
> mutex_destroy(&thermal_governor_lock);
> - mutex_destroy(&poweroff_lock);
> return result;
> }
> postcore_initcall(thermal_init);
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-04-22 8:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 11:46 [PATCH v8 00/10] Extend regulator notification support Matti Vaittinen
2021-04-19 11:48 ` [PATCH v8 01/10] dt_bindings: Add protection limit properties Matti Vaittinen
2021-04-19 11:48 ` [PATCH v8 02/10] reboot: Add hardware protection power-off Matti Vaittinen
2021-04-19 11:49 ` [PATCH v8 03/10] thermal: Use generic HW-protection shutdown API Matti Vaittinen
2021-04-22 8:10 ` Daniel Lezcano [this message]
2021-04-22 9:27 ` Vaittinen, Matti
2021-04-19 11:49 ` [PATCH v8 04/10] regulator: add warning flags Matti Vaittinen
2021-04-19 11:50 ` [PATCH v8 05/10] regulator: IRQ based event/error notification helpers Matti Vaittinen
2021-04-19 11:50 ` [PATCH v8 06/10] regulator: add property parsing and callbacks to set protection limits Matti Vaittinen
2021-04-19 11:50 ` [PATCH v8 07/10] dt-bindings: regulator: bd9576 add FET ON-resistance for OCW Matti Vaittinen
2021-04-19 11:51 ` [PATCH v8 08/10] regulator: bd9576: Support error reporting Matti Vaittinen
2021-04-19 11:51 ` [PATCH v8 09/10] regulator: bd9576: Fix the driver name in id table Matti Vaittinen
2021-04-19 11:52 ` [PATCH v8 10/10] MAINTAINERS: Add reviewer for regulator irq_helpers Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9b61f91-301b-92a2-f5e7-e8b8e2373040@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=agross@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=amitk@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=kai.heng.feng@canonical.com \
--cc=keescook@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mcroce@microsoft.com \
--cc=pmladek@suse.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh+dt@kernel.org \
--cc=rppt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).