From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB2FDC10F12 for ; Wed, 17 Apr 2019 08:27:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C13A32073F for ; Wed, 17 Apr 2019 08:27:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727282AbfDQI1t (ORCPT ); Wed, 17 Apr 2019 04:27:49 -0400 Received: from ns.iliad.fr ([212.27.33.1]:49640 "EHLO ns.iliad.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726237AbfDQI1t (ORCPT ); Wed, 17 Apr 2019 04:27:49 -0400 Received: from ns.iliad.fr (localhost [127.0.0.1]) by ns.iliad.fr (Postfix) with ESMTP id 6A0BA1FF14; Wed, 17 Apr 2019 10:27:47 +0200 (CEST) Received: from [192.168.108.49] (freebox.vlq16.iliad.fr [213.36.7.13]) by ns.iliad.fr (Postfix) with ESMTP id 595F120A4D; Wed, 17 Apr 2019 10:27:47 +0200 (CEST) Subject: Re: [PATCH v4 1/2] phy: qcom-qmp: Add msm8998 PCIe QMP PHY support From: Marc Gonzalez To: Kishon Vijay Abraham References: <41108be9-f682-f8a9-fa4a-f1c3cef58cfd@free.fr> Cc: MSM Message-ID: Date: Wed, 17 Apr 2019 10:27:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <41108be9-f682-f8a9-fa4a-f1c3cef58cfd@free.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP ; ns.iliad.fr ; Wed Apr 17 10:27:47 2019 +0200 (CEST) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 09/04/2019 14:48, Marc Gonzalez wrote: > Documentation for this PHY, and the proper configuration settings, > is *not* publicly available. Therefore the initialization sequence > is copied wholesale from downstream: > > https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm8998-v2.dtsi?h=LE.UM.1.3.r3.25#n372 > > Reviewed-by: Vivek Gautam > Signed-off-by: Marc Gonzalez > --- > Changes from v3: Rewrite commit log to make it clear that I didn't have access > to any docs, and just copied the downstream code. > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 110 ++++++++++++++++++++++++++++ > drivers/phy/qualcomm/phy-qcom-qmp.h | 12 +++ > 2 files changed, 122 insertions(+) Hello Kishon, Are there other changes you'd like me to make? Regards.