Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v1] clk: qcom: msm8916: Don't build support by default
@ 2019-06-12 15:52 Marc Gonzalez
  2019-06-12 19:13 ` Bjorn Andersson
  0 siblings, 1 reply; 6+ messages in thread
From: Marc Gonzalez @ 2019-06-12 15:52 UTC (permalink / raw)
  To: Stephen Boyd, Michael Turquette
  Cc: linux-clk, MSM, Georgi Djakov, Amit Kucheria, Bjorn Andersson

Build QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 by default only when
we're building MSM_GCC_8916.

Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
---
 drivers/clk/qcom/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index e1ff83cc361e..d5b065f64afc 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -21,7 +21,7 @@ if COMMON_CLK_QCOM
 
 config QCOM_A53PLL
 	tristate "MSM8916 A53 PLL"
-	default ARCH_QCOM
+	default MSM_GCC_8916
 	help
 	  Support for the A53 PLL on MSM8916 devices. It provides
 	  the CPU with frequencies above 1GHz.
@@ -31,7 +31,7 @@ config QCOM_A53PLL
 config QCOM_CLK_APCS_MSM8916
 	tristate "MSM8916 APCS Clock Controller"
 	depends on QCOM_APCS_IPC || COMPILE_TEST
-	default ARCH_QCOM
+	default MSM_GCC_8916
 	help
 	  Support for the APCS Clock Controller on msm8916 devices. The
 	  APCS is managing the mux and divider which feeds the CPUs.
-- 
2.17.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1] clk: qcom: msm8916: Don't build support by default
  2019-06-12 15:52 [PATCH v1] clk: qcom: msm8916: Don't build support by default Marc Gonzalez
@ 2019-06-12 19:13 ` Bjorn Andersson
  2019-06-12 19:49   ` Stephen Boyd
  2019-06-13 15:05   ` Marc Gonzalez
  0 siblings, 2 replies; 6+ messages in thread
From: Bjorn Andersson @ 2019-06-12 19:13 UTC (permalink / raw)
  To: Marc Gonzalez
  Cc: Stephen Boyd, Michael Turquette, linux-clk, MSM, Georgi Djakov,
	Amit Kucheria

On Wed 12 Jun 08:52 PDT 2019, Marc Gonzalez wrote:

> Build QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 by default only when
> we're building MSM_GCC_8916.
> 
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>

Not sure why these are default at all.

But both drivers are used on platforms other than 8916 as well, so if
anything a fix would be to rename the APCS_MSM8916 to something more
generic (such as QCOM_CLK_APCS_GLOBAL) - but then the content should be
updated and the APCS mailbox driver as well...

Regards,
Bjorn

> ---
>  drivers/clk/qcom/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index e1ff83cc361e..d5b065f64afc 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -21,7 +21,7 @@ if COMMON_CLK_QCOM
>  
>  config QCOM_A53PLL
>  	tristate "MSM8916 A53 PLL"
> -	default ARCH_QCOM
> +	default MSM_GCC_8916
>  	help
>  	  Support for the A53 PLL on MSM8916 devices. It provides
>  	  the CPU with frequencies above 1GHz.
> @@ -31,7 +31,7 @@ config QCOM_A53PLL
>  config QCOM_CLK_APCS_MSM8916
>  	tristate "MSM8916 APCS Clock Controller"
>  	depends on QCOM_APCS_IPC || COMPILE_TEST
> -	default ARCH_QCOM
> +	default MSM_GCC_8916
>  	help
>  	  Support for the APCS Clock Controller on msm8916 devices. The
>  	  APCS is managing the mux and divider which feeds the CPUs.
> -- 
> 2.17.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1] clk: qcom: msm8916: Don't build support by default
  2019-06-12 19:13 ` Bjorn Andersson
@ 2019-06-12 19:49   ` Stephen Boyd
  2019-06-12 20:03     ` Marc Gonzalez
  2019-06-13 15:05   ` Marc Gonzalez
  1 sibling, 1 reply; 6+ messages in thread
From: Stephen Boyd @ 2019-06-12 19:49 UTC (permalink / raw)
  To: Bjorn Andersson, Marc Gonzalez
  Cc: Michael Turquette, linux-clk, MSM, Georgi Djakov, Amit Kucheria

Quoting Bjorn Andersson (2019-06-12 12:13:47)
> On Wed 12 Jun 08:52 PDT 2019, Marc Gonzalez wrote:
> 
> > Build QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 by default only when
> > we're building MSM_GCC_8916.
> > 
> > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> 
> Not sure why these are default at all.
> 
> But both drivers are used on platforms other than 8916 as well, so if
> anything a fix would be to rename the APCS_MSM8916 to something more
> generic (such as QCOM_CLK_APCS_GLOBAL) - but then the content should be
> updated and the APCS mailbox driver as well...
> 

I don't see any use in being this specific. I'd prefer we just leave
this at the ARCH_FOO config level and not try anything more fancy.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1] clk: qcom: msm8916: Don't build support by default
  2019-06-12 19:49   ` Stephen Boyd
@ 2019-06-12 20:03     ` Marc Gonzalez
  2019-06-12 22:42       ` Stephen Boyd
  0 siblings, 1 reply; 6+ messages in thread
From: Marc Gonzalez @ 2019-06-12 20:03 UTC (permalink / raw)
  To: Stephen Boyd, Bjorn Andersson
  Cc: Michael Turquette, linux-clk, MSM, Georgi Djakov, Amit Kucheria

On 12/06/2019 21:49, Stephen Boyd wrote:

> Quoting Bjorn Andersson (2019-06-12 12:13:47)
>
>> On Wed 12 Jun 08:52 PDT 2019, Marc Gonzalez wrote:
>>
>>> Build QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 by default only when
>>> we're building MSM_GCC_8916.
>>>
>>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
>>
>> Not sure why these are default at all.
>>
>> But both drivers are used on platforms other than 8916 as well, so if
>> anything a fix would be to rename the APCS_MSM8916 to something more
>> generic (such as QCOM_CLK_APCS_GLOBAL) - but then the content should be
>> updated and the APCS mailbox driver as well...
> 
> I don't see any use in being this specific. I'd prefer we just leave
> this at the ARCH_FOO config level and not try anything more fancy.

As Bjorn pointed out, why do these default "on" at all?

https://elixir.bootlin.com/linux/latest/source/drivers/clk/qcom/Kconfig

There are dozens of config knobs in drivers/clk/qcom/Kconfig
and only these two force the default.

Let's remove the default altogether.

Regards.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1] clk: qcom: msm8916: Don't build support by default
  2019-06-12 20:03     ` Marc Gonzalez
@ 2019-06-12 22:42       ` Stephen Boyd
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2019-06-12 22:42 UTC (permalink / raw)
  To: Bjorn Andersson, Marc Gonzalez
  Cc: Michael Turquette, linux-clk, MSM, Georgi Djakov, Amit Kucheria

Quoting Marc Gonzalez (2019-06-12 13:03:22)
> On 12/06/2019 21:49, Stephen Boyd wrote:
> 
> > Quoting Bjorn Andersson (2019-06-12 12:13:47)
> >
> >> On Wed 12 Jun 08:52 PDT 2019, Marc Gonzalez wrote:
> >>
> >>> Build QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 by default only when
> >>> we're building MSM_GCC_8916.
> >>>
> >>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> >>
> >> Not sure why these are default at all.
> >>
> >> But both drivers are used on platforms other than 8916 as well, so if
> >> anything a fix would be to rename the APCS_MSM8916 to something more
> >> generic (such as QCOM_CLK_APCS_GLOBAL) - but then the content should be
> >> updated and the APCS mailbox driver as well...
> > 
> > I don't see any use in being this specific. I'd prefer we just leave
> > this at the ARCH_FOO config level and not try anything more fancy.
> 
> As Bjorn pointed out, why do these default "on" at all?
> 
> https://elixir.bootlin.com/linux/latest/source/drivers/clk/qcom/Kconfig
> 
> There are dozens of config knobs in drivers/clk/qcom/Kconfig
> and only these two force the default.
> 
> Let's remove the default altogether.
> 

Sure.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1] clk: qcom: msm8916: Don't build support by default
  2019-06-12 19:13 ` Bjorn Andersson
  2019-06-12 19:49   ` Stephen Boyd
@ 2019-06-13 15:05   ` Marc Gonzalez
  1 sibling, 0 replies; 6+ messages in thread
From: Marc Gonzalez @ 2019-06-13 15:05 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Stephen Boyd, Michael Turquette, linux-clk, MSM, Georgi Djakov,
	Amit Kucheria

On 12/06/2019 21:13, Bjorn Andersson wrote:

> On Wed 12 Jun 08:52 PDT 2019, Marc Gonzalez wrote:
> 
>> Build QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 by default only when
>> we're building MSM_GCC_8916.
>>
>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> 
> Not sure why these are default at all.
> 
> But both drivers are used on platforms other than 8916 as well, so if
> anything a fix would be to rename the APCS_MSM8916 to something more
> generic (such as QCOM_CLK_APCS_GLOBAL) - but then the content should be
> updated and the APCS mailbox driver as well...

Used on platforms other than 8916?  do you see that?

$ git grep compatible drivers/clk/qcom/a53-pll.c
	{ .compatible = "qcom,msm8916-a53pll" },

$ git grep qcom,msm8916-a53pll arch/arm64/boot/dts
arch/arm64/boot/dts/qcom/msm8916.dtsi:                  compatible = "qcom,msm8916-a53pll";


drivers/clk/qcom/apcs-msm8916.c doesn't seem to support DT...

$ git grep qcom-apcs-msm8916-clk
drivers/clk/qcom/apcs-msm8916.c:                .name = "qcom-apcs-msm8916-clk",
drivers/mailbox/qcom-apcs-ipc-mailbox.c:                                                          "qcom-apcs-msm8916-clk",

	if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
		apcs->clk = platform_device_register_data(&pdev->dev, "qcom-apcs-msm8916-clk", -1, NULL, 0);


$ git grep qcom,msm8916-apcs-kpss-global
Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt:                "qcom,msm8916-apcs-kpss-global",
Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt:            compatible = "qcom,msm8916-apcs-kpss-global";
arch/arm64/boot/dts/qcom/msm8916.dtsi:                  compatible = "qcom,msm8916-apcs-kpss-global", "syscon";
drivers/mailbox/qcom-apcs-ipc-mailbox.c:        if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
drivers/mailbox/qcom-apcs-ipc-mailbox.c:        { .compatible = "qcom,msm8916-apcs-kpss-global", .data = (void *)8 },


Are you sure about other platforms?

Regards.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-12 15:52 [PATCH v1] clk: qcom: msm8916: Don't build support by default Marc Gonzalez
2019-06-12 19:13 ` Bjorn Andersson
2019-06-12 19:49   ` Stephen Boyd
2019-06-12 20:03     ` Marc Gonzalez
2019-06-12 22:42       ` Stephen Boyd
2019-06-13 15:05   ` Marc Gonzalez

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org linux-arm-msm@archiver.kernel.org
	public-inbox-index linux-arm-msm


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox