From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6FDBC433E0 for ; Wed, 3 Mar 2021 01:19:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9827F64FA9 for ; Wed, 3 Mar 2021 01:19:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238493AbhCCBLM (ORCPT ); Tue, 2 Mar 2021 20:11:12 -0500 Received: from m42-2.mailgun.net ([69.72.42.2]:31130 "EHLO m42-2.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347847AbhCBGqE (ORCPT ); Tue, 2 Mar 2021 01:46:04 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1614667544; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=lPBgyd1J7Yq8i540u5i8VAgbFU7w/HyUwEY4QeeVj30=; b=t3OUaUfIYmfAnT24D/BTPJ+3A0vaQ4sGRcB14twILkZpjVyBGNxeusimN+DRULKA851NPQU1 hXSiu1fzgWwrIDQ6roEzWkOK4Am4kBX8sNhev6FzMegOF3mGCaK8aB5ONprOJeu6T3i3Fbna C5uNxEN+/o04bRRKopMCz7BS9CM= X-Mailgun-Sending-Ip: 69.72.42.2 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 603ddef6832f19b9efab1641 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 02 Mar 2021 06:45:10 GMT Sender: saiprakash.ranjan=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5D6B4C43467; Tue, 2 Mar 2021 06:45:10 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 60477C433C6; Tue, 2 Mar 2021 06:45:09 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 02 Mar 2021 12:15:09 +0530 From: Sai Prakash Ranjan To: Doug Anderson Cc: Mathieu Poirier , Suzuki K Poulose , Mike Leach , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Leo Yan , Jiri Olsa , Namhyung Kim , coresight@lists.linaro.org, Stephen Boyd , Denis Nikitin , Mattias Nissler , Al Grant , linux-arm-msm , LKML , Linux ARM Subject: Re: [PATCHv2 2/4] perf evsel: Print warning for excluding kernel mode instruction tracing In-Reply-To: References: <523a5af43615b804aa1211a3f27e06226d7159bc.1614624041.git.saiprakash.ranjan@codeaurora.org> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi On 2021-03-02 04:13, Doug Anderson wrote: > Hi, > > On Mon, Mar 1, 2021 at 11:05 AM Sai Prakash Ranjan > wrote: >> >> Add a warning message to check CONFIG_EXCLUDE_KERNEL_HW_ITRACE kernel >> config which excludes kernel mode instruction tracing to help perf >> tool >> users identify the perf event open failure when they attempt kernel >> mode >> tracing with this config enabled. >> >> Tested-by: Denis Nikitin >> Signed-off-by: Sai Prakash Ranjan >> --- >> tools/perf/util/evsel.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > I'm not really knowledgeable at all about the perf subsystem so my > review doesn't hold a lot of weight. However, Sai's patch seems sane > to me. > > Reviewed-by: Douglas Anderson Thanks for the review, I carefully modified all the patch commit messages to change the config and wording from CONFIG_EXCLUDE_KERNEL_HW_ITRACE to CONFIG_EXCLUDE_KERNEL_PMU_TRACE but missed this commit message. I will fix this up in v3, but will hold off posting v3 till I get some feedback on other patches. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation