From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D64AC47423 for ; Fri, 2 Oct 2020 08:07:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15A832074B for ; Fri, 2 Oct 2020 08:07:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="oul1fWgc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726398AbgJBIHC (ORCPT ); Fri, 2 Oct 2020 04:07:02 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:45630 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725993AbgJBIHC (ORCPT ); Fri, 2 Oct 2020 04:07:02 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1601626021; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=DpzPdf9SuGFakeKDAP+tZzUbDX47U9mv46HDpRpFsVQ=; b=oul1fWgcvlmrWBD+DdHaYNmXbQGHZI/kq41nnMyDbmcUP/xi5ZZl5zYcRVxlUak/ICXFQHfD dR0Rx3qDhp0n3aGux6G1Y7bAwgJCh3B9A6mm7golbNR69z6234JzS864xPI1sP6FDB9h6p/G vp+4FqN+fYN2N5zNM8eUU4C7Plw= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 5f76df83e89f7b4c7851d2c3 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 02 Oct 2020 08:06:27 GMT Sender: saiprakash.ranjan=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E318CC433FF; Fri, 2 Oct 2020 08:06:26 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1B4F1C433CA; Fri, 2 Oct 2020 08:06:26 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 02 Oct 2020 13:36:26 +0530 From: Sai Prakash Ranjan To: Robin Murphy Cc: stanimir.varbanov@linaro.org, mchehab@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH] media: venus: core: Drop local dma_parms In-Reply-To: References: Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Robin, On 2020-09-04 02:44, Robin Murphy wrote: > Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms > for platform devices"), struct platform_device already provides a > dma_parms structure, so we can save allocating another one. > > Also the DMA segment size is simply a size, not a bitmask. > > Signed-off-by: Robin Murphy > --- > drivers/media/platform/qcom/venus/core.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/core.c > b/drivers/media/platform/qcom/venus/core.c > index 203c6538044f..2fa9275d75ff 100644 > --- a/drivers/media/platform/qcom/venus/core.c > +++ b/drivers/media/platform/qcom/venus/core.c > @@ -226,13 +226,7 @@ static int venus_probe(struct platform_device > *pdev) > if (ret) > return ret; > > - if (!dev->dma_parms) { > - dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms), > - GFP_KERNEL); > - if (!dev->dma_parms) > - return -ENOMEM; > - } > - dma_set_max_seg_size(dev, DMA_BIT_MASK(32)); > + dma_set_max_seg_size(dev, UINT_MAX); > > INIT_LIST_HEAD(&core->instances); > mutex_init(&core->lock); This reintroduced dma api debug warning which the original commit was addressing or rather thought it addressed. DMA-API: qcom-venus aa00000.video-codec: mapping sg segment longer than device claims to support [len=4194304] [max=65536] WARNING: CPU: 3 PID: 5365 at kernel/dma/debug.c:1225 debug_dma_map_sg+0x1ac/0x2c8 <...> pstate: 60400009 (nZCv daif +PAN -UAO) pc : debug_dma_map_sg+0x1ac/0x2c8 lr : debug_dma_map_sg+0x1ac/0x2c8 sp : ffffff8016517850 x29: ffffff8016517860 x28: 0000000000010000 x27: 00000000ffffffff x26: ffffff80da45eb00 x25: ffffffd03c465000 x24: ffffffd03b3c1000 x23: ffffff803e262d80 x22: ffffff80d9a0d010 x21: 0000000000000001 x20: 0000000000000001 x19: 0000000000000001 x18: 00000000ffff0a10 x17: ffffffd03b84a000 x16: 0000000000000037 x15: ffffffd03a950610 x14: 0000000000000001 x13: 0000000000000000 x12: 00000000a3b31442 x11: 0000000000000000 x10: dfffffd000000001 x9 : f544368f90c5ee00 x8 : f544368f90c5ee00 x7 : ffffffd03af5d570 x6 : 0000000000000000 x5 : 0000000000000080 x4 : 0000000000000001 x3 : ffffffd03a9174b0 x2 : 0000000000000001 x1 : 0000000000000008 x0 : 000000000000007a Call trace: debug_dma_map_sg+0x1ac/0x2c8 vb2_dma_sg_alloc+0x274/0x2f4 [videobuf2_dma_sg] __vb2_queue_alloc+0x14c/0x3b0 [videobuf2_common] vb2_core_reqbufs+0x234/0x374 [videobuf2_common] vb2_reqbufs+0x4c/0x64 [videobuf2_v4l2] v4l2_m2m_reqbufs+0x50/0x84 [v4l2_mem2mem] v4l2_m2m_ioctl_reqbufs+0x2c/0x38 [v4l2_mem2mem] v4l_reqbufs+0x4c/0x5c __video_do_ioctl+0x2cc/0x3e0 video_usercopy+0x3b0/0x910 video_ioctl2+0x38/0x48 v4l2_ioctl+0x6c/0x80 do_video_ioctl+0xb54/0x2708 v4l2_compat_ioctl32+0x5c/0xcc __se_compat_sys_ioctl+0x100/0x2064 __arm64_compat_sys_ioctl+0x20/0x2c el0_svc_common+0xa8/0x178 el0_svc_compat_handler+0x2c/0x40 el0_svc_compat+0x8/0x10 Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation