Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: mturquette@baylibre.com, sboyd@kernel.org, mark.rutland@arm.com,
	agross@kernel.org, bjorn.andersson@linaro.org,
	marc.w.gonzalez@free.fr, linux-arm-msm@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v8 2/4] dt-bindings: clock: Convert qcom,mmcc to DT schema
Date: Tue, 12 Nov 2019 09:11:16 -0700
Message-ID: <d2919fc4-2e96-f50b-a19e-ce6afe22a5cd@codeaurora.org> (raw)
In-Reply-To: <20191112005802.GA9638@bogus>

On 11/11/2019 5:58 PM, Rob Herring wrote:
> On Fri, Nov 08, 2019 at 04:17:33PM -0700, Jeffrey Hugo wrote:
>> Convert the qcom,mmcc-X clock controller binding to DT schema.
>>
>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>> ---
>>   .../devicetree/bindings/clock/qcom,mmcc.txt        | 28 ----------
>>   .../devicetree/bindings/clock/qcom,mmcc.yaml       | 59 ++++++++++++++++++++++
>>   2 files changed, 59 insertions(+), 28 deletions(-)
>>   delete mode 100644 Documentation/devicetree/bindings/clock/qcom,mmcc.txt
>>   create mode 100644 Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.txt b/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
>> deleted file mode 100644
>> index 8b0f784..0000000
>> --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
>> +++ /dev/null
>> @@ -1,28 +0,0 @@
>> -Qualcomm Multimedia Clock & Reset Controller Binding
>> -----------------------------------------------------
>> -
>> -Required properties :
>> -- compatible : shall contain only one of the following:
>> -
>> -			"qcom,mmcc-apq8064"
>> -			"qcom,mmcc-apq8084"
>> -			"qcom,mmcc-msm8660"
>> -			"qcom,mmcc-msm8960"
>> -			"qcom,mmcc-msm8974"
>> -			"qcom,mmcc-msm8996"
>> -
>> -- reg : shall contain base register location and length
>> -- #clock-cells : shall contain 1
>> -- #reset-cells : shall contain 1
>> -
>> -Optional properties :
>> -- #power-domain-cells : shall contain 1
>> -
>> -Example:
>> -	clock-controller@4000000 {
>> -		compatible = "qcom,mmcc-msm8960";
>> -		reg = <0x4000000 0x1000>;
>> -		#clock-cells = <1>;
>> -		#reset-cells = <1>;
>> -		#power-domain-cells = <1>;
>> -	};
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
>> new file mode 100644
>> index 0000000..61ed4a2
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
>> @@ -0,0 +1,59 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/bindings/clock/qcom,mmcc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Multimedia Clock & Reset Controller Binding
>> +
>> +maintainers:
>> +  - Jeffrey Hugo <jhugo@codeaurora.org>
>> +
>> +description: |
>> +  Qualcomm multimedia clock control module which supports the clocks, resets and
>> +  power domains.
>> +
>> +properties:
>> +  compatible :
>> +    enum:
>> +       - qcom,mmcc-apq8064
>> +       - qcom,mmcc-apq8084
>> +       - qcom,mmcc-msm8660
>> +       - qcom,mmcc-msm8960
>> +       - qcom,mmcc-msm8974
>> +       - qcom,mmcc-msm8996
>> +
>> +  '#clock-cells':
>> +    const: 1
>> +
>> +  '#reset-cells':
>> +    const: 1
>> +
>> +  '#power-domain-cells':
>> +    const: 1
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  protected-clocks:
>> +    description:
>> +       Protected clock specifier list as per common clock binding
> 
> Wasn't documented before. Okay to add here, but mention it in the commit
> msg.

Its a generic property that applies to all providers.  In the non-yaml 
bindings, its was documented in the clock-binding.txt, thus implicitly 
documented for all the bindings.  That doesn't work in yaml, so I'm 
making it explicit here (following the GCC bindings you already 
approved).  Nothing changes.

> 
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - '#clock-cells'
>> +  - '#reset-cells'
>> +  - '#power-domain-cells'
>> +
>> +examples:
>> +  # Example for MMCC for MSM8960:
>> +  - |
>> +    clock-controller@4000000 {
>> +      compatible = "qcom,mmcc-msm8960";
>> +      reg = <0x4000000 0x1000>;
>> +      #clock-cells = <1>;
>> +      #reset-cells = <1>;
>> +      #power-domain-cells = <1>;
>> +    };
>> +...
>> -- 
>> Qualcomm Technologies, Inc. is a member of the
>> Code Aurora Forum, a Linux Foundation Collaborative Project.
>>


-- 
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 23:16 [PATCH v8 0/4] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-11-08 23:17 ` [PATCH v8 1/4] dt-bindings: clock: Document external clocks for MSM8998 gcc Jeffrey Hugo
2019-11-12  0:44   ` Rob Herring
2019-11-12 16:25     ` Jeffrey Hugo
2019-11-12 18:37       ` Rob Herring
2019-11-12 19:38         ` Jeffrey Hugo
2019-11-12 21:18           ` Rob Herring
2019-11-12 22:03             ` Jeffrey Hugo
2019-11-08 23:17 ` [PATCH v8 2/4] dt-bindings: clock: Convert qcom,mmcc to DT schema Jeffrey Hugo
2019-11-12  0:58   ` Rob Herring
2019-11-12 16:11     ` Jeffrey Hugo [this message]
2019-11-08 23:17 ` [PATCH v8 3/4] dt-bindings: clock: Add support for the MSM8998 mmcc Jeffrey Hugo
2019-11-12  0:55   ` Rob Herring
2019-11-12 16:07     ` Jeffrey Hugo
2019-11-12  0:59   ` Rob Herring
2019-11-08 23:18 ` [PATCH v8 4/4] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Jeffrey Hugo

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2919fc4-2e96-f50b-a19e-ce6afe22a5cd@codeaurora.org \
    --to=jhugo@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git