From: Maulik Shah <mkshah@codeaurora.org>
To: Vinod Koul <vkoul@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8250: Fix PDC compatible and reg
Date: Tue, 21 Apr 2020 13:40:17 +0530 [thread overview]
Message-ID: <d67adcc2-7f5c-3ed7-5c7c-c3b6b46cbd0b@codeaurora.org> (raw)
In-Reply-To: <20200421070227.GD72691@vkoul-mobl>
Hi,
We can drop the second reg,
, <0 0x17c000f0 0 0x60>
The change [1] to read second reg and configure it, is not yet gone in
pdc irqchip driver.
Otherthan this, the patch looks good to me.
Thanks,
Maulik
On 4/21/2020 12:32 PM, Vinod Koul wrote:
> On 14-04-20, 22:47, Bjorn Andersson wrote:
>> The pdc node suffers from both too narrow compatible and insufficient
>> cells in the reg, fix these.
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
> Tested-by: Vinod Koul <vkoul@kernel.org>
>
>> Fixes: 60378f1a171e ("arm64: dts: qcom: sm8250: Add sm8250 dts file")
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm8250.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> index 891d83b2afea..2a7eaefd221d 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> @@ -314,8 +314,8 @@ intc: interrupt-controller@17a00000 {
>> };
>>
>> pdc: interrupt-controller@b220000 {
>> - compatible = "qcom,sm8250-pdc";
>> - reg = <0x0b220000 0x30000>, <0x17c000f0 0x60>;
>> + compatible = "qcom,sm8250-pdc", "qcom,pdc";
>> + reg = <0 0x0b220000 0 0x30000>, <0 0x17c000f0 0 0x60>;
>> qcom,pdc-ranges = <0 480 94>, <94 609 31>,
>> <125 63 1>, <126 716 12>;
>> #interrupt-cells = <2>;
>> --
>> 2.24.0
[1] https://patchwork.kernel.org/patch/11145353/
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
prev parent reply other threads:[~2020-04-21 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 5:47 [PATCH] arm64: dts: qcom: sm8250: Fix PDC compatible and reg Bjorn Andersson
2020-04-21 7:02 ` Vinod Koul
2020-04-21 8:10 ` Maulik Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d67adcc2-7f5c-3ed7-5c7c-c3b6b46cbd0b@codeaurora.org \
--to=mkshah@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=vnkgutta@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).