From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE97C49EA3 for ; Mon, 28 Jun 2021 12:16:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CD5F61C3D for ; Mon, 28 Jun 2021 12:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232941AbhF1MSx (ORCPT ); Mon, 28 Jun 2021 08:18:53 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:38682 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232855AbhF1MSx (ORCPT ); Mon, 28 Jun 2021 08:18:53 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1624882587; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=eOk428q47G9JECgI305p0YfOtLH88pZzKPZeMrWmwQs=; b=ECsOZkFq9WWEbrO3qg5tl4BW5k6Dd5OdAm/+zxFKkza984M3i663KpTdV2p/iE91ypbgXGG3 IovBk6Fu6NvQ0bYyHQpyKQjFvXOKsOc+GFHcehYZUPe4m9xbVK7toCb7V1sW68uluwaP8VS7 1pYaA2H6SPn21VID4krLOaphEpY= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 60d9bd9a0090905e1665790e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 28 Jun 2021 12:16:26 GMT Sender: rajeevny=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9E2DEC4323A; Mon, 28 Jun 2021 12:16:25 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rajeevny) by smtp.codeaurora.org (Postfix) with ESMTPSA id ABA76C433D3; Mon, 28 Jun 2021 12:16:24 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 28 Jun 2021 17:46:24 +0530 From: rajeevny@codeaurora.org To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, sam@ravnborg.org, robdclark@gmail.com, dianders@chromium.org, lyude@redhat.com, jani.nikula@intel.com, robh@kernel.org, a.hajda@samsung.com, daniel.thompson@linaro.org, hoegsberg@chromium.org, abhinavk@codeaurora.org, seanpaul@chromium.org, kalyan_t@codeaurora.org, mkrishn@codeaurora.org Subject: Re: [v8 4/6] drm/panel-simple: Update validation warnings for eDP panel description In-Reply-To: References: <1624726268-14869-1-git-send-email-rajeevny@codeaurora.org> <1624726268-14869-5-git-send-email-rajeevny@codeaurora.org> Message-ID: X-Sender: rajeevny@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Laurent, On 27-06-2021 23:48, Laurent Pinchart wrote: > Hi Rajeev, > > On Sat, Jun 26, 2021 at 10:21:06PM +0530, Rajeev Nandan wrote: >> Do not give a warning for the eDP panels if the "bus_format" is >> not specified, since most eDP panels can support more than one >> bus formats and this can be auto-detected. >> Also, update the check to include bpc=10 for the eDP panel. >> >> Signed-off-by: Rajeev Nandan >> --- >> >> Changes in v8: >> - New patch, to address the review comments of Sam Ravnborg [1] >> >> [1] >> https://lore.kernel.org/dri-devel/20210621184157.GB918146@ravnborg.org/ >> >> drivers/gpu/drm/panel/panel-simple.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c >> b/drivers/gpu/drm/panel/panel-simple.c >> index 86e5a45..f966b562 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -772,10 +772,8 @@ static int panel_simple_probe(struct device *dev, >> const struct panel_desc *desc, >> desc->bpc != 8); >> break; >> case DRM_MODE_CONNECTOR_eDP: >> - if (desc->bus_format == 0) >> - dev_warn(dev, "Specify missing bus_format\n"); >> - if (desc->bpc != 6 && desc->bpc != 8) >> - dev_warn(dev, "Expected bpc in {6,8} but got: %u\n", desc->bpc); >> + if (desc->bpc != 6 && desc->bpc != 8 && desc->bpc != 10) >> + dev_warn(dev, "Expected bpc in {6,8,10} but got: %u\n", >> desc->bpc); > > You'll still get a warning is bpc == 0, is that intentional ? This was not intentional, I missed considering bpc=0 case. As we are removing the warning for bus_format=0 then a similar thing can be done for the bpc=0 also. The bpc value should be a valid one if it is specified. Unlike the bus_format, bpc has few possible values that can be checked here along with 0. Please correct me if I misunderstood the concept. I will fix this. Thanks, Rajeev