From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A66C2B9F6 for ; Mon, 10 May 2021 13:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73C6C61359 for ; Mon, 10 May 2021 13:29:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232921AbhEJNa6 (ORCPT ); Mon, 10 May 2021 09:30:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348736AbhEJMq5 (ORCPT ); Mon, 10 May 2021 08:46:57 -0400 Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DC95C06175F for ; Mon, 10 May 2021 05:41:04 -0700 (PDT) Received: by mail-qt1-x82d.google.com with SMTP id y12so11733406qtx.11 for ; Mon, 10 May 2021 05:41:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sWBxeMl4QMRBC5+HydxigOqadY8c03VHN4Jo2XyXuPo=; b=lUJjWERR/ZcJbmtBbd5iJHakU3oreeyOxyCL4YrM6P7zuPQw2GJkQffGGmfGnvJRir +oF0c/rzhyz/lBDJsejg9ioEipSSUl6YM7KVlF22Niw9EMV4pl0+rknlKMWtfLG1QBaC 3uu6kPe2j1gowaAl8KngEZD+1x2gctxma/sH/MWCp1ACPZPVtp0PV84ISPrCwiy5yhfi Cd44Bhz7s1CZe0YfwOyq0ROOHSxmgsl6ybs1U2eo3pwKzSsGRlUK2mgNDmXQ6HldbWFN G0i50m6QYIKB9/dbw2CsgNdOtt+rh3MzCrpJ/u8WOJs6uwD0OEx6ftDWNImjebFY24Pr 8Vew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sWBxeMl4QMRBC5+HydxigOqadY8c03VHN4Jo2XyXuPo=; b=Y7IM1SE16AsoMRYO/QENU5uqp2CKAXL4MhAJ6qxuE/UMezsG4vHI10KtsWht6/FmC/ oqlJASPWCEhl3lKLklkBPC/0wrytwxxGtyko5g8827zGgoqCkb3ZCTNgaXCzi0tZlQBn xjwxeYOX/J6TdJxaT0NFf6N92z4nRerQq0f8IxEaqm4R8e7ufHdhDis128E1ioTFpOOl GVccVhg2+qHs+oDyB8xAdUvpZzUHOgkPA1/93E+5uPenGUwZVcehFCW1G48mrU1vtAqD my1mO17jG6vuMcaqXSRD/NLl92Y81a30/TNdESqJeV1UJFV4XqMmO9dCoNS/oeAMaiVd YhrA== X-Gm-Message-State: AOAM531Vs/8xRQp3tbvrD/mHrroAIpv5DXPIraGl5QfKVzkndaBDNJvZ AV6kNkB/oPPKKoaH6CdQWvHh5A== X-Google-Smtp-Source: ABdhPJxbq2hX5CW1bhvlOJNY25r+kplAkc2Kf7zakAydxBuGzUc7Mh8fQJ2R+nUpsqxXyWrj9bYZ9Q== X-Received: by 2002:ac8:4710:: with SMTP id f16mr18777928qtp.250.1620650463263; Mon, 10 May 2021 05:41:03 -0700 (PDT) Received: from [192.168.1.93] (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.gmail.com with ESMTPSA id o5sm11333822qkl.64.2021.05.10.05.41.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 05:41:02 -0700 (PDT) Subject: Re: [thermal-next PATCH v2 1/2] thermal: qcom: tsens: init debugfs only with successful probe To: Ansuel Smith Cc: Andy Gross , Bjorn Andersson , Amit Kucheria , Zhang Rui , Daniel Lezcano , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210429010518.13319-1-ansuelsmth@gmail.com> <20210429010518.13319-2-ansuelsmth@gmail.com> From: Thara Gopinath Message-ID: Date: Mon, 10 May 2021 08:41:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210429010518.13319-2-ansuelsmth@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 4/28/21 9:05 PM, Ansuel Smith wrote: > calibrate and tsens_register can fail or PROBE_DEFER. This will cause a > double or a wrong init of the debugfs information. Init debugfs only > with successful probe fixing warning about directory already present. > > Signed-off-by: Ansuel Smith Reviewed-by: Thara Gopinath -- Warm Regards Thara > --- > drivers/thermal/qcom/tsens.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index d8ce3a687b80..b37d5fd71f3a 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -845,8 +845,6 @@ int __init init_common(struct tsens_priv *priv) > if (tsens_version(priv) >= VER_0_1) > tsens_enable_irq(priv); > > - tsens_debug_init(op); > - > err_put_device: > put_device(&op->dev); > return ret; > @@ -1057,7 +1055,12 @@ static int tsens_probe(struct platform_device *pdev) > } > } > > - return tsens_register(priv); > + ret = tsens_register(priv); > + > + if (!ret) > + tsens_debug_init(pdev); > + > + return ret; > } > > static int tsens_remove(struct platform_device *pdev) >