From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29ABCC48BCF for ; Sat, 12 Jun 2021 21:21:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06F3860FE6 for ; Sat, 12 Jun 2021 21:21:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229777AbhFLVXB (ORCPT ); Sat, 12 Jun 2021 17:23:01 -0400 Received: from vps5.brixit.nl ([192.81.221.234]:46338 "EHLO vps5.brixit.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbhFLVXA (ORCPT ); Sat, 12 Jun 2021 17:23:00 -0400 Received: from [192.168.20.2] (unknown [77.239.252.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by vps5.brixit.nl (Postfix) with ESMTPSA id AF46F607EB; Sat, 12 Jun 2021 21:20:56 +0000 (UTC) Subject: Re: [PATCH v2 1/2] arch: arm64: dts: qcom: Add support for SM6125 To: Martin Botka Cc: ~postmarketos/upstreaming@lists.sr.ht, konrad.dybcio@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, Iskren Chernev References: <20210612094652.90354-1-martin.botka@somainline.org> From: Alexey Minnekhanov Message-ID: Date: Sun, 13 Jun 2021 00:20:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210612094652.90354-1-martin.botka@somainline.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org > + sdhc_1: sdhci@4744000 { > + compatible = "qcom,sm6125-sdhci", "qcom,sdhci-msm-v5"; > + reg = <0x04744000 0x1000>, <0x04744000 0x1000>; > + reg-names = "hc_mem", "core_mem"; ichernev: reg-names should be "hc" and "cqhci" and the 2 values you've supplied should be different maybe? > + > + sdhc_2: sdhci@4784000 { > + compatible = "qcom,sm6125-sdhci", "qcom,sdhci-msm-v5"; > + reg = <0x04784000 0x1000>; > + reg-names = "hc_mem"; Wrong reg names again? -- Regards Alexey Minnekhanov