From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Shaik Sajida Bhanu <sbhanu@codeaurora.org>,
adrian.hunter@intel.com, ulf.hansson@linaro.org,
robh+dt@kernel.org
Cc: asutoshd@codeaurora.org, stummala@codeaurora.org,
vbadigan@codeaurora.org, rampraka@codeaurora.org,
sayalil@codeaurora.org, sartgarg@codeaurora.org,
rnayak@codeaurora.org, saiprakash.ranjan@codeaurora.org,
sibis@codeaurora.org, okukatla@codeaurora.org, djakov@kernel.org,
cang@codeaurora.org, pragalla@codeaurora.org,
nitirawa@codeaurora.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org
Subject: Re: [PATCH V1] arm64: dts: qcom: sc7180: Added xo clock for eMMC and Sd card
Date: Thu, 10 Jun 2021 09:54:24 +0200 [thread overview]
Message-ID: <dd685abc-c332-cd0c-af6a-d2f1116cef05@somainline.org> (raw)
In-Reply-To: <1623309107-27833-1-git-send-email-sbhanu@codeaurora.org>
Hi,
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -701,8 +701,9 @@
> interrupt-names = "hc_irq", "pwr_irq";
>
> clocks = <&gcc GCC_SDCC1_APPS_CLK>,
> - <&gcc GCC_SDCC1_AHB_CLK>;
> - clock-names = "core", "iface";
> + <&gcc GCC_SDCC1_AHB_CLK>,
> + <&rpmhcc RPMH_CXO_CLK>;
Don't these clocks fit in 100 chars?
> + clock-names = "core", "iface","xo";
A space is missing before "xo".
> interconnects = <&aggre1_noc MASTER_EMMC 0 &mc_virt SLAVE_EBI1 0>,
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_EMMC_CFG 0>;
> interconnect-names = "sdhc-ddr","cpu-sdhc";
> @@ -2666,8 +2667,9 @@
> interrupt-names = "hc_irq", "pwr_irq";
>
> clocks = <&gcc GCC_SDCC2_APPS_CLK>,
> - <&gcc GCC_SDCC2_AHB_CLK>;
> - clock-names = "core", "iface";
> + <&gcc GCC_SDCC2_AHB_CLK>,
> + <&rpmhcc RPMH_CXO_CLK>;
Ditto
Konrad
next prev parent reply other threads:[~2021-06-10 7:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 7:11 [PATCH V1] arm64: dts: qcom: sc7180: Added xo clock for eMMC and Sd card Shaik Sajida Bhanu
2021-06-10 7:54 ` Konrad Dybcio [this message]
2021-06-11 3:29 ` Bjorn Andersson
2021-06-14 11:44 ` sbhanu
2021-06-14 11:49 ` Konrad Dybcio
2021-06-11 4:30 ` Bjorn Andersson
2021-06-14 11:55 ` sbhanu
2021-06-14 16:30 ` Bjorn Andersson
2021-06-15 10:00 ` sbhanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd685abc-c332-cd0c-af6a-d2f1116cef05@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=asutoshd@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nitirawa@codeaurora.org \
--cc=okukatla@codeaurora.org \
--cc=pragalla@codeaurora.org \
--cc=rampraka@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sartgarg@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=sbhanu@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).