From: Sandeep Maheswaram <sanm@codeaurora.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Manu Gautam <mgautam@codeaurora.org>
Subject: Re: [PATCH v1] usb: dwc3: core: Add shutdown callback for dwc3
Date: Tue, 30 Mar 2021 14:12:04 +0530 [thread overview]
Message-ID: <e1afc071-57a6-5d7f-b467-92b618419b76@codeaurora.org> (raw)
In-Reply-To: <YF3jfshT3OSolcws@kroah.com>
On 3/26/2021 7:07 PM, Greg Kroah-Hartman wrote:
> On Wed, Mar 24, 2021 at 12:57:32AM +0530, Sandeep Maheswaram wrote:
>> This patch adds a shutdown callback to USB DWC core driver to ensure that
>> it is properly shutdown in reboot/shutdown path. This is required
>> where SMMU address translation is enabled like on SC7180
>> SoC and few others. If the hardware is still accessing memory after
>> SMMU translation is disabled as part of SMMU shutdown callback in
>> system reboot or shutdown path, then IOVAs(I/O virtual address)
>> which it was using will go on the bus as the physical addresses which
>> might result in unknown crashes (NoC/interconnect errors).
>>
>> Previously this was added in dwc3 qcom glue driver.
>> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=382449
>> But observed kernel panic as glue driver shutdown getting called after
>> iommu shutdown. As we are adding iommu nodes in dwc core node
>> in device tree adding shutdown callback in core driver seems correct.
> So shouldn't you also remove this from the qcom glue driver at the same
> time? Please submit both as a patch series.
>
> thanks,
>
> greg k-h
Hi Greg,
The qcom glue driver patch is not merged yet. I have just mentioned for it for reference.
Regards
Sandeep
next prev parent reply other threads:[~2021-03-30 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 19:27 [PATCH v1] usb: dwc3: core: Add shutdown callback for dwc3 Sandeep Maheswaram
2021-03-24 3:31 ` Stephen Boyd
2021-03-25 5:05 ` Sandeep Maheswaram
2021-03-24 9:39 ` Sergei Shtylyov
2021-03-26 13:37 ` Greg Kroah-Hartman
2021-03-30 8:42 ` Sandeep Maheswaram [this message]
2021-03-30 9:07 ` Greg Kroah-Hartman
2021-03-30 9:55 ` Sai Prakash Ranjan
2021-03-30 11:16 ` Greg Kroah-Hartman
2021-03-30 12:48 ` Sai Prakash Ranjan
2021-03-30 13:32 ` Greg Kroah-Hartman
2021-03-31 7:07 ` Sai Prakash Ranjan
2021-04-08 4:52 ` Sandeep Maheswaram
2021-04-08 7:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1afc071-57a6-5d7f-b467-92b618419b76@codeaurora.org \
--to=sanm@codeaurora.org \
--cc=balbi@kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=mka@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).