From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED031C2D0E5 for ; Wed, 25 Mar 2020 19:05:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0F5820740 for ; Wed, 25 Mar 2020 19:05:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="FsN3DV2w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727708AbgCYTFB (ORCPT ); Wed, 25 Mar 2020 15:05:01 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:13486 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727027AbgCYTFB (ORCPT ); Wed, 25 Mar 2020 15:05:01 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1585163100; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: References: Cc: To: From: Subject: Sender; bh=g8oMtUxDca/zQV2e0hTrO0l41ntZ0xz+0vB0sG4blbQ=; b=FsN3DV2w9lxo5YuW7KgVFS+PDipAQ1F0TTqorsq61rWbi2FyBr647OAsb+Z+jdmS0xGs/lhq otIe/3miDJ4+1p8bjclQaSSlxMgX9k8y0ObpZYfOUMoC6EgM67I0cu1s5gakg/rJEozg+tvX Oq/KOFrJdXoC27VOnaWHmp23F+g= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e7bab45.7fd7e5c34570-smtp-out-n04; Wed, 25 Mar 2020 19:04:37 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1FF94C43637; Wed, 25 Mar 2020 19:04:36 +0000 (UTC) Received: from [10.226.58.28] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jhugo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 67EF5C433D2; Wed, 25 Mar 2020 19:04:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 67EF5C433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=jhugo@codeaurora.org Subject: Re: [PATCH v3 2/7] bus: mhi: core: Add support for reading MHI info from device From: Jeffrey Hugo To: Manivannan Sadhasivam , gregkh@linuxfoundation.org, davem@davemloft.net Cc: smohanad@codeaurora.org, kvalo@codeaurora.org, bjorn.andersson@linaro.org, hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200324061050.14845-1-manivannan.sadhasivam@linaro.org> <20200324061050.14845-3-manivannan.sadhasivam@linaro.org> Message-ID: Date: Wed, 25 Mar 2020 13:04:32 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 3/24/2020 8:38 AM, Jeffrey Hugo wrote: > On 3/24/2020 12:10 AM, Manivannan Sadhasivam wrote: >> The MHI register base has several registers used for getting the MHI >> specific information such as version, family, major, and minor numbers >> from the device. This information can be used by the controller drivers >> for usecases such as applying quirks for a specific revision etc... >> >> While at it, let's also rearrange the local variables >> in mhi_register_controller(). >> >> Suggested-by: Hemant Kumar >> Signed-off-by: Manivannan Sadhasivam >> --- >>   drivers/bus/mhi/core/init.c     | 19 +++++++++++++++++-- >>   drivers/bus/mhi/core/internal.h | 10 ++++++++++ >>   include/linux/mhi.h             | 17 +++++++++++++++++ >>   3 files changed, 44 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c >> index eb7f556a8531..d136f6c6ca78 100644 >> --- a/drivers/bus/mhi/core/init.c >> +++ b/drivers/bus/mhi/core/init.c >> @@ -802,12 +802,12 @@ static int parse_config(struct mhi_controller >> *mhi_cntrl, >>   int mhi_register_controller(struct mhi_controller *mhi_cntrl, >>                   struct mhi_controller_config *config) >>   { >> -    int ret; >> -    int i; >>       struct mhi_event *mhi_event; >>       struct mhi_chan *mhi_chan; >>       struct mhi_cmd *mhi_cmd; >>       struct mhi_device *mhi_dev; >> +    u32 soc_info; >> +    int ret, i; >>       if (!mhi_cntrl) >>           return -EINVAL; >> @@ -874,6 +874,21 @@ int mhi_register_controller(struct mhi_controller >> *mhi_cntrl, >>           mhi_cntrl->unmap_single = mhi_unmap_single_no_bb; >>       } >> +    /* Read the MHI device info */ >> +    ret = mhi_read_reg(mhi_cntrl, mhi_cntrl->regs, >> +               SOC_HW_VERSION_OFFS, &soc_info); >> +    if (ret) >> +        goto error_alloc_dev; >> + >> +    mhi_cntrl->family_number = (soc_info & >> SOC_HW_VERSION_FAM_NUM_BMSK) >> >> +                    SOC_HW_VERSION_FAM_NUM_SHFT; >> +    mhi_cntrl->device_number = (soc_info & >> SOC_HW_VERSION_DEV_NUM_BMSK) >> >> +                    SOC_HW_VERSION_DEV_NUM_SHFT; >> +    mhi_cntrl->major_version = (soc_info & >> SOC_HW_VERSION_MAJOR_VER_BMSK) >> >> +                    SOC_HW_VERSION_MAJOR_VER_SHFT; >> +    mhi_cntrl->minor_version = (soc_info & >> SOC_HW_VERSION_MINOR_VER_BMSK) >> >> +                    SOC_HW_VERSION_MINOR_VER_SHFT; >> + >>       /* Register controller with MHI bus */ >>       mhi_dev = mhi_alloc_device(mhi_cntrl); >>       if (IS_ERR(mhi_dev)) { >> diff --git a/drivers/bus/mhi/core/internal.h >> b/drivers/bus/mhi/core/internal.h >> index 18066302e6e2..5deadfaa053a 100644 >> --- a/drivers/bus/mhi/core/internal.h >> +++ b/drivers/bus/mhi/core/internal.h >> @@ -196,6 +196,16 @@ extern struct bus_type mhi_bus_type; >>   #define BHIE_RXVECSTATUS_STATUS_XFER_COMPL (0x02) >>   #define BHIE_RXVECSTATUS_STATUS_ERROR (0x03) >> +#define SOC_HW_VERSION_OFFS (0x224) >> +#define SOC_HW_VERSION_FAM_NUM_BMSK (0xF0000000) >> +#define SOC_HW_VERSION_FAM_NUM_SHFT (28) >> +#define SOC_HW_VERSION_DEV_NUM_BMSK (0x0FFF0000) >> +#define SOC_HW_VERSION_DEV_NUM_SHFT (16) >> +#define SOC_HW_VERSION_MAJOR_VER_BMSK (0x0000FF00) >> +#define SOC_HW_VERSION_MAJOR_VER_SHFT (8) >> +#define SOC_HW_VERSION_MINOR_VER_BMSK (0x000000FF) >> +#define SOC_HW_VERSION_MINOR_VER_SHFT (0) > > I'm tempted to give reviewed-by, however it occurs to me that I don't > see this in the MHI spec.  I'm looking at Rev E, which as far as I am > aware is the latest. > > Hemant, is this in the spec, and if so, what Rev? > > I'm concerned that if its not in the spec, we may have an issue with > some device not implementing this as expected. > Reviewed-by: Jeffrey Hugo I talked with Hemant offline, and this is queued up for the next spec rev. I'm satisfied with that. -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.