From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 463B6C4332F for ; Wed, 24 Nov 2021 17:37:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237633AbhKXRkO (ORCPT ); Wed, 24 Nov 2021 12:40:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236657AbhKXRkJ (ORCPT ); Wed, 24 Nov 2021 12:40:09 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF872C061574; Wed, 24 Nov 2021 09:36:58 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id b1so9152567lfs.13; Wed, 24 Nov 2021 09:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZIcn+RRc9Rps+7b0T+IyJm79uMUpyF3YvcCN2OC7l9Y=; b=FLBSX0+olXTOAlp7C+knSf/7drnIn7H/UX7TDK9AoSp4PkuSj60LVuYkKMnjcC9YY3 ikWuFdLfD1kbuzClK7j2r8uE52m0ciCo0F41wb7XU00orL14Q13pQk+6d+pyM7vdO2QK LYUIqSIXIslxr1QmFi4Bl0ADQeiZ5m+/BOBB6vDflgHIEMsk0Q88DdJUo3wVEYI8Pr5Z sXvAtuyUfl3+J0677+KUwo73hWKLP5dVAe3qav01Qm9WaXlqZU7Qi87kYoIB9qdRIWxe kKTxqqpAJ0WWNVIjLM+Cf5/IG4PS+Rx6faWvmZ4/OGrH5fC0tZn54q+Z8fHjDwt1vOnd kYzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZIcn+RRc9Rps+7b0T+IyJm79uMUpyF3YvcCN2OC7l9Y=; b=uQIzkJn0wSAkVuAw8V7ZbZCiZb2EQ0p8Ko6qYDfSsV+plbKIXBP7i7xvDtXNHj0jTj qRp2UUtb3OsqGRjm4k3CW4HyABMP8hmbGmNUz0R9y9SyGxI0SLmFmHEjOBdHCWTP6cRV aGKYy/I8tkJ77dGvCJw7kBd/PnfqI964WqLxwSuOUiR+ciCmsFqEu7U5b59BcozcGR0S YQSs28vZnHBHdl+LVCEFEMmkcOvIzW3beeV7oPx6degewSh9e2n/o5qRuF53vTnQtfmv CcJfuigbRt7OaTn0Yoy3s8O8pP7DqSBswckosVoSU4uwLFHrpA1AIw555A31uX6vS+iG sQqA== X-Gm-Message-State: AOAM5304oSOUx7N0KWKhx9uJm4Fa87p+VEk1g/gocNbCq4ZDyaJiz1a3 nCjtgt+2l/Jh+JySVcHNMHuDqrYkl74= X-Google-Smtp-Source: ABdhPJxrgNz+71paDdUUv/N7my06bflGW6cF8iV2RywOAz26KaDrmDsPh/ZBuabbAUbFBAGdMU59uQ== X-Received: by 2002:a05:6512:2341:: with SMTP id p1mr16884188lfu.204.1637775417014; Wed, 24 Nov 2021 09:36:57 -0800 (PST) Received: from [192.168.2.145] (94-29-48-99.dynamic.spd-mgts.ru. [94.29.48.99]) by smtp.googlemail.com with ESMTPSA id e14sm42342ljn.78.2021.11.24.09.36.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 09:36:56 -0800 (PST) Subject: Re: [PATCH v2 01/11] ASoC: tegra20-spdif: stop setting slave_id To: Arnd Bergmann Cc: Vinod Koul , Arnd Bergmann , Andy Gross , Andy Shevchenko , Baolin Wang , Bjorn Andersson , Chunyan Zhang , Greg Kroah-Hartman , Hyun Kwon , Jaroslav Kysela , Jon Hunter , Lars-Peter Clausen , Laurent Pinchart , Laxman Dewangan , Manivannan Sadhasivam , Mark Brown , Michal Simek , Nicolas Saenz Julienne , Orson Zhai , Robert Jarzmik , Scott Branden , Takashi Iwai , Thierry Reding , ALSA Development Mailing List , bcm-kernel-feedback-list , dmaengine@vger.kernel.org, dri-devel , Linux ARM , linux-arm-msm , Linux Kernel Mailing List , linux-mmc , linux-mtd , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "open list:SERIAL DRIVERS" , linux-spi , linux-staging@lists.linux.dev, "open list:TEGRA ARCHITECTURE SUPPORT" References: <20211122222203.4103644-1-arnd@kernel.org> <20211122222203.4103644-2-arnd@kernel.org> <1dbe0c9f-e209-49e1-f05c-765d9f9b91eb@gmail.com> From: Dmitry Osipenko Message-ID: Date: Wed, 24 Nov 2021 20:36:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org 24.11.2021 19:47, Arnd Bergmann пишет: > On Wed, Nov 24, 2021 at 5:32 PM Dmitry Osipenko wrote: >> 23.11.2021 01:21, Arnd Bergmann пишет: >> >> The commit message is correct, however you could remove even more code >> here. But there is no need to make a v3 just because this patch because >> I already prepared patchset that revives this S/PDIF driver and enables >> HDMI audio on Tegra20. I'll take care of cleaning up the whole code of >> this driver. > > Ok, perfect, thanks for taking a closer look as well. > >> >> - dmareq = platform_get_resource(pdev, IORESOURCE_DMA, 0); >> - if (!dmareq) { >> - dev_err(&pdev->dev, "No DMA resource\n"); >> - return -ENODEV; >> - } >> - > > Right, I think I considered doing this at some point as well, not sure > why I left it in for the version I posted. Passing the IORESOURCE_DMA > values is clearly wrong by itself and needs to be removed, though > it's not obvious what the correct way of requesting the DMA channel > is for this driver either, without a DT binding or users. Yes, it's indeed not obvious.