From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0ADFC433E0 for ; Thu, 23 Jul 2020 18:06:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEEA3208E4 for ; Thu, 23 Jul 2020 18:06:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i9jDZylB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726573AbgGWSGy (ORCPT ); Thu, 23 Jul 2020 14:06:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbgGWSGx (ORCPT ); Thu, 23 Jul 2020 14:06:53 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60B4FC0619DC for ; Thu, 23 Jul 2020 11:06:53 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id p14so5406420wmg.1 for ; Thu, 23 Jul 2020 11:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mD0gVXE2wPUJlx9RjmBmtExy8T7ZH1sd1QlDXUC5IPE=; b=i9jDZylBCkYI4PX0pdm+Sx5r9rpNQztebTzzJ2kVJ1CwiWFsRTWxuiqKLU82ckP/5O wm1GXTuLRUo5xznse+hNcjWLSiqZEEk/EsqBdPgKDXZV7G488oTrZts+KjJ4wp0ynNoK xnthrqYDhVtPJnC8VwxeoknxgRu/6ZCDxEteqO17nMpNqxlaB8fTpNaoYk57XxkPkoty w/bqAXHYunqu4VIa3KP9J0BnNL5aVqEZvCNIX5BhAsftylOcY3UdBfzlYgoDDWcfQHkb R+BEjxirEqdVRBrNJTyNc0sPJX42zuKYkvXtcxh8oQH7/JPU/8pc1R3QD1cmCFc64i1x 103w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mD0gVXE2wPUJlx9RjmBmtExy8T7ZH1sd1QlDXUC5IPE=; b=ihjVKS7GpjFWQnOLC6llRSM1wphBdSmD4UOoI2QvGjORVzBCbmgNpwz0vmmArnERqL CixvQ3m7zEyfm+83ARHxauvsI/d8+e5fjGGzmqCi3qIBcARIllW++bGhpf28AbUHcvs3 FNQIjJchNm1mVpWjr4X0L/BItD1Jd9UYEUgCuCEM9jccwabaId/t8hKBtLpEeXltmWhZ OmOiBxBf3cjd9XzSI0jZHYQ2DJZSaCybp0ziiHV/YclV6ESeg5k1WLYyiwULaMSrqGEy 3JmrIwtwgloB5OWeUKXv2AHZu2mx2IN1gd1bZW6UPaF7wyseKeinNHq7+f1TCtGKMTzz WJsA== X-Gm-Message-State: AOAM531e0PwhWPqs/dkyTuhCZks46hICEl2FcOE01CgIYLQJuRazno9u g+QhhpFJzGesZrsBXlu9HbPQVw== X-Google-Smtp-Source: ABdhPJwF9PGbliwSW3zKmJVzF1dom2pw4cIfvHUzAVudkZu5XXD9qQ12APwQBRSpaMyPmQ6WomZO/g== X-Received: by 2002:a05:600c:204d:: with SMTP id p13mr5107823wmg.88.1595527612034; Thu, 23 Jul 2020 11:06:52 -0700 (PDT) Received: from [192.168.1.12] ([195.24.90.54]) by smtp.googlemail.com with ESMTPSA id g126sm4377697wme.16.2020.07.23.11.06.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2020 11:06:51 -0700 (PDT) Subject: Re: [PATCH v4 4/5] arm64: dts: sdm845: Add OPP tables and power-domains for venus To: Rajendra Nayak , stanimir.varbanov@linaro.org, robh+dt@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mka@chromium.org References: <1595503612-2901-1-git-send-email-rnayak@codeaurora.org> <1595503612-2901-5-git-send-email-rnayak@codeaurora.org> From: Stanimir Varbanov Message-ID: Date: Thu, 23 Jul 2020 21:06:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1595503612-2901-5-git-send-email-rnayak@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Rajendra, After applying 2,3 and 4/5 patches on linaro-integration v5.8-rc2 I see below messages on db845: qcom-venus aa00000.video-codec: dev_pm_opp_set_rate: failed to find current OPP for freq 533000097 (-34) ^^^ This one is new. qcom_rpmh TCS Busy, retrying RPMH message send: addr=0x30000 ^^^ and this message is annoying, can we make it pr_debug in rpmh? On 7/23/20 2:26 PM, Rajendra Nayak wrote: > Add the OPP tables in order to be able to vote on the performance state of > a power-domain. > > Signed-off-by: Rajendra Nayak > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 40 ++++++++++++++++++++++++++++++++++-- > 1 file changed, 38 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index e506793..5ca2265 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -3631,8 +3631,10 @@ > interrupts = ; > power-domains = <&videocc VENUS_GDSC>, > <&videocc VCODEC0_GDSC>, > - <&videocc VCODEC1_GDSC>; > - power-domain-names = "venus", "vcodec0", "vcodec1"; > + <&videocc VCODEC1_GDSC>, > + <&rpmhpd SDM845_CX>; > + power-domain-names = "venus", "vcodec0", "vcodec1", "cx"; > + operating-points-v2 = <&venus_opp_table>; > clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>, > <&videocc VIDEO_CC_VENUS_AHB_CLK>, > <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>, > @@ -3654,6 +3656,40 @@ > video-core1 { > compatible = "venus-encoder"; > }; > + > + venus_opp_table: venus-opp-table { > + compatible = "operating-points-v2"; > + > + opp-100000000 { > + opp-hz = /bits/ 64 <100000000>; > + required-opps = <&rpmhpd_opp_min_svs>; > + }; > + > + opp-200000000 { > + opp-hz = /bits/ 64 <200000000>; > + required-opps = <&rpmhpd_opp_low_svs>; > + }; > + > + opp-320000000 { > + opp-hz = /bits/ 64 <320000000>; > + required-opps = <&rpmhpd_opp_svs>; > + }; > + > + opp-380000000 { > + opp-hz = /bits/ 64 <380000000>; > + required-opps = <&rpmhpd_opp_svs_l1>; > + }; > + > + opp-444000000 { > + opp-hz = /bits/ 64 <444000000>; > + required-opps = <&rpmhpd_opp_nom>; > + }; > + > + opp-533000000 { > + opp-hz = /bits/ 64 <533000000>; > + required-opps = <&rpmhpd_opp_turbo>; > + }; > + }; > }; > > videocc: clock-controller@ab00000 { > -- regards, Stan