From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21AC1C433DF for ; Thu, 21 May 2020 17:03:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2E85207F7 for ; Thu, 21 May 2020 17:03:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="HEO5Fiqj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730089AbgEURDS (ORCPT ); Thu, 21 May 2020 13:03:18 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:43169 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730079AbgEURDR (ORCPT ); Thu, 21 May 2020 13:03:17 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1590080597; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=jszy9teC+sVSx6DPFN+KKjWdwRQJ/ERwIDCVkAF6fYw=; b=HEO5Fiqj/4IeortTSR1Ezpp9ojnPyQXmCF1upl/pd0d6xny4Jb+r9wfIQpSISkrst5Ritvlm YT18NFVBPOuc/gTdjIeN1JD5EjJKjMFyukfJhAlbuDLs6T1jvLkWEQJRoA2XEfiF5EllcUcj 55WW6Wc2UuWec6N/7qPcvIxwoNg= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 5ec6b454569a62550d499836 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 21 May 2020 17:03:16 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 74BDDC433AD; Thu, 21 May 2020 17:03:16 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id EE56BC433AD; Thu, 21 May 2020 17:03:13 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 21 May 2020 22:33:13 +0530 From: Sai Prakash Ranjan To: Mike Leach Cc: Mathieu Poirier , Suzuki K Poulose , Stephen Boyd , Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, Coresight ML Subject: Re: [PATCHv2 3/4] coresight: replicator: Reset replicator if context is lost In-Reply-To: References: Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Mike, On 2020-05-21 21:38, Mike Leach wrote: > Hi Sai, > > On Tue, 19 May 2020 at 14:36, Sai Prakash Ranjan > wrote: >> >> On some QCOM SoCs, replicators in Always-On domain loses its >> context as soon as the clock is disabled. Currently as a part >> of pm_runtime workqueue, clock is disabled after the replicator >> is initialized by amba_pm_runtime_suspend assuming that context >> is not lost which is not true for replicators with such >> limitations. So add a new property "qcom,replicator-loses-context" >> to identify such replicators and reset them. >> >> Suggested-by: Mike Leach >> Signed-off-by: Sai Prakash Ranjan >> --- >> >> Added Mike's suggested by for parts other than the DT property. >> Perhaps I should add Co-developed-by Mike since the full skeletal >> was given by Mike. I can add that if required on the next version. >> [...] > > Suggested-by is just fine - I didn't actually try out my suggested > code after all! > > Reviewed-by Mike Leach Sure, thanks for the review. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation