Linux-ARM-MSM Archive on
 help / color / Atom feed
From: Taniya Das <>
To: Stephen Boyd <>,
	Doug Anderson <>
Cc: Michael Turquette <>,
	Stephen Boyd <>,
	LKML <>,
	linux-clk <>,
	linux-arm-msm <>
Subject: Re: [PATCH] clk: qcom: gcc-sdm845: Use floor ops for sdcc clks
Date: Thu, 5 Sep 2019 14:52:54 +0530
Message-ID: <> (raw)
In-Reply-To: <>

On 9/4/2019 4:17 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2019-09-03 08:52:12)
>> Hi,
>> On 8/31/2019 3:04 AM, Doug Anderson wrote:
>>> Hi,
>>> On Fri, Aug 30, 2019 at 12:51 PM Stephen Boyd <> wrote:
>>>> Some MMC cards fail to enumerate properly when inserted into an MMC slot
>>>> on sdm845 devices. This is because the clk ops for qcom clks round the
>>>> frequency up to the nearest rate instead of down to the nearest rate.
>>>> For example, the MMC driver requests a frequency of 52MHz from
>>>> clk_set_rate() but the qcom implementation for these clks rounds 52MHz
>>>> up to the next supported frequency of 100MHz. The MMC driver could be
>>>> modified to request clk rate ranges but for now we can fix this in the
>>>> clk driver by changing the rounding policy for this clk to be round down
>>>> instead of round up.
>>> Since all the MMC rates are expressed as "maximum" clock rates doing
>>> it like you are doing it now seems sane.
>> Looks like we need to update/track it for all SDCC clocks for all targets.
> Yeah. It would be great if you can send the patches. Otherwise I'll
> throw it on my todo list named 'forever'.

Sure Stephen,  would send out the patches fixing them.

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.


  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30 19:51 Stephen Boyd
2019-08-30 21:34 ` Doug Anderson
2019-09-03 15:52   ` Taniya Das
2019-09-03 22:47     ` Stephen Boyd
2019-09-05  9:22       ` Taniya Das [this message]
2019-09-09 10:25 ` Stephen Boyd

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-MSM Archive on

Archives are clonable:
	git clone --mirror linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ \
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox