From: Taniya Das <tdas@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] clk: qcom: gcc-sdm845: Use floor ops for sdcc clks
Date: Thu, 5 Sep 2019 14:52:54 +0530 [thread overview]
Message-ID: <ea8bbff0-5461-7551-0e55-3810229ed53a@codeaurora.org> (raw)
In-Reply-To: <5d6eed69.1c69fb81.b7ca5.7345@mx.google.com>
On 9/4/2019 4:17 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2019-09-03 08:52:12)
>> Hi,
>>
>> On 8/31/2019 3:04 AM, Doug Anderson wrote:
>>> Hi,
>>>
>>> On Fri, Aug 30, 2019 at 12:51 PM Stephen Boyd <swboyd@chromium.org> wrote:
>>>>
>>>> Some MMC cards fail to enumerate properly when inserted into an MMC slot
>>>> on sdm845 devices. This is because the clk ops for qcom clks round the
>>>> frequency up to the nearest rate instead of down to the nearest rate.
>>>> For example, the MMC driver requests a frequency of 52MHz from
>>>> clk_set_rate() but the qcom implementation for these clks rounds 52MHz
>>>> up to the next supported frequency of 100MHz. The MMC driver could be
>>>> modified to request clk rate ranges but for now we can fix this in the
>>>> clk driver by changing the rounding policy for this clk to be round down
>>>> instead of round up.
>>>
>>> Since all the MMC rates are expressed as "maximum" clock rates doing
>>> it like you are doing it now seems sane.
>>>
>>>
>>
>> Looks like we need to update/track it for all SDCC clocks for all targets.
>>
>
> Yeah. It would be great if you can send the patches. Otherwise I'll
> throw it on my todo list named 'forever'.
>
Sure Stephen, would send out the patches fixing them.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
next prev parent reply other threads:[~2019-09-05 9:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 19:51 [PATCH] clk: qcom: gcc-sdm845: Use floor ops for sdcc clks Stephen Boyd
2019-08-30 21:34 ` Doug Anderson
2019-09-03 15:52 ` Taniya Das
2019-09-03 22:47 ` Stephen Boyd
2019-09-05 9:22 ` Taniya Das [this message]
2019-09-09 10:25 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea8bbff0-5461-7551-0e55-3810229ed53a@codeaurora.org \
--to=tdas@codeaurora.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).