linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: mdalam@codeaurora.org
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: vkoul@kernel.org, corbet@lwn.net, agross@kernel.org,
	bjorn.andersson@linaro.org, dan.j.williams@intel.com,
	dmaengine@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	sricharan@codeaurora.org, mdalam=codeaurora.org@codeaurora.org
Subject: Re: [PATCH] dmaengine: qcom: bam_dma: Add LOCK and UNLOCK flag bit support
Date: Tue, 12 Jan 2021 15:00:02 +0530	[thread overview]
Message-ID: <ec3f90470eca80256d3c335c7fb23e4e@codeaurora.org> (raw)
In-Reply-To: <11f538a697de934551bcec5036d7fb17@codeaurora.org>

On 2020-12-22 17:48, mdalam@codeaurora.org wrote:
> On 2020-12-21 23:39, Thara Gopinath wrote:
>> On 12/21/20 2:35 AM, mdalam@codeaurora.org wrote:
>>> On 2020-12-19 09:05, Thara Gopinath wrote:
>>>> On 12/17/20 9:37 AM, Md Sadre Alam wrote:
>>>>> This change will add support for LOCK & UNLOCK flag bit support
>>>>> on CMD descriptor.
>>>>> 
>>>>> If DMA_PREP_LOCK flag passed in prep_slave_sg then requester of 
>>>>> this
>>>>> transaction wanted to lock the DMA controller for this transaction 
>>>>> so
>>>>> BAM driver should set LOCK bit for the HW descriptor.
>>>>> 
>>>>> If DMA_PREP_UNLOCK flag passed in prep_slave_sg then requester of 
>>>>> this
>>>>> transaction wanted to unlock the DMA controller.so BAM driver 
>>>>> should set
>>>>> UNLOCK bit for the HW descriptor.
>>>> Hi,
>>>> 
>>>> This is a generic question. What is the point of LOCK/UNLOCK with
>>>> allocating LOCK groups to the individual dma channels? By default
>>>> doesn't all channels fall in the same group. This would mean that
>>>> a lock does not prevent the dma controller from not executing a
>>>> transaction on the other channels.
>>>> 
>>> 
>>> The Pipe Locking/Unlocking will be only on command-descriptor.
>>> Upon encountering a command descriptor with LOCK bit set, the BAM
>>> will lock all other pipes not related to the current pipe group, and 
>>> keep
>>> handling the current pipe only until it sees the UNLOCK set then it 
>>> will
>>> release all locked pipes.
>> 
>> So unless you assign pipe groups, this will not work as intended
>> right? So this patch is only half of the solution. There should also
>> be a patch allowing pipe groups to be assigned. Without that extra bit
>> this patch does nothing , right ?
> 
> Yes you are right.
> We are having some register which will configure the pipe lock group.
> But these registers are not exposed to non-secure world. These 
> registers
> only accessible through secure world. Currently in IPQ5018 SoC we are
> configuring
> these register in secure world to configure pipe lock group.

ping! Is there any update on this ? Do you need any further info ?

  reply	other threads:[~2021-01-12  9:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 14:37 [PATCH] dmaengine: qcom: bam_dma: Add LOCK and UNLOCK flag bit support Md Sadre Alam
2020-12-19  3:35 ` Thara Gopinath
2020-12-21  7:35   ` mdalam
2020-12-21 18:09     ` Thara Gopinath
2020-12-22 12:18       ` mdalam
2021-01-12  9:30         ` mdalam [this message]
2020-12-21  9:23 ` Vinod Koul
2020-12-21 17:33   ` mdalam
2021-01-12  9:31     ` mdalam
2021-01-12 10:10       ` Vinod Koul
2021-01-13 19:50         ` mdalam
2021-01-15  5:58           ` Vinod Koul
2021-01-18  3:51             ` mdalam
2021-01-19 16:45               ` Vinod Koul
2021-01-27 18:26                 ` mdalam
2021-02-01  6:05                   ` Vinod Koul
2021-02-01  6:22                     ` mdalam
2021-02-01  6:43                       ` Vinod Koul
2021-02-01 15:50                         ` mdalam
2021-02-09 16:39                           ` mdalam
2021-02-09 17:35                           ` Bjorn Andersson
2021-02-11  4:01                             ` mdalam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec3f90470eca80256d3c335c7fb23e4e@codeaurora.org \
    --to=mdalam@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdalam=codeaurora.org@codeaurora.org \
    --cc=sricharan@codeaurora.org \
    --cc=thara.gopinath@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).