From: rishabhb@codeaurora.org
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, Chris Lew <clew@codeaurora.org>,
Sibi <sibis@codeaurora.org>,
Siddharth Gupta <sidgup@codeaurora.org>,
linux-remoteproc-owner@vger.kernel.org
Subject: Re: [PATCH 2/4] soc: qcom: glink_ssr: Internalize ssr_notifiers
Date: Thu, 07 May 2020 11:00:54 -0700 [thread overview]
Message-ID: <ec8920c9aca56278abff44745df5425e@codeaurora.org> (raw)
In-Reply-To: <20200423003736.2027371-3-bjorn.andersson@linaro.org>
On 2020-04-22 17:37, Bjorn Andersson wrote:
> Rather than carrying a special purpose blocking notifier for glink_ssr
> in remoteproc's qcom_common.c, move it into glink_ssr so allow wider
> reuse of the common one.
>
> The rpmsg glink header file is used in preparation for the next patch.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
Acked-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
> drivers/remoteproc/qcom_common.c | 8 ++++++++
> drivers/soc/qcom/glink_ssr.c | 24 +++++++++++++++++++-----
> include/linux/rpmsg/qcom_glink.h | 6 ++++++
> 3 files changed, 33 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_common.c
> b/drivers/remoteproc/qcom_common.c
> index ff26f2b68752..9028cea2d81e 100644
> --- a/drivers/remoteproc/qcom_common.c
> +++ b/drivers/remoteproc/qcom_common.c
> @@ -42,6 +42,13 @@ static void glink_subdev_stop(struct rproc_subdev
> *subdev, bool crashed)
> glink->edge = NULL;
> }
>
> +static void glink_subdev_unprepare(struct rproc_subdev *subdev)
> +{
> + struct qcom_rproc_glink *glink = to_glink_subdev(subdev);
> +
> + qcom_glink_ssr_notify(glink->ssr_name);
> +}
> +
> /**
> * qcom_add_glink_subdev() - try to add a GLINK subdevice to rproc
> * @rproc: rproc handle to parent the subdevice
> @@ -64,6 +71,7 @@ void qcom_add_glink_subdev(struct rproc *rproc,
> struct qcom_rproc_glink *glink,
> glink->dev = dev;
> glink->subdev.start = glink_subdev_start;
> glink->subdev.stop = glink_subdev_stop;
> + glink->subdev.unprepare = glink_subdev_unprepare;
>
> rproc_add_subdev(rproc, &glink->subdev);
> }
> diff --git a/drivers/soc/qcom/glink_ssr.c
> b/drivers/soc/qcom/glink_ssr.c
> index d7babe3d67bc..847d79c935f1 100644
> --- a/drivers/soc/qcom/glink_ssr.c
> +++ b/drivers/soc/qcom/glink_ssr.c
> @@ -54,6 +54,19 @@ struct glink_ssr {
> struct completion completion;
> };
>
> +/* Notifier list for all registered glink_ssr instances */
> +static BLOCKING_NOTIFIER_HEAD(ssr_notifiers);
> +
> +/**
> + * qcom_glink_ssr_notify() - notify GLINK SSR about stopped remoteproc
> + * @ssr_name: name of the remoteproc that has been stopped
> + */
> +void qcom_glink_ssr_notify(const char *ssr_name)
> +{
> + blocking_notifier_call_chain(&ssr_notifiers, 0, (void *)ssr_name);
> +}
> +EXPORT_SYMBOL_GPL(qcom_glink_ssr_notify);
> +
> static int qcom_glink_ssr_callback(struct rpmsg_device *rpdev,
> void *data, int len, void *priv, u32 addr)
> {
> @@ -81,8 +94,9 @@ static int qcom_glink_ssr_callback(struct
> rpmsg_device *rpdev,
> return 0;
> }
>
> -static int qcom_glink_ssr_notify(struct notifier_block *nb, unsigned
> long event,
> - void *data)
> +static int qcom_glink_ssr_notifier_call(struct notifier_block *nb,
> + unsigned long event,
> + void *data)
> {
> struct glink_ssr *ssr = container_of(nb, struct glink_ssr, nb);
> struct do_cleanup_msg msg;
> @@ -121,18 +135,18 @@ static int qcom_glink_ssr_probe(struct
> rpmsg_device *rpdev)
>
> ssr->dev = &rpdev->dev;
> ssr->ept = rpdev->ept;
> - ssr->nb.notifier_call = qcom_glink_ssr_notify;
> + ssr->nb.notifier_call = qcom_glink_ssr_notifier_call;
>
> dev_set_drvdata(&rpdev->dev, ssr);
>
> - return qcom_register_ssr_notifier(&ssr->nb);
> + return blocking_notifier_chain_register(&ssr_notifiers, &ssr->nb);
> }
>
> static void qcom_glink_ssr_remove(struct rpmsg_device *rpdev)
> {
> struct glink_ssr *ssr = dev_get_drvdata(&rpdev->dev);
>
> - qcom_unregister_ssr_notifier(&ssr->nb);
> + blocking_notifier_chain_unregister(&ssr_notifiers, &ssr->nb);
> }
>
> static const struct rpmsg_device_id qcom_glink_ssr_match[] = {
> diff --git a/include/linux/rpmsg/qcom_glink.h
> b/include/linux/rpmsg/qcom_glink.h
> index 96e26d94719f..09daa0acde2c 100644
> --- a/include/linux/rpmsg/qcom_glink.h
> +++ b/include/linux/rpmsg/qcom_glink.h
> @@ -26,4 +26,10 @@ static inline void
> qcom_glink_smem_unregister(struct qcom_glink *glink) {}
>
> #endif
>
> +#if IS_ENABLED(CONFIG_RPMSG_QCOM_GLINK_SSR)
> +void qcom_glink_ssr_notify(const char *ssr_name);
> +#else
> +static inline void qcom_glink_ssr_notify(const char *ssr_name) {}
> +#endif
> +
> #endif
next prev parent reply other threads:[~2020-05-07 18:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 0:37 [PATCH 0/4] rpmsg: Refactor Qualcomm glink_ssr Bjorn Andersson
2020-04-23 0:37 ` [PATCH 1/4] remoteproc: qcom: Pass ssr_name to glink subdevice Bjorn Andersson
2020-04-24 1:02 ` Chris Lew
2020-05-01 15:41 ` Mathieu Poirier
2020-05-07 18:00 ` rishabhb
2020-04-23 0:37 ` [PATCH 2/4] soc: qcom: glink_ssr: Internalize ssr_notifiers Bjorn Andersson
2020-04-24 1:03 ` Chris Lew
2020-05-01 17:37 ` Mathieu Poirier
2020-05-07 18:00 ` rishabhb [this message]
2020-04-23 0:37 ` [PATCH 3/4] rpmsg: glink: Integrate glink_ssr in qcom_glink Bjorn Andersson
2020-04-24 1:04 ` Chris Lew
2020-05-07 18:01 ` rishabhb
2020-04-23 0:37 ` [PATCH 4/4] arm64: defconfig: Remove QCOM_GLINK_SSR Bjorn Andersson
2020-04-24 1:05 ` Chris Lew
2020-05-07 18:03 ` rishabhb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec8920c9aca56278abff44745df5425e@codeaurora.org \
--to=rishabhb@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc-owner@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sibis@codeaurora.org \
--cc=sidgup@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).