* [PATCH 01/13] arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
@ 2021-02-25 22:12 ` Douglas Anderson
2021-03-14 0:28 ` Dmitry Baryshkov
2021-02-25 22:12 ` [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown Douglas Anderson
` (11 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:12 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Jeykumar Sankaran, Chandan Uddaraju, Vara Reddy, Tanmay Shah,
Douglas Anderson, Andy Gross, Rob Herring, devicetree,
linux-arm-msm, linux-kernel
From: Stephen Boyd <swboyd@chromium.org>
Drop the old node and add the new one in its place.
Cc: Stephen Boyd <swboyd@chromium.org>
Cc: Jeykumar Sankaran <jsanka@codeaurora.org>
Cc: Chandan Uddaraju <chandanu@codeaurora.org>
Cc: Vara Reddy <varar@codeaurora.org>
Cc: Tanmay Shah <tanmay@codeaurora.org>
Cc: Rob Clark <robdclark@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
[dianders: Adjusted due to DP not itself not in upstream dts yet]
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 1ea3344ab62c..60248a6757d8 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -2770,12 +2770,11 @@ usb_1_hsphy: phy@88e3000 {
};
usb_1_qmpphy: phy-wrapper@88e9000 {
- compatible = "qcom,sc7180-qmp-usb3-phy";
+ compatible = "qcom,sc7180-qmp-usb3-dp-phy";
reg = <0 0x088e9000 0 0x18c>,
- <0 0x088e8000 0 0x38>;
- reg-names = "reg-base", "dp_com";
+ <0 0x088e8000 0 0x38>,
+ <0 0x088ea000 0 0x40>;
status = "disabled";
- #clock-cells = <1>;
#address-cells = <2>;
#size-cells = <2>;
ranges;
@@ -2790,7 +2789,7 @@ usb_1_qmpphy: phy-wrapper@88e9000 {
<&gcc GCC_USB3_DP_PHY_PRIM_BCR>;
reset-names = "phy", "common";
- usb_1_ssphy: phy@88e9200 {
+ usb_1_ssphy: usb3-phy@88e9200 {
reg = <0 0x088e9200 0 0x128>,
<0 0x088e9400 0 0x200>,
<0 0x088e9c00 0 0x218>,
@@ -2803,6 +2802,16 @@ usb_1_ssphy: phy@88e9200 {
clock-names = "pipe0";
clock-output-names = "usb3_phy_pipe_clk_src";
};
+
+ dp_phy: dp-phy@88ea200 {
+ reg = <0 0x088ea200 0 0x200>,
+ <0 0x088ea400 0 0x200>,
+ <0 0x088eaa00 0 0x200>,
+ <0 0x088ea600 0 0x200>,
+ <0 0x088ea800 0 0x200>;
+ #clock-cells = <1>;
+ #phy-cells = <0>;
+ };
};
dc_noc: interconnect@9160000 {
@@ -3166,8 +3175,8 @@ dispcc: clock-controller@af00000 {
<&gcc GCC_DISP_GPLL0_CLK_SRC>,
<&dsi_phy 0>,
<&dsi_phy 1>,
- <0>,
- <0>;
+ <&dp_phy 0>,
+ <&dp_phy 1>;
clock-names = "bi_tcxo",
"gcc_disp_gpll0_clk_src",
"dsi0_phy_pll_out_byteclk",
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 01/13] arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy
2021-02-25 22:12 ` [PATCH 01/13] arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy Douglas Anderson
@ 2021-03-14 0:28 ` Dmitry Baryshkov
2021-03-15 17:40 ` Doug Anderson
0 siblings, 1 reply; 33+ messages in thread
From: Dmitry Baryshkov @ 2021-03-14 0:28 UTC (permalink / raw)
To: Douglas Anderson, Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Jeykumar Sankaran, Chandan Uddaraju, Vara Reddy, Tanmay Shah,
Andy Gross, Rob Herring, devicetree, linux-arm-msm, linux-kernel
On 26/02/2021 01:12, Douglas Anderson wrote:
> From: Stephen Boyd <swboyd@chromium.org>
>
> Drop the old node and add the new one in its place.
>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: Jeykumar Sankaran <jsanka@codeaurora.org>
> Cc: Chandan Uddaraju <chandanu@codeaurora.org>
> Cc: Vara Reddy <varar@codeaurora.org>
> Cc: Tanmay Shah <tanmay@codeaurora.org>
> Cc: Rob Clark <robdclark@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> [dianders: Adjusted due to DP not itself not in upstream dts yet]
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 23 ++++++++++++++++-------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 1ea3344ab62c..60248a6757d8 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -2770,12 +2770,11 @@ usb_1_hsphy: phy@88e3000 {
> };
>
> usb_1_qmpphy: phy-wrapper@88e9000 {
> - compatible = "qcom,sc7180-qmp-usb3-phy";
> + compatible = "qcom,sc7180-qmp-usb3-dp-phy";
> reg = <0 0x088e9000 0 0x18c>,
> - <0 0x088e8000 0 0x38>;
> - reg-names = "reg-base", "dp_com";
> + <0 0x088e8000 0 0x38>,
Technically this should be 0x3c. Offset 0x38 is USB3_DP_COM_REVISION_ID3
(not used by the current driver though).
> + <0 0x088ea000 0 0x40>;
I think 0x40 is not enough here.
This is a serdes region and qmp_v3_dp_serdes_tbl contains registers
0x148 and 0x154.
> status = "disabled";
> - #clock-cells = <1>;
> #address-cells = <2>;
> #size-cells = <2>;
> ranges;
> @@ -2790,7 +2789,7 @@ usb_1_qmpphy: phy-wrapper@88e9000 {
> <&gcc GCC_USB3_DP_PHY_PRIM_BCR>;
> reset-names = "phy", "common";
>
> - usb_1_ssphy: phy@88e9200 {
> + usb_1_ssphy: usb3-phy@88e9200 {
> reg = <0 0x088e9200 0 0x128>,
> <0 0x088e9400 0 0x200>,
> <0 0x088e9c00 0 0x218>,
> @@ -2803,6 +2802,16 @@ usb_1_ssphy: phy@88e9200 {
> clock-names = "pipe0";
> clock-output-names = "usb3_phy_pipe_clk_src";
> };
> +
> + dp_phy: dp-phy@88ea200 {
> + reg = <0 0x088ea200 0 0x200>,
> + <0 0x088ea400 0 0x200>,
> + <0 0x088eaa00 0 0x200>,
> + <0 0x088ea600 0 0x200>,
> + <0 0x088ea800 0 0x200>;
> + #clock-cells = <1>;
> + #phy-cells = <0>;
> + };
> };
>
> dc_noc: interconnect@9160000 {
> @@ -3166,8 +3175,8 @@ dispcc: clock-controller@af00000 {
> <&gcc GCC_DISP_GPLL0_CLK_SRC>,
> <&dsi_phy 0>,
> <&dsi_phy 1>,
> - <0>,
> - <0>;
> + <&dp_phy 0>,
> + <&dp_phy 1>;
> clock-names = "bi_tcxo",
> "gcc_disp_gpll0_clk_src",
> "dsi0_phy_pll_out_byteclk",
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH 01/13] arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy
2021-03-14 0:28 ` Dmitry Baryshkov
@ 2021-03-15 17:40 ` Doug Anderson
0 siblings, 0 replies; 33+ messages in thread
From: Doug Anderson @ 2021-03-15 17:40 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan,
Matthias Kaehlcke, Rob Clark, Jeykumar Sankaran,
Chandan Uddaraju, Vara Reddy, Tanmay Shah, Andy Gross,
Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm, LKML
Hi,
On Sat, Mar 13, 2021 at 4:28 PM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> > usb_1_qmpphy: phy-wrapper@88e9000 {
> > - compatible = "qcom,sc7180-qmp-usb3-phy";
> > + compatible = "qcom,sc7180-qmp-usb3-dp-phy";
> > reg = <0 0x088e9000 0 0x18c>,
> > - <0 0x088e8000 0 0x38>;
> > - reg-names = "reg-base", "dp_com";
> > + <0 0x088e8000 0 0x38>,
>
> Technically this should be 0x3c. Offset 0x38 is USB3_DP_COM_REVISION_ID3
> (not used by the current driver though).
>
> > + <0 0x088ea000 0 0x40>;
>
> I think 0x40 is not enough here.
> This is a serdes region and qmp_v3_dp_serdes_tbl contains registers
> 0x148 and 0x154.
OK!
https://lore.kernel.org/r/20210315103836.1.I9a97120319d43b42353aeac4d348624d60687df7@changeid
-Doug
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
2021-02-25 22:12 ` [PATCH 01/13] arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy Douglas Anderson
@ 2021-02-25 22:12 ` Douglas Anderson
2021-02-25 22:55 ` Konrad Dybcio
2021-02-25 23:48 ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 03/13] arm64: dts: qcom: Prep sc7180-trogdor trackpad IRQ for new boards Douglas Anderson
` (10 subsequent siblings)
12 siblings, 2 replies; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:12 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Douglas Anderson, V Sujith Kumar Reddy, Srinivasa Rao Mandadapu,
Tzung-Bi Shih, Judy Hsiao, Andy Gross, Rob Herring, devicetree,
linux-arm-msm, linux-kernel
In general pinconf belongs in board files, not SoC files. Move it to
the only current user (trogdor). Also adjust the drive strengths and
pulls.
Cc: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Cc: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Cc: Tzung-Bi Shih <tzungbi@chromium.org>
Cc: Judy Hsiao <judyhsiao@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
This should replace the patch ("Asoc: qcom: dts: Change MI2S GPIO
configuration to pulldown") [1].
[1] https://lore.kernel.org/r/1605526408-15671-1-git-send-email-srivasam@codeaurora.org
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 24 ++++++++++++++++++++
arch/arm64/boot/dts/qcom/sc7180.dtsi | 18 ---------------
2 files changed, 24 insertions(+), 18 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 07c8b2c926c0..25ab6572f9cf 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -875,6 +875,22 @@ pinconf {
};
};
+&pri_mi2s_active {
+ pinconf {
+ pins = "gpio53", "gpio54", "gpio55", "gpio56";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+};
+
+&pri_mi2s_mclk_active {
+ pinconf {
+ pins = "gpio57";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+};
+
&qspi_cs0 {
pinconf {
pins = "gpio68";
@@ -1015,6 +1031,14 @@ pinconf-rx {
};
};
+&sec_mi2s_active {
+ pinconf {
+ pins = "gpio49", "gpio50", "gpio51";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+};
+
/* PINCTRL - board-specific pinctrl */
&pm6150_gpio {
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 60248a6757d8..5040923a9f7c 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1856,12 +1856,6 @@ pinmux {
pins = "gpio49", "gpio50", "gpio51";
function = "mi2s_1";
};
-
- pinconf {
- pins = "gpio49", "gpio50", "gpio51";
- drive-strength = <8>;
- bias-pull-up;
- };
};
pri_mi2s_active: pri-mi2s-active {
@@ -1869,12 +1863,6 @@ pinmux {
pins = "gpio53", "gpio54", "gpio55", "gpio56";
function = "mi2s_0";
};
-
- pinconf {
- pins = "gpio53", "gpio54", "gpio55", "gpio56";
- drive-strength = <8>;
- bias-pull-up;
- };
};
pri_mi2s_mclk_active: pri-mi2s-mclk-active {
@@ -1882,12 +1870,6 @@ pinmux {
pins = "gpio57";
function = "lpass_ext";
};
-
- pinconf {
- pins = "gpio57";
- drive-strength = <8>;
- bias-pull-up;
- };
};
sdc1_on: sdc1-on {
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown
2021-02-25 22:12 ` [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown Douglas Anderson
@ 2021-02-25 22:55 ` Konrad Dybcio
2021-02-25 22:57 ` Doug Anderson
2021-02-25 23:48 ` Matthias Kaehlcke
1 sibling, 1 reply; 33+ messages in thread
From: Konrad Dybcio @ 2021-02-25 22:55 UTC (permalink / raw)
To: Douglas Anderson, Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
V Sujith Kumar Reddy, Srinivasa Rao Mandadapu, Tzung-Bi Shih,
Judy Hsiao, Andy Gross, Rob Herring, devicetree, linux-arm-msm,
linux-kernel
Hi,
>
> +&pri_mi2s_active {
> + pinconf {
> + pins = "gpio53", "gpio54", "gpio55", "gpio56";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +};
> +
You can omit pinconf{}, so the outcome would be:
&pri_mi2s_active {
pins = ...
...
};
This makes the DTs ever so shorter and is the style that's currently used for new submissions.
Same goes for the nodes that are being referenced.
> +&pri_mi2s_mclk_active {
> + pinconf {
> + pins = "gpio57";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +};
> +
> &qspi_cs0 {
> pinconf {
> pins = "gpio68";
> @@ -1015,6 +1031,14 @@ pinconf-rx {
> };
> };
>
> +&sec_mi2s_active {
> + pinconf {
> + pins = "gpio49", "gpio50", "gpio51";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +};
> +
> /* PINCTRL - board-specific pinctrl */
>
> &pm6150_gpio {
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 60248a6757d8..5040923a9f7c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1856,12 +1856,6 @@ pinmux {
> pins = "gpio49", "gpio50", "gpio51";
> function = "mi2s_1";
> };
> -
> - pinconf {
> - pins = "gpio49", "gpio50", "gpio51";
> - drive-strength = <8>;
> - bias-pull-up;
> - };
> };
>
> pri_mi2s_active: pri-mi2s-active {
> @@ -1869,12 +1863,6 @@ pinmux {
> pins = "gpio53", "gpio54", "gpio55", "gpio56";
> function = "mi2s_0";
> };
> -
> - pinconf {
> - pins = "gpio53", "gpio54", "gpio55", "gpio56";
> - drive-strength = <8>;
> - bias-pull-up;
> - };
> };
>
> pri_mi2s_mclk_active: pri-mi2s-mclk-active {
> @@ -1882,12 +1870,6 @@ pinmux {
> pins = "gpio57";
> function = "lpass_ext";
> };
> -
> - pinconf {
> - pins = "gpio57";
> - drive-strength = <8>;
> - bias-pull-up;
> - };
> };
>
> sdc1_on: sdc1-on {
>
Applies to all ^.
Konrad
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown
2021-02-25 22:55 ` Konrad Dybcio
@ 2021-02-25 22:57 ` Doug Anderson
2021-02-25 23:07 ` Konrad Dybcio
0 siblings, 1 reply; 33+ messages in thread
From: Doug Anderson @ 2021-02-25 22:57 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan,
Matthias Kaehlcke, Rob Clark, V Sujith Kumar Reddy,
Srinivasa Rao Mandadapu, Tzung-Bi Shih, Judy Hsiao, Andy Gross,
Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm, LKML
Hi,
On Thu, Feb 25, 2021 at 2:55 PM Konrad Dybcio
<konrad.dybcio@somainline.org> wrote:
>
> Hi,
>
>
> >
> > +&pri_mi2s_active {
> > + pinconf {
> > + pins = "gpio53", "gpio54", "gpio55", "gpio56";
> > + drive-strength = <2>;
> > + bias-pull-down;
> > + };
> > +};
> > +
>
> You can omit pinconf{}, so the outcome would be:
> &pri_mi2s_active {
>
> pins = ...
>
> ...
>
> };
>
>
> This makes the DTs ever so shorter and is the style that's currently used for new submissions.
>
> Same goes for the nodes that are being referenced.
Yes, I agree. That definitely makes sense going forward, but I think
it'll just add to the confusion to switch a dts for a given SoC
mid-stride. ...or, if we do switch the style it should be done in a
separate (no-op) patch series. This series is already giant enough...
-Doug
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown
2021-02-25 22:57 ` Doug Anderson
@ 2021-02-25 23:07 ` Konrad Dybcio
0 siblings, 0 replies; 33+ messages in thread
From: Konrad Dybcio @ 2021-02-25 23:07 UTC (permalink / raw)
To: Doug Anderson
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan,
Matthias Kaehlcke, Rob Clark, V Sujith Kumar Reddy,
Srinivasa Rao Mandadapu, Tzung-Bi Shih, Judy Hsiao, Andy Gross,
Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm, LKML
> Yes, I agree. That definitely makes sense going forward, but I think
> it'll just add to the confusion to switch a dts for a given SoC
> mid-stride. ...or, if we do switch the style it should be done in a
> separate (no-op) patch series. This series is already giant enough...
>
> -Doug
Sounds good to me!
Konrad
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown
2021-02-25 22:12 ` [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown Douglas Anderson
2021-02-25 22:55 ` Konrad Dybcio
@ 2021-02-25 23:48 ` Matthias Kaehlcke
1 sibling, 0 replies; 33+ messages in thread
From: Matthias Kaehlcke @ 2021-02-25 23:48 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan, Rob Clark,
V Sujith Kumar Reddy, Srinivasa Rao Mandadapu, Tzung-Bi Shih,
Judy Hsiao, Andy Gross, Rob Herring, devicetree, linux-arm-msm,
linux-kernel
On Thu, Feb 25, 2021 at 02:12:59PM -0800, Douglas Anderson wrote:
> In general pinconf belongs in board files, not SoC files. Move it to
> the only current user (trogdor). Also adjust the drive strengths and
> pulls.
>
> Cc: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> Cc: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> Cc: Tzung-Bi Shih <tzungbi@chromium.org>
> Cc: Judy Hsiao <judyhsiao@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> This should replace the patch ("Asoc: qcom: dts: Change MI2S GPIO
> configuration to pulldown") [1].
>
> [1] https://lore.kernel.org/r/1605526408-15671-1-git-send-email-srivasam@codeaurora.org
>
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 24 ++++++++++++++++++++
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 18 ---------------
> 2 files changed, 24 insertions(+), 18 deletions(-)
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 03/13] arm64: dts: qcom: Prep sc7180-trogdor trackpad IRQ for new boards
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
2021-02-25 22:12 ` [PATCH 01/13] arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy Douglas Anderson
2021-02-25 22:12 ` [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown Douglas Anderson
@ 2021-02-25 22:13 ` Douglas Anderson
2021-02-25 23:54 ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 04/13] arm64: dts: qcom: Unify the sc7180-trogdor panel nodes Douglas Anderson
` (9 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:13 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Douglas Anderson, Andy Gross, Rob Herring, devicetree,
linux-arm-msm, linux-kernel
The trackpad interrupt got renamed and also moved to a new GPIO on
newer boards. Let's do the move in the "trogdor.dtsi" file and then
undo it in the two old boards.
NOTE: since none of the new boards have device trees yet, this change
looks silly on its own but it will make sense after more boards are
supported.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
.../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 14 ++++++++++++++
arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 16 ++++++++++++++++
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 14 ++++++++------
3 files changed, 38 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
index 89e5cd29ec09..11269522da50 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
@@ -58,8 +58,22 @@ ap_ts: touchscreen@10 {
};
};
+&trackpad {
+ interrupts = <58 IRQ_TYPE_EDGE_FALLING>;
+};
+
/* PINCTRL - modifications to sc7180-trogdor.dtsi */
+&trackpad_int_1v8_odl {
+ pinmux {
+ pins = "gpio58";
+ };
+
+ pinconf {
+ pins = "gpio58";
+ };
+};
+
&ts_reset_l {
pinconf {
/* This pin is not connected on -rev0, pull up to park. */
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts
index 2cb522d6962e..bd2c783e0f2f 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts
@@ -68,6 +68,22 @@ &sdhc_2 {
status = "okay";
};
+&trackpad {
+ interrupts = <58 IRQ_TYPE_EDGE_FALLING>;
+};
+
+/* PINCTRL - modifications to sc7180-trogdor.dtsi */
+
+&trackpad_int_1v8_odl {
+ pinmux {
+ pins = "gpio58";
+ };
+
+ pinconf {
+ pins = "gpio58";
+ };
+};
+
/* PINCTRL - board-specific pinctrl */
&tlmm {
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 25ab6572f9cf..4ad27b5c34d1 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -642,14 +642,14 @@ ap_tp_i2c: &i2c7 {
status = "okay";
clock-frequency = <400000>;
- trackpad@15 {
+ trackpad: trackpad@15 {
compatible = "elan,ekth3000";
reg = <0x15>;
pinctrl-names = "default";
- pinctrl-0 = <&trackpad_int_1v8_odl>;
+ pinctrl-0 = <&tp_int_odl>;
interrupt-parent = <&tlmm>;
- interrupts = <58 IRQ_TYPE_EDGE_FALLING>;
+ interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
vcc-supply = <&pp3300_fp_tp>;
@@ -1410,14 +1410,16 @@ pinconf-rx {
};
};
- trackpad_int_1v8_odl: trackpad-int-1v8-odl {
+ /* Named trackpad_int_1v8_odl on earlier revision schematics */
+ trackpad_int_1v8_odl:
+ tp_int_odl: tp-int-odl {
pinmux {
- pins = "gpio58";
+ pins = "gpio0";
function = "gpio";
};
pinconf {
- pins = "gpio58";
+ pins = "gpio0";
/* Has external pullup */
bias-disable;
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 03/13] arm64: dts: qcom: Prep sc7180-trogdor trackpad IRQ for new boards
2021-02-25 22:13 ` [PATCH 03/13] arm64: dts: qcom: Prep sc7180-trogdor trackpad IRQ for new boards Douglas Anderson
@ 2021-02-25 23:54 ` Matthias Kaehlcke
0 siblings, 0 replies; 33+ messages in thread
From: Matthias Kaehlcke @ 2021-02-25 23:54 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan, Rob Clark,
Andy Gross, Rob Herring, devicetree, linux-arm-msm, linux-kernel
On Thu, Feb 25, 2021 at 02:13:00PM -0800, Douglas Anderson wrote:
> The trackpad interrupt got renamed and also moved to a new GPIO on
> newer boards. Let's do the move in the "trogdor.dtsi" file and then
> undo it in the two old boards.
>
> NOTE: since none of the new boards have device trees yet, this change
> looks silly on its own but it will make sense after more boards are
> supported.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 04/13] arm64: dts: qcom: Unify the sc7180-trogdor panel nodes
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
` (2 preceding siblings ...)
2021-02-25 22:13 ` [PATCH 03/13] arm64: dts: qcom: Prep sc7180-trogdor trackpad IRQ for new boards Douglas Anderson
@ 2021-02-25 22:13 ` Douglas Anderson
2021-02-25 23:58 ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 05/13] arm64: dts: qcom: trogdor: Only wakeup from pen eject Douglas Anderson
` (8 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:13 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Douglas Anderson, Andy Gross, Rob Herring, devicetree,
linux-arm-msm, linux-kernel
Let's avoid a bit of duplication by pushing this up to the trogdor.dtsi
file.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
.../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 21 ++++---------------
.../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 ++++-------------
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 15 +++++++++++++
3 files changed, 23 insertions(+), 32 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
index 11269522da50..5efa04d0d256 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
@@ -12,23 +12,6 @@
#include "sc7180-trogdor.dtsi"
-/ {
- panel: panel {
- compatible = "boe,nv133fhm-n62";
- power-supply = <&pp3300_dx_edp>;
- backlight = <&backlight>;
- hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>;
-
- ports {
- port {
- panel_in_edp: endpoint {
- remote-endpoint = <&sn65dsi86_out>;
- };
- };
- };
- };
-};
-
&ap_sar_sensor {
semtech,cs0-ground;
semtech,combined-sensors = <3>;
@@ -58,6 +41,10 @@ ap_ts: touchscreen@10 {
};
};
+&panel {
+ compatible = "boe,nv133fhm-n62";
+};
+
&trackpad {
interrupts = <58 IRQ_TYPE_EDGE_FALLING>;
};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts
index bd2c783e0f2f..2b522f9e0d8f 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts
@@ -17,21 +17,6 @@
/ {
model = "Google Trogdor (rev1+)";
compatible = "google,trogdor", "qcom,sc7180";
-
- panel: panel {
- compatible = "auo,b116xa01";
- power-supply = <&pp3300_dx_edp>;
- backlight = <&backlight>;
- hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>;
-
- ports {
- port {
- panel_in_edp: endpoint {
- remote-endpoint = <&sn65dsi86_out>;
- };
- };
- };
- };
};
ap_ts_pen_1v8: &i2c4 {
@@ -53,6 +38,10 @@ ap_ts: touchscreen@10 {
};
};
+&panel {
+ compatible = "auo,b116xa01";
+};
+
&pp3300_hub {
/* pp3300_l7c is used to power the USB hub */
/delete-property/regulator-always-on;
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 4ad27b5c34d1..9fcb19a0501f 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -255,6 +255,21 @@ max98357a: audio-codec-0 {
#sound-dai-cells = <0>;
};
+ panel: panel {
+ /* Compatible will be filled in per-board */
+ power-supply = <&pp3300_dx_edp>;
+ backlight = <&backlight>;
+ hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>;
+
+ ports {
+ port {
+ panel_in_edp: endpoint {
+ remote-endpoint = <&sn65dsi86_out>;
+ };
+ };
+ };
+ };
+
pwmleds {
compatible = "pwm-leds";
keyboard_backlight: keyboard-backlight {
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 04/13] arm64: dts: qcom: Unify the sc7180-trogdor panel nodes
2021-02-25 22:13 ` [PATCH 04/13] arm64: dts: qcom: Unify the sc7180-trogdor panel nodes Douglas Anderson
@ 2021-02-25 23:58 ` Matthias Kaehlcke
0 siblings, 0 replies; 33+ messages in thread
From: Matthias Kaehlcke @ 2021-02-25 23:58 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan, Rob Clark,
Andy Gross, Rob Herring, devicetree, linux-arm-msm, linux-kernel
On Thu, Feb 25, 2021 at 02:13:01PM -0800, Douglas Anderson wrote:
> Let's avoid a bit of duplication by pushing this up to the trogdor.dtsi
> file.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 05/13] arm64: dts: qcom: trogdor: Only wakeup from pen eject
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
` (3 preceding siblings ...)
2021-02-25 22:13 ` [PATCH 04/13] arm64: dts: qcom: Unify the sc7180-trogdor panel nodes Douglas Anderson
@ 2021-02-25 22:13 ` Douglas Anderson
2021-02-26 0:02 ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 06/13] arm64: dts: qcom: Disable camera clk on sc7180-trogdor devices by default Douglas Anderson
` (7 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:13 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Douglas Anderson, Andy Gross, Rob Herring, devicetree,
linux-arm-msm, linux-kernel
From: Stephen Boyd <swboyd@chromium.org>
Configure the pen to be a wakeup source only when the pen is ejected
instead of both when the pen is ejected and inserted. This corresponds
to wake source requirements.
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 9fcb19a0501f..f3a99c801582 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -6,6 +6,7 @@
*/
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/gpio-keys.h>
#include <dt-bindings/input/input.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
@@ -243,6 +244,7 @@ pen_insert: pen-insert {
gpios = <&tlmm 52 GPIO_ACTIVE_LOW>;
linux,code = <SW_PEN_INSERTED>;
linux,input-type = <EV_SW>;
+ wakeup-event-action = <EV_ACT_DEASSERTED>;
wakeup-source;
};
};
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 05/13] arm64: dts: qcom: trogdor: Only wakeup from pen eject
2021-02-25 22:13 ` [PATCH 05/13] arm64: dts: qcom: trogdor: Only wakeup from pen eject Douglas Anderson
@ 2021-02-26 0:02 ` Matthias Kaehlcke
0 siblings, 0 replies; 33+ messages in thread
From: Matthias Kaehlcke @ 2021-02-26 0:02 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan, Rob Clark,
Andy Gross, Rob Herring, devicetree, linux-arm-msm, linux-kernel
On Thu, Feb 25, 2021 at 02:13:02PM -0800, Douglas Anderson wrote:
> From: Stephen Boyd <swboyd@chromium.org>
>
> Configure the pen to be a wakeup source only when the pen is ejected
> instead of both when the pen is ejected and inserted. This corresponds
> to wake source requirements.
>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 06/13] arm64: dts: qcom: Disable camera clk on sc7180-trogdor devices by default
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
` (4 preceding siblings ...)
2021-02-25 22:13 ` [PATCH 05/13] arm64: dts: qcom: trogdor: Only wakeup from pen eject Douglas Anderson
@ 2021-02-25 22:13 ` Douglas Anderson
2021-02-26 0:06 ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 07/13] arm64: dts: qcom: sc7180-trogdor: Remove fp control pins in prep for coachz Douglas Anderson
` (6 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:13 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Tomasz Figa, Douglas Anderson, Andy Gross, Rob Herring,
devicetree, linux-arm-msm, linux-kernel
From: Stephen Boyd <swboyd@chromium.org>
We only want to use this clk driver on CoachZ devices. Disable it for
all other Trogdor boards. NOTE: CoachZ devices aren't yet supported
upstream so until it is this is just disabled for all trogdor.
Cc: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
[dianders:adjusted since no coachz upstream yet]
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index f3a99c801582..69bf600e1c9f 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -568,6 +568,10 @@ cr50: tpm@0 {
};
};
+&camcc {
+ status = "disabled";
+};
+
&dsi0 {
status = "okay";
vdda-supply = <&vdda_mipi_dsi0_1p2>;
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 06/13] arm64: dts: qcom: Disable camera clk on sc7180-trogdor devices by default
2021-02-25 22:13 ` [PATCH 06/13] arm64: dts: qcom: Disable camera clk on sc7180-trogdor devices by default Douglas Anderson
@ 2021-02-26 0:06 ` Matthias Kaehlcke
0 siblings, 0 replies; 33+ messages in thread
From: Matthias Kaehlcke @ 2021-02-26 0:06 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan, Rob Clark,
Tomasz Figa, Andy Gross, Rob Herring, devicetree, linux-arm-msm,
linux-kernel
On Thu, Feb 25, 2021 at 02:13:03PM -0800, Douglas Anderson wrote:
> From: Stephen Boyd <swboyd@chromium.org>
>
> We only want to use this clk driver on CoachZ devices. Disable it for
> all other Trogdor boards. NOTE: CoachZ devices aren't yet supported
> upstream so until it is this is just disabled for all trogdor.
>
> Cc: Tomasz Figa <tfiga@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> [dianders:adjusted since no coachz upstream yet]
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 07/13] arm64: dts: qcom: sc7180-trogdor: Remove fp control pins in prep for coachz
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
` (5 preceding siblings ...)
2021-02-25 22:13 ` [PATCH 06/13] arm64: dts: qcom: Disable camera clk on sc7180-trogdor devices by default Douglas Anderson
@ 2021-02-25 22:13 ` Douglas Anderson
2021-02-26 0:14 ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 08/13] arm64: dts: qcom: sc7180: Remove clock for bluetooth on Trogdor Douglas Anderson
` (5 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:13 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Craig Hesling, Douglas Anderson, Andy Gross, Rob Herring,
devicetree, linux-arm-msm, linux-kernel
From: Alexandru M Stan <amstan@chromium.org>
Removed the pinctrl and pin{mux,conf} for the control pins because:
1. The only need for them is for userspace control via flash_fp_mcu
2. cros-ec doesn't know what to do with them, and even if it did,
it would interfere with flash_fp_mcu at the most inopportune times
Since we're not using hogs, we rely on AP firmware to set all the
control pins correctly.
Cc: Stephen Boyd <swboyd@chromium.org>
Cc: Craig Hesling <hesling@chromium.org>
Signed-off-by: Alexandru M Stan <amstan@chromium.org>
[dianders: adjusted since coachz isn't upstream yet]
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 45 +-------------------
1 file changed, 1 insertion(+), 44 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 69bf600e1c9f..12397e31bef6 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -808,7 +808,7 @@ cros_ec_fp: ec@0 {
interrupt-parent = <&tlmm>;
interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
pinctrl-names = "default";
- pinctrl-0 = <&fp_to_ap_irq_l>, <&fp_rst_l>, <&fpmcu_boot0>, <&fpmcu_sel>;
+ pinctrl-0 = <&fp_to_ap_irq_l>;
spi-max-frequency = <3000000>;
};
};
@@ -1233,48 +1233,6 @@ pinconf {
};
};
- fpmcu_boot0: fpmcu-boot0 {
- pinmux {
- pins = "gpio10";
- function = "gpio";
- };
-
- pinconf {
- pins = "gpio10";
- bias-disable;
- drive-strength = <2>;
- output-low;
- };
- };
-
- fpmcu_sel: fpmcu-sel {
- pinmux {
- pins = "gpio22";
- function = "gpio";
- };
-
- pinconf {
- pins = "gpio22";
- bias-disable;
- drive-strength = <2>;
- output-high;
- };
- };
-
- fp_rst_l: fp-rst-l {
- pinmux {
- pins = "gpio5";
- function = "gpio";
- };
-
- pinconf {
- pins = "gpio5";
- bias-disable;
- drive-strength = <2>;
- output-high;
- };
- };
-
fp_to_ap_irq_l: fp-to-ap-irq-l {
pinmux {
pins = "gpio4";
@@ -1290,7 +1248,6 @@ pinconf {
};
};
-
h1_ap_int_odl: h1-ap-int-odl {
pinmux {
pins = "gpio42";
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 07/13] arm64: dts: qcom: sc7180-trogdor: Remove fp control pins in prep for coachz
2021-02-25 22:13 ` [PATCH 07/13] arm64: dts: qcom: sc7180-trogdor: Remove fp control pins in prep for coachz Douglas Anderson
@ 2021-02-26 0:14 ` Matthias Kaehlcke
0 siblings, 0 replies; 33+ messages in thread
From: Matthias Kaehlcke @ 2021-02-26 0:14 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan, Rob Clark,
Craig Hesling, Andy Gross, Rob Herring, devicetree,
linux-arm-msm, linux-kernel
On Thu, Feb 25, 2021 at 02:13:04PM -0800, Douglas Anderson wrote:
> From: Alexandru M Stan <amstan@chromium.org>
>
> Removed the pinctrl and pin{mux,conf} for the control pins because:
> 1. The only need for them is for userspace control via flash_fp_mcu
> 2. cros-ec doesn't know what to do with them, and even if it did,
> it would interfere with flash_fp_mcu at the most inopportune times
>
> Since we're not using hogs, we rely on AP firmware to set all the
> control pins correctly.
>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: Craig Hesling <hesling@chromium.org>
> Signed-off-by: Alexandru M Stan <amstan@chromium.org>
> [dianders: adjusted since coachz isn't upstream yet]
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
We have essentially the same patch downstream, so I suppose the AP FW
indeed takes care of configuring the FP pins as needed :)
Reviewed-by; Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 08/13] arm64: dts: qcom: sc7180: Remove clock for bluetooth on Trogdor
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
` (6 preceding siblings ...)
2021-02-25 22:13 ` [PATCH 07/13] arm64: dts: qcom: sc7180-trogdor: Remove fp control pins in prep for coachz Douglas Anderson
@ 2021-02-25 22:13 ` Douglas Anderson
2021-02-26 0:19 ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 09/13] arm64: dts: qcom: sc7180: add GO_LAZOR variant property for lazor Douglas Anderson
` (4 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:13 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Venkata Lakshmi Narayana Gubba, Douglas Anderson, Andy Gross,
Rob Herring, devicetree, linux-arm-msm, linux-kernel
From: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
Removed voting for RPMH_RF_CLK2 which is not required as it is
getting managed by BT SoC through SW_CTRL line.
Cc: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 12397e31bef6..05e3c3db2e9a 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -833,7 +833,6 @@ bluetooth: bluetooth {
vddrf-supply = <&pp1300_l2c>;
vddch0-supply = <&pp3300_l10c>;
max-speed = <3200000>;
- clocks = <&rpmhcc RPMH_RF_CLK2>;
};
};
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 08/13] arm64: dts: qcom: sc7180: Remove clock for bluetooth on Trogdor
2021-02-25 22:13 ` [PATCH 08/13] arm64: dts: qcom: sc7180: Remove clock for bluetooth on Trogdor Douglas Anderson
@ 2021-02-26 0:19 ` Matthias Kaehlcke
0 siblings, 0 replies; 33+ messages in thread
From: Matthias Kaehlcke @ 2021-02-26 0:19 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan, Rob Clark,
Venkata Lakshmi Narayana Gubba, Andy Gross, Rob Herring,
devicetree, linux-arm-msm, linux-kernel
On Thu, Feb 25, 2021 at 02:13:05PM -0800, Douglas Anderson wrote:
> From: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
>
> Removed voting for RPMH_RF_CLK2 which is not required as it is
> getting managed by BT SoC through SW_CTRL line.
>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 09/13] arm64: dts: qcom: sc7180: add GO_LAZOR variant property for lazor
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
` (7 preceding siblings ...)
2021-02-25 22:13 ` [PATCH 08/13] arm64: dts: qcom: sc7180: Remove clock for bluetooth on Trogdor Douglas Anderson
@ 2021-02-25 22:13 ` Douglas Anderson
2021-02-26 0:25 ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 10/13] arm64: dts: qcom: sc7180: Set up lazor r3+ as sc7180-lite SKUs Douglas Anderson
` (3 subsequent siblings)
12 siblings, 1 reply; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:13 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Abhishek Kumar, Philip Chen, Douglas Anderson, Andy Gross,
Rob Herring, devicetree, linux-arm-msm, linux-kernel
From: Abhishek Kumar <kuabhs@chromium.org>
For trogdor, in the latest board-2.bin file, new BDF with variant
name GO_LAZOR has been introduced, so we need this property set, for
GO_LAZOR BDF to be picked.
Cc: Philip Chen <philipchen@chromium.org>
Signed-off-by: Abhishek Kumar <kuabhs@chromium.org>
[dianders: adjusted subject line and sort order]
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
index 5efa04d0d256..6b10b96173e8 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
@@ -49,6 +49,10 @@ &trackpad {
interrupts = <58 IRQ_TYPE_EDGE_FALLING>;
};
+&wifi {
+ qcom,ath10k-calibration-variant = "GO_LAZOR";
+};
+
/* PINCTRL - modifications to sc7180-trogdor.dtsi */
&trackpad_int_1v8_odl {
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 09/13] arm64: dts: qcom: sc7180: add GO_LAZOR variant property for lazor
2021-02-25 22:13 ` [PATCH 09/13] arm64: dts: qcom: sc7180: add GO_LAZOR variant property for lazor Douglas Anderson
@ 2021-02-26 0:25 ` Matthias Kaehlcke
0 siblings, 0 replies; 33+ messages in thread
From: Matthias Kaehlcke @ 2021-02-26 0:25 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan, Rob Clark,
Abhishek Kumar, Philip Chen, Andy Gross, Rob Herring, devicetree,
linux-arm-msm, linux-kernel
On Thu, Feb 25, 2021 at 02:13:06PM -0800, Douglas Anderson wrote:
> From: Abhishek Kumar <kuabhs@chromium.org>
>
> For trogdor, in the latest board-2.bin file, new BDF with variant
> name GO_LAZOR has been introduced, so we need this property set, for
> GO_LAZOR BDF to be picked.
>
> Cc: Philip Chen <philipchen@chromium.org>
> Signed-off-by: Abhishek Kumar <kuabhs@chromium.org>
> [dianders: adjusted subject line and sort order]
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
I don't claim to be familiar with this part, but the same is done
downstream and the corresponding downstream commit references a bug
that talks about a 'GO_LAZOR' BDF variant, so this must be awesome!
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 10/13] arm64: dts: qcom: sc7180: Set up lazor r3+ as sc7180-lite SKUs
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
` (8 preceding siblings ...)
2021-02-25 22:13 ` [PATCH 09/13] arm64: dts: qcom: sc7180: add GO_LAZOR variant property for lazor Douglas Anderson
@ 2021-02-25 22:13 ` Douglas Anderson
2021-02-25 22:13 ` [PATCH 11/13] arm64: dts: qcom: Add sc7180-lazor-limozeen skus Douglas Anderson
` (2 subsequent siblings)
12 siblings, 0 replies; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:13 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Douglas Anderson, Andy Gross, Rob Herring, devicetree,
linux-arm-msm, linux-kernel
From: Matthias Kaehlcke <mka@chromium.org>
Lazor rev3 and later use the 'lite' version of the SC7180 SoC.
Cc: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
[dianders: Adjust commit message which referred to downstream history]
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dts | 5 ++++-
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts | 4 +++-
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dts | 1 +
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dts
index 6985beb97e53..dcb41afdc82a 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dts
@@ -5,7 +5,10 @@
* Copyright 2020 Google LLC.
*/
-#include "sc7180-trogdor-lazor-r3.dts"
+/dts-v1/;
+
+#include "sc7180-trogdor-lazor.dtsi"
+#include "sc7180-lite.dtsi"
/ {
model = "Google Lazor (rev3+) with KB Backlight";
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts
index 0881f8dd02c9..be44900602d7 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts
@@ -5,7 +5,9 @@
* Copyright 2020 Google LLC.
*/
-#include "sc7180-trogdor-lazor-r3.dts"
+/dts-v1/;
+
+#include "sc7180-trogdor-lazor.dtsi"
#include "sc7180-trogdor-lte-sku.dtsi"
/ {
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dts
index 1b9d2f46359e..b474df47cd70 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dts
@@ -8,6 +8,7 @@
/dts-v1/;
#include "sc7180-trogdor-lazor.dtsi"
+#include "sc7180-lite.dtsi"
/ {
model = "Google Lazor (rev3+)";
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* [PATCH 11/13] arm64: dts: qcom: Add sc7180-lazor-limozeen skus
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
` (9 preceding siblings ...)
2021-02-25 22:13 ` [PATCH 10/13] arm64: dts: qcom: sc7180: Set up lazor r3+ as sc7180-lite SKUs Douglas Anderson
@ 2021-02-25 22:13 ` Douglas Anderson
2021-02-26 0:40 ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 12/13] arm64: dts: qcom: Add sc7180-lazor-pompom skus Douglas Anderson
2021-02-25 22:13 ` [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus Douglas Anderson
12 siblings, 1 reply; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:13 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Douglas Anderson, Andy Gross, Rob Herring, devicetree,
linux-arm-msm, linux-kernel
This is a SKU variant of lazor. Add it. This squashes the downstream
patches to support this hardware.
NOTES:
- The non-touch SKU actually has "innolux,n116bca" but that driver is
still pending in simple-panel. The bindings have been Acked though.
Things work well enough with the "innolux,n116bge" timings for now,
though.
- The wonky special dts just for "-rev4" arguably doesn't need to go
upstream since they weren't widely distributed, but since a few
people have them we might as well. If it ever causes problems we
can delete it.
Cc: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/Makefile | 3 ++
.../sc7180-trogdor-lazor-limozeen-nots-r4.dts | 34 +++++++++++++++
.../sc7180-trogdor-lazor-limozeen-nots.dts | 26 ++++++++++++
.../qcom/sc7180-trogdor-lazor-limozeen.dts | 42 +++++++++++++++++++
4 files changed, 105 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 549a7a2151d4..adc915a5f027 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -38,6 +38,9 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r3.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r3-kb.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r3-lte.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-nots.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-nots-r4.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-ganges-kirin.dtb
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts
new file mode 100644
index 000000000000..6ebde0828550
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Lazor Limozeen board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+#include "sc7180-trogdor-lazor-limozeen-nots.dts"
+
+/ {
+ model = "Google Lazor Limozeen without Touchscreen (rev4)";
+ compatible = "google,lazor-rev4-sku5", "qcom,sc7180";
+};
+
+/*
+ * rev4-sku5 was built with a different trackpad.
+ */
+/delete-node/&trackpad;
+&ap_tp_i2c {
+ trackpad: trackpad@2c {
+ compatible = "hid-over-i2c";
+ reg = <0x2c>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&tp_int_odl>;
+
+ interrupt-parent = <&tlmm>;
+ interrupts = <58 IRQ_TYPE_EDGE_FALLING>;
+
+ vcc-supply = <&pp3300_fp_tp>;
+ hid-descr-addr = <0x20>;
+
+ wakeup-source;
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dts
new file mode 100644
index 000000000000..91f36eeb923c
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Lazor Limozeen board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+/dts-v1/;
+
+#include "sc7180-trogdor-lazor.dtsi"
+#include "sc7180-trogdor-lte-sku.dtsi"
+
+/ {
+ model = "Google Lazor Limozeen without Touchscreen";
+ compatible = "google,lazor-sku6", "google,lazor-sku5", "qcom,sc7180";
+};
+
+/delete-node/&ap_ts;
+
+&panel {
+ compatible = "innolux,n116bca", "innolux,n116bge";
+};
+
+&sdhc_2 {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dts
new file mode 100644
index 000000000000..e6ad6dae4e60
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dts
@@ -0,0 +1,42 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Lazor Limozeen board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+/dts-v1/;
+
+#include "sc7180-trogdor-lazor.dtsi"
+#include "sc7180-trogdor-lte-sku.dtsi"
+
+/ {
+ model = "Google Lazor Limozeen";
+ compatible = "google,lazor-sku4", "qcom,sc7180";
+};
+
+/delete-node/&ap_ts;
+
+&ap_ts_pen_1v8 {
+ ap_ts: touchscreen@10 {
+ compatible = "elan,ekth3500";
+ reg = <0x10>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&ts_int_l>, <&ts_reset_l>;
+
+ interrupt-parent = <&tlmm>;
+ interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
+
+ vcc33-supply = <&pp3300_ts>;
+
+ reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
+ };
+};
+
+&panel {
+ compatible = "auo,b116xa01";
+};
+
+&sdhc_2 {
+ status = "okay";
+};
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 11/13] arm64: dts: qcom: Add sc7180-lazor-limozeen skus
2021-02-25 22:13 ` [PATCH 11/13] arm64: dts: qcom: Add sc7180-lazor-limozeen skus Douglas Anderson
@ 2021-02-26 0:40 ` Matthias Kaehlcke
0 siblings, 0 replies; 33+ messages in thread
From: Matthias Kaehlcke @ 2021-02-26 0:40 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan, Rob Clark,
Andy Gross, Rob Herring, devicetree, linux-arm-msm, linux-kernel
On Thu, Feb 25, 2021 at 02:13:08PM -0800, Douglas Anderson wrote:
> This is a SKU variant of lazor. Add it. This squashes the downstream
> patches to support this hardware.
>
> NOTES:
> - The non-touch SKU actually has "innolux,n116bca" but that driver is
> still pending in simple-panel. The bindings have been Acked though.
> Things work well enough with the "innolux,n116bge" timings for now,
> though.
> - The wonky special dts just for "-rev4" arguably doesn't need to go
> upstream since they weren't widely distributed, but since a few
> people have them we might as well. If it ever causes problems we
> can delete it.
>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 12/13] arm64: dts: qcom: Add sc7180-lazor-pompom skus
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
` (10 preceding siblings ...)
2021-02-25 22:13 ` [PATCH 11/13] arm64: dts: qcom: Add sc7180-lazor-limozeen skus Douglas Anderson
@ 2021-02-25 22:13 ` Douglas Anderson
2021-02-25 22:25 ` Doug Anderson
2021-02-26 2:13 ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus Douglas Anderson
12 siblings, 2 replies; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:13 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Douglas Anderson, Philip Chen, Tzung-Bi Shih, Judy Hsiao,
Andy Gross, Rob Herring, devicetree, linux-arm-msm, linux-kernel
This is a trogdor variant. This is mostly a grab from the downstream
tree with notable exceptions:
- I skip -rev0. This was a super early build and there's no advantage
of long term support.
- In -rev1 I translate the handling of the USB hub like is done for
similar boards. See the difference between the downstream and
upstream 'sc7180-trogdor-lazor-r0.dts' for an example. This will
need to be resolved when proper support for the USB hub is figured
out upstream.
- I remove sound node since sound hasn't landed upstream yet.
- In incorporate the pending <https://crrev.com/c/2719075> for the
keyboard.
Cc: Philip Chen <philipchen@google.com>
Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Stephen Boyd <swboyd@chromium.org>
Cc: Tzung-Bi Shih <tzungbi@chromium.org>
Cc: Judy Hsiao <judyhsiao@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/Makefile | 4 +
.../dts/qcom/sc7180-trogdor-pompom-r1-lte.dts | 14 +
.../dts/qcom/sc7180-trogdor-pompom-r1.dts | 26 ++
.../dts/qcom/sc7180-trogdor-pompom-r2-lte.dts | 14 +
.../dts/qcom/sc7180-trogdor-pompom-r2.dts | 44 +++
.../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 288 ++++++++++++++++++
6 files changed, 390 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index adc915a5f027..d7cdff3dad98 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -41,6 +41,10 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r3-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-nots.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-nots-r4.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r1.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r1-lte.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r2.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r2-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-ganges-kirin.dtb
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dts
new file mode 100644
index 000000000000..0202f03eafe6
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dts
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Pompom board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+#include "sc7180-trogdor-pompom-r1.dts"
+#include "sc7180-trogdor-lte-sku.dtsi"
+
+/ {
+ model = "Google Pompom (rev1) with LTE";
+ compatible = "google,pompom-rev1-sku0", "qcom,sc7180";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts
new file mode 100644
index 000000000000..e720e7bd0d70
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Pompom board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+/dts-v1/;
+
+#include "sc7180-trogdor-pompom.dtsi"
+
+/ {
+ model = "Google Pompom (rev1)";
+ compatible = "google,pompom-rev1", "qcom,sc7180";
+};
+
+&pp3300_hub {
+ /* pp3300_l7c is used to power the USB hub */
+ /delete-property/regulator-always-on;
+ /delete-property/regulator-boot-on;
+};
+
+&pp3300_l7c {
+ regulator-always-on;
+ regulator-boot-on;
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dts
new file mode 100644
index 000000000000..791d496ad046
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dts
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Pompom board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+#include "sc7180-trogdor-pompom-r2.dts"
+#include "sc7180-trogdor-lte-sku.dtsi"
+
+/ {
+ model = "Google Pompom (rev2+) with LTE";
+ compatible = "google,pompom-sku0", "qcom,sc7180";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dts
new file mode 100644
index 000000000000..984d7337da78
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dts
@@ -0,0 +1,44 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Pompom board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+/dts-v1/;
+
+#include "sc7180-trogdor-pompom.dtsi"
+
+/ {
+ model = "Google Pompom (rev2+)";
+ compatible = "google,pompom", "qcom,sc7180";
+};
+
+&keyboard_controller {
+ function-row-physmap = <
+ MATRIX_KEY(0x00, 0x02, 0) /* T1 */
+ MATRIX_KEY(0x03, 0x02, 0) /* T2 */
+ MATRIX_KEY(0x02, 0x02, 0) /* T3 */
+ MATRIX_KEY(0x01, 0x02, 0) /* T4 */
+ MATRIX_KEY(0x03, 0x04, 0) /* T5 */
+ MATRIX_KEY(0x02, 0x04, 0) /* T6 */
+ MATRIX_KEY(0x01, 0x04, 0) /* T7 */
+ MATRIX_KEY(0x02, 0x09, 0) /* T8 */
+ MATRIX_KEY(0x01, 0x09, 0) /* T9 */
+ MATRIX_KEY(0x00, 0x04, 0) /* T10 */
+ >;
+ linux,keymap = <
+ MATRIX_KEY(0x00, 0x02, KEY_BACK)
+ MATRIX_KEY(0x03, 0x02, KEY_REFRESH)
+ MATRIX_KEY(0x02, 0x02, KEY_ZOOM)
+ MATRIX_KEY(0x01, 0x02, KEY_SCALE)
+ MATRIX_KEY(0x03, 0x04, KEY_SYSRQ)
+ MATRIX_KEY(0x02, 0x04, KEY_BRIGHTNESSDOWN)
+ MATRIX_KEY(0x01, 0x04, KEY_BRIGHTNESSUP)
+ MATRIX_KEY(0x02, 0x09, KEY_MUTE)
+ MATRIX_KEY(0x01, 0x09, KEY_VOLUMEDOWN)
+ MATRIX_KEY(0x00, 0x04, KEY_VOLUMEUP)
+
+ CROS_STD_MAIN_KEYMAP
+ >;
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi
new file mode 100644
index 000000000000..8f1596b8e90a
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi
@@ -0,0 +1,288 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Pompom board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+#include "sc7180.dtsi"
+
+ap_ec_spi: &spi6 {};
+ap_h1_spi: &spi0 {};
+
+#include "sc7180-trogdor.dtsi"
+
+/ {
+ thermal-zones {
+ 5v-choke-thermal {
+ polling-delay-passive = <0>;
+ polling-delay = <250>;
+
+ thermal-sensors = <&pm6150_adc_tm 0>;
+
+ trips {
+ 5v-choke-crit {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+ };
+};
+
+&alc5682 {
+ realtek,dmic-clk-driving-high = "true";
+};
+
+&cpu6_alert0 {
+ temperature = <60000>;
+};
+
+&cpu6_alert1 {
+ temperature = <65000>;
+};
+
+&cpu6_thermal {
+ sustainable-power = <948>;
+};
+
+&cpu7_alert0 {
+ temperature = <60000>;
+};
+
+&cpu7_alert1 {
+ temperature = <65000>;
+};
+
+&cpu7_thermal {
+ sustainable-power = <948>;
+};
+
+&cpu8_alert0 {
+ temperature = <60000>;
+};
+
+&cpu8_alert1 {
+ temperature = <65000>;
+};
+
+&cpu8_thermal {
+ sustainable-power = <948>;
+};
+
+&cpu9_alert0 {
+ temperature = <60000>;
+};
+
+&cpu9_alert1 {
+ temperature = <65000>;
+};
+
+&cpu9_thermal {
+ sustainable-power = <948>;
+};
+
+&gpio_keys {
+ status = "okay";
+};
+
+ap_ts_pen_1v8: &i2c4 {
+ status = "okay";
+ clock-frequency = <400000>;
+
+ ap_ts: touchscreen@10 {
+ compatible = "hid-over-i2c";
+ reg = <0x10>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&ts_int_l>, <&ts_reset_l>;
+
+ interrupt-parent = <&tlmm>;
+ interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
+
+ post-power-on-delay-ms = <20>;
+ hid-descr-addr = <0x0001>;
+
+ vdd-supply = <&pp3300_ts>;
+ };
+};
+
+&panel {
+ compatible = "kingdisplay,kd116n21-30nv-a010";
+};
+
+&pen_insert {
+ /* Insert = high, eject = low */
+ gpios = <&tlmm 52 GPIO_ACTIVE_HIGH>;
+};
+
+&pm6150_adc {
+ 5v-choke-thermistor@4e {
+ reg = <ADC5_AMUX_THM2_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ };
+};
+
+&pm6150_adc_tm {
+ status = "okay";
+
+ 5v-choke-thermistor@0 {
+ reg = <0>;
+ io-channels = <&pm6150_adc ADC5_AMUX_THM2_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time-us = <200>;
+ };
+};
+
+&sdhc_2 {
+ status = "okay";
+};
+
+&usb_c1 {
+ status = "disabled";
+};
+
+&wifi {
+ qcom,ath10k-calibration-variant = "GO_POMPOM";
+};
+
+/* PINCTRL - board-specific pinctrl */
+
+&tlmm {
+ gpio-line-names = "TP_INT_ODL",
+ "AP_RAM_ID0",
+ "AP_SKU_ID2",
+ "AP_RAM_ID1",
+ "",
+ "AP_RAM_ID2",
+ "AP_TP_I2C_SDA",
+ "AP_TP_I2C_SCL",
+ "TS_RESET_L",
+ "TS_INT_L",
+ "",
+ "EDP_BRIJ_IRQ",
+ "AP_EDP_BKLTEN",
+ "",
+ "",
+ "EDP_BRIJ_I2C_SDA",
+ "EDP_BRIJ_I2C_SCL",
+ "HUB_RST_L",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "AMP_EN",
+ "P_SENSOR_INT_L",
+ "AP_SAR_SENSOR_SDA",
+ "AP_SAR_SENSOR_SCL",
+ "",
+ "HP_IRQ",
+ "",
+ "EN_PP3300_DX_EDP",
+ "AP_BRD_ID2",
+ "BRIJ_SUSPEND",
+ "AP_BRD_ID0",
+ "AP_H1_SPI_MISO",
+ "AP_H1_SPI_MOSI",
+ "AP_H1_SPI_CLK",
+ "AP_H1_SPI_CS_L",
+ "",
+ "",
+ "",
+ "",
+ "H1_AP_INT_ODL",
+ "",
+ "UART_AP_TX_DBG_RX",
+ "UART_DBG_TX_AP_RX",
+ "HP_I2C_SDA",
+ "HP_I2C_SCL",
+ "FORCED_USB_BOOT",
+ "AMP_BCLK",
+ "AMP_LRCLK",
+ "AMP_DIN",
+ "PEN_PDCT_L",
+ "HP_BCLK",
+ "HP_LRCLK",
+ "HP_DOUT",
+ "HP_DIN",
+ "HP_MCLK",
+ "AP_SKU_ID0",
+ "AP_EC_SPI_MISO",
+ "AP_EC_SPI_MOSI",
+ "AP_EC_SPI_CLK",
+ "AP_EC_SPI_CS_L",
+ "AP_SPI_CLK",
+ "AP_SPI_MOSI",
+ "AP_SPI_MISO",
+ /*
+ * AP_FLASH_WP_L is crossystem ABI. Schematics
+ * call it BIOS_FLASH_WP_L.
+ */
+ "AP_FLASH_WP_L",
+ "",
+ "AP_SPI_CS0_L",
+ "SD_CD_ODL",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "UIM2_DATA",
+ "UIM2_CLK",
+ "UIM2_RST",
+ "UIM2_PRESENT",
+ "UIM1_DATA",
+ "UIM1_CLK",
+ "UIM1_RST",
+ "",
+ "EN_PP3300_CODEC",
+ "EN_PP3300_HUB",
+ "",
+ "DMIC_SEL",
+ "",
+ "",
+ "",
+ "AP_SKU_ID1",
+ "AP_RST_REQ",
+ "",
+ "AP_BRD_ID1",
+ "AP_EC_INT_R_L",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "EDP_BRIJ_EN",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "AP_TS_PEN_I2C_SDA",
+ "AP_TS_PEN_I2C_SCL",
+ "DP_HOT_PLUG_DET",
+ "EC_IN_RW_ODL";
+
+ dmic_sel: dmic-sel {
+ pinmux {
+ pins = "gpio86";
+ function = "gpio";
+ };
+
+ pinconf {
+ pins = "gpio86";
+ bias-pull-down;
+ };
+ };
+};
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 12/13] arm64: dts: qcom: Add sc7180-lazor-pompom skus
2021-02-25 22:13 ` [PATCH 12/13] arm64: dts: qcom: Add sc7180-lazor-pompom skus Douglas Anderson
@ 2021-02-25 22:25 ` Doug Anderson
2021-02-26 2:13 ` Matthias Kaehlcke
1 sibling, 0 replies; 33+ messages in thread
From: Doug Anderson @ 2021-02-25 22:25 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Philip Chen, Tzung-Bi Shih, Judy Hsiao, Andy Gross, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm, LKML
Hi,
On Thu, Feb 25, 2021 at 2:13 PM Douglas Anderson <dianders@chromium.org> wrote:
>
> This is a trogdor variant. This is mostly a grab from the downstream
> tree with notable exceptions:
> - I skip -rev0. This was a super early build and there's no advantage
> of long term support.
> - In -rev1 I translate the handling of the USB hub like is done for
> similar boards. See the difference between the downstream and
> upstream 'sc7180-trogdor-lazor-r0.dts' for an example. This will
> need to be resolved when proper support for the USB hub is figured
> out upstream.
> - I remove sound node since sound hasn't landed upstream yet.
> - In incorporate the pending <https://crrev.com/c/2719075> for the
> keyboard.
>
> Cc: Philip Chen <philipchen@google.com>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: Tzung-Bi Shih <tzungbi@chromium.org>
> Cc: Judy Hsiao <judyhsiao@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm64/boot/dts/qcom/Makefile | 4 +
> .../dts/qcom/sc7180-trogdor-pompom-r1-lte.dts | 14 +
> .../dts/qcom/sc7180-trogdor-pompom-r1.dts | 26 ++
> .../dts/qcom/sc7180-trogdor-pompom-r2-lte.dts | 14 +
> .../dts/qcom/sc7180-trogdor-pompom-r2.dts | 44 +++
> .../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 288 ++++++++++++++++++
> 6 files changed, 390 insertions(+)
As always I see a typo right after I hit send. ${SUBJECT} should be
"trogdor-pompom", not "lazor-pompom" for this and the next patch. I
copy/pastad from the previous patch (limozeen _is_ actually a lazor)
and didn't adjust properly.
I'm happy with any:
* to spin a -r2
* for Bjorn to fix when landing
* for this just to land since it's a harmless typo.
In any case I won't spin for now but I wanted to reply so if I do spin
for another reason I'll won't forget. ;-)
-Doug
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH 12/13] arm64: dts: qcom: Add sc7180-lazor-pompom skus
2021-02-25 22:13 ` [PATCH 12/13] arm64: dts: qcom: Add sc7180-lazor-pompom skus Douglas Anderson
2021-02-25 22:25 ` Doug Anderson
@ 2021-02-26 2:13 ` Matthias Kaehlcke
1 sibling, 0 replies; 33+ messages in thread
From: Matthias Kaehlcke @ 2021-02-26 2:13 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan, Rob Clark,
Philip Chen, Tzung-Bi Shih, Judy Hsiao, Andy Gross, Rob Herring,
devicetree, linux-arm-msm, linux-kernel
On Thu, Feb 25, 2021 at 02:13:09PM -0800, Douglas Anderson wrote:
> This is a trogdor variant. This is mostly a grab from the downstream
> tree with notable exceptions:
> - I skip -rev0. This was a super early build and there's no advantage
> of long term support.
> - In -rev1 I translate the handling of the USB hub like is done for
> similar boards. See the difference between the downstream and
> upstream 'sc7180-trogdor-lazor-r0.dts' for an example. This will
> need to be resolved when proper support for the USB hub is figured
> out upstream.
> - I remove sound node since sound hasn't landed upstream yet.
> - In incorporate the pending <https://crrev.com/c/2719075> for the
> keyboard.
>
> Cc: Philip Chen <philipchen@google.com>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: Tzung-Bi Shih <tzungbi@chromium.org>
> Cc: Judy Hsiao <judyhsiao@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
<snip>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi
> new file mode 100644
> index 000000000000..8f1596b8e90a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi
> @@ -0,0 +1,288 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Google Pompom board device tree source
> + *
> + * Copyright 2020 Google LLC.
> + */
> +
> +#include "sc7180.dtsi"
> +
> +ap_ec_spi: &spi6 {};
> +ap_h1_spi: &spi0 {};
> +
> +#include "sc7180-trogdor.dtsi"
> +
> +/ {
> + thermal-zones {
> + 5v-choke-thermal {
> + polling-delay-passive = <0>;
> + polling-delay = <250>;
> +
> + thermal-sensors = <&pm6150_adc_tm 0>;
This is fine with how things are currently configured for trogdor, however be
aware that in the ADC thermal monitor config your patch is racing with 'arm64:
dts: qcom: sc7180: trogdor: Use ADC TM channel 0 instead of 1 for charger
temperature' (https://lore.kernel.org/patchwork/patch/1384514/). That patch
changes the charger thermistor for all trogdor boards to ADC TM channel 0,
so the 5v-choke thermistor would have to move to another channel (most
likely 1).
<snip>
> +&pm6150_adc_tm {
> + status = "okay";
> +
> + 5v-choke-thermistor@0 {
> + reg = <0>;
s/0/1/ in the two lines above if 'arm64: dts: qcom: sc7180: trogdor: Use ADC
TM channel 0 instead of 1 for charger temperature' lands before this patch.
The other deltas with downstream are mentioned in the commit message, as long
as we keep the change of the ADC TM channel in mind this looks good to me.
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
` (11 preceding siblings ...)
2021-02-25 22:13 ` [PATCH 12/13] arm64: dts: qcom: Add sc7180-lazor-pompom skus Douglas Anderson
@ 2021-02-25 22:13 ` Douglas Anderson
2021-02-26 17:14 ` Matthias Kaehlcke
2021-02-26 18:45 ` Stephen Boyd
12 siblings, 2 replies; 33+ messages in thread
From: Douglas Anderson @ 2021-02-25 22:13 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Douglas Anderson, Gwendal Grignou, Tzung-Bi Shih, Judy Hsiao,
Andy Gross, Rob Herring, devicetree, linux-arm-msm, linux-kernel
This is a trogdor variant. This is mostly a grab from the downstream
tree with notable exceptions:
- I skip -rev0. This was a super early build and there's no advantage
of long term support.
- I remove sound node since sound hasn't landed upstream yet.
Cc: Gwendal Grignou <gwendal@chromium.org>
Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Stephen Boyd <swboyd@chromium.org>
Cc: Tzung-Bi Shih <tzungbi@chromium.org>
Cc: Judy Hsiao <judyhsiao@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
NOTE: technically the "google,cros-ec-mkbp-proximity" binding hasn't
landed upstream yet. However it has a Reviewed-by from Rob and the
series in general sounds about ready to land. If necessary it can be
removed / readded later.
arch/arm64/boot/dts/qcom/Makefile | 4 +
.../dts/qcom/sc7180-trogdor-coachz-r1-lte.dts | 18 ++
.../dts/qcom/sc7180-trogdor-coachz-r1.dts | 154 +++++++++++
.../dts/qcom/sc7180-trogdor-coachz-r2-lte.dts | 18 ++
.../dts/qcom/sc7180-trogdor-coachz-r2.dts | 15 ++
.../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 249 ++++++++++++++++++
6 files changed, 458 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r2-lte.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r2.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index d7cdff3dad98..a81966d59cf7 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -31,6 +31,10 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb
dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb
dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1-lte.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r2.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r2-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r0.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1-kb.dtb
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dts
new file mode 100644
index 000000000000..533c048903ea
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dts
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google CoachZ board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+#include "sc7180-trogdor-coachz-r1.dts"
+#include "sc7180-trogdor-lte-sku.dtsi"
+
+/ {
+ model = "Google CoachZ (rev1) with LTE";
+ compatible = "google,coachz-rev1-sku0", "qcom,sc7180";
+};
+
+&cros_ec_proximity {
+ label = "proximity-wifi-lte";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts
new file mode 100644
index 000000000000..86619f6c1134
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts
@@ -0,0 +1,154 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google CoachZ board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+/dts-v1/;
+
+#include "sc7180-trogdor-coachz.dtsi"
+
+/ {
+ model = "Google CoachZ (rev1)";
+ compatible = "google,coachz-rev1", "qcom,sc7180";
+};
+
+&tlmm {
+ gpio-line-names = "HUB_RST_L",
+ "AP_RAM_ID0",
+ "AP_SKU_ID2",
+ "AP_RAM_ID1",
+ "FP_TO_AP_IRQ_L",
+ "AP_RAM_ID2",
+ "UF_CAM_EN",
+ "WF_CAM_EN",
+ "TS_RESET_L",
+ "TS_INT_L",
+ "FPMCU_BOOT0",
+ "EDP_BRIJ_IRQ",
+ "AP_EDP_BKLTEN",
+ "UF_CAM_MCLK",
+ "WF_CAM_CLK",
+ "EDP_BRIJ_I2C_SDA",
+ "EDP_BRIJ_I2C_SCL",
+ "UF_CAM_SDA",
+ "UF_CAM_SCL",
+ "WF_CAM_SDA",
+ "WF_CAM_SCL",
+ "WLC_IRQ",
+ "FP_RST_L",
+ "AMP_EN",
+ "WLC_NRST",
+ "AP_SAR_SENSOR_SDA",
+ "AP_SAR_SENSOR_SCL",
+ "",
+ "",
+ "WF_CAM_RST_L",
+ "UF_CAM_RST_L",
+ "AP_BRD_ID2",
+ "BRIJ_SUSPEND",
+ "AP_BRD_ID0",
+ "AP_H1_SPI_MISO",
+ "AP_H1_SPI_MOSI",
+ "AP_H1_SPI_CLK",
+ "AP_H1_SPI_CS_L",
+ "",
+ "",
+ "",
+ "",
+ "H1_AP_INT_ODL",
+ "",
+ "UART_AP_TX_DBG_RX",
+ "UART_DBG_TX_AP_RX",
+ "",
+ "",
+ "FORCED_USB_BOOT",
+ "AMP_BCLK",
+ "AMP_LRCLK",
+ "AMP_DIN",
+ "EN_PP3300_DX_EDP",
+ "HP_BCLK",
+ "HP_LRCLK",
+ "HP_DOUT",
+ "HP_DIN",
+ "HP_MCLK",
+ "AP_SKU_ID0",
+ "AP_EC_SPI_MISO",
+ "AP_EC_SPI_MOSI",
+ "AP_EC_SPI_CLK",
+ "AP_EC_SPI_CS_L",
+ "AP_SPI_CLK",
+ "AP_SPI_MOSI",
+ "AP_SPI_MISO",
+ /*
+ * AP_FLASH_WP_L is crossystem ABI. Schematics
+ * call it BIOS_FLASH_WP_L.
+ */
+ "AP_FLASH_WP_L",
+ "",
+ "AP_SPI_CS0_L",
+ "SD_CD_ODL",
+ "",
+ "",
+ "",
+ "",
+ "FPMCU_SEL",
+ "UIM2_DATA",
+ "UIM2_CLK",
+ "UIM2_RST",
+ "UIM2_PRESENT_L",
+ "UIM1_DATA",
+ "UIM1_CLK",
+ "UIM1_RST",
+ "",
+ "DMIC_CLK_EN",
+ "HUB_EN",
+ "",
+ "AP_SPI_FP_MISO",
+ "AP_SPI_FP_MOSI",
+ "AP_SPI_FP_CLK",
+ "AP_SPI_FP_CS_L",
+ "AP_SKU_ID1",
+ "AP_RST_REQ",
+ "",
+ "AP_BRD_ID1",
+ "AP_EC_INT_L",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "EDP_BRIJ_EN",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "AP_TS_PEN_I2C_SDA",
+ "AP_TS_PEN_I2C_SCL",
+ "DP_HOT_PLUG_DET",
+ "EC_IN_RW_ODL";
+
+ dmic_clk_en: dmic_clk_en {
+ pinmux {
+ pins = "gpio83";
+ function = "gpio";
+ };
+
+ pinconf {
+ pins = "gpio83";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r2-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r2-lte.dts
new file mode 100644
index 000000000000..6e7745801fae
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r2-lte.dts
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google CoachZ board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+#include "sc7180-trogdor-coachz-r2.dts"
+#include "sc7180-trogdor-lte-sku.dtsi"
+
+/ {
+ model = "Google CoachZ (rev2+) with LTE";
+ compatible = "google,coachz-sku0", "qcom,sc7180";
+};
+
+&cros_ec_proximity {
+ label = "proximity-wifi-lte";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r2.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r2.dts
new file mode 100644
index 000000000000..4f69b6ba299f
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r2.dts
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google CoachZ board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+/dts-v1/;
+
+#include "sc7180-trogdor-coachz.dtsi"
+
+/ {
+ model = "Google CoachZ (rev2+)";
+ compatible = "google,coachz", "qcom,sc7180";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
new file mode 100644
index 000000000000..5def9953d82b
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
@@ -0,0 +1,249 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google CoachZ board device tree source
+ *
+ * Copyright 2020 Google LLC.
+ */
+
+#include "sc7180.dtsi"
+
+ap_ec_spi: &spi6 {};
+ap_h1_spi: &spi0 {};
+
+#include "sc7180-trogdor.dtsi"
+
+/* Deleted nodes from trogdor.dtsi */
+
+/delete-node/ &alc5682;
+/delete-node/ &pp3300_codec;
+
+/ {
+ /* BOARD-SPECIFIC TOP LEVEL NODES */
+
+ adau7002: audio-codec-1 {
+ compatible = "adi,adau7002";
+ IOVDD-supply = <&pp1800_l15a>;
+ #sound-dai-cells = <0>;
+ };
+};
+
+&ap_spi_fp {
+ status = "okay";
+};
+
+&backlight {
+ pwms = <&cros_ec_pwm 0>;
+};
+
+&camcc {
+ status = "okay";
+};
+
+&cros_ec {
+ cros_ec_proximity: proximity {
+ compatible = "google,cros-ec-mkbp-proximity";
+ label = "proximity-wifi";
+ };
+};
+
+ap_ts_pen_1v8: &i2c4 {
+ status = "okay";
+ clock-frequency = <400000>;
+
+ ap_ts: touchscreen@5d {
+ compatible = "goodix,gt7375p";
+ reg = <0x5d>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&ts_int_l>, <&ts_reset_l>;
+
+ interrupt-parent = <&tlmm>;
+ interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
+
+ reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
+
+ vdd-supply = <&pp3300_ts>;
+ };
+};
+
+/*
+ * There's no SAR sensor, so i2c5 is re-purposed. We leave the
+ * proximity@28 node under i2c5 (from trogdor.dtsi) since it's "disabled"
+ * and doesn't hurt.
+ */
+i2c_wlc: &i2c5 {
+ /* Currently not connected to anything; see b/168652326 */
+};
+
+&i2c7 {
+ status = "disabled";
+};
+
+&i2c9 {
+ status = "disabled";
+};
+
+&panel {
+ compatible = "boe,nv110wtm-n61";
+};
+
+&pp3300_dx_edp {
+ gpio = <&tlmm 67 GPIO_ACTIVE_HIGH>;
+};
+
+&sdhc_2 {
+ status = "okay";
+};
+
+&sn65dsi86_out {
+ data-lanes = <0 1 2 3>;
+};
+
+/* PINCTRL - modifications to sc7180-trogdor.dtsi */
+
+&en_pp3300_dx_edp {
+ pinmux {
+ pins = "gpio67";
+ };
+
+ pinconf {
+ pins = "gpio67";
+ };
+};
+
+&ts_reset_l {
+ pinconf {
+ /*
+ * We want reset state by default and it will be up to the
+ * driver to disable this when it's ready.
+ */
+ output-low;
+ };
+};
+
+/* PINCTRL - board-specific pinctrl */
+
+&tlmm {
+ gpio-line-names = "HUB_RST_L",
+ "AP_RAM_ID0",
+ "AP_SKU_ID2",
+ "AP_RAM_ID1",
+ "FP_TO_AP_IRQ_L",
+ "AP_RAM_ID2",
+ "UF_CAM_EN",
+ "WF_CAM_EN",
+ "TS_RESET_L",
+ "TS_INT_L",
+ "FPMCU_BOOT0",
+ "EDP_BRIJ_IRQ",
+ "AP_EDP_BKLTEN",
+ "UF_CAM_MCLK",
+ "WF_CAM_CLK",
+ "EDP_BRIJ_I2C_SDA",
+ "EDP_BRIJ_I2C_SCL",
+ "UF_CAM_SDA",
+ "UF_CAM_SCL",
+ "WF_CAM_SDA",
+ "WF_CAM_SCL",
+ "WLC_IRQ",
+ "FP_RST_L",
+ "AMP_EN",
+ "WLC_NRST",
+ "AP_SAR_SENSOR_SDA",
+ "AP_SAR_SENSOR_SCL",
+ "",
+ "",
+ "WF_CAM_RST_L",
+ "UF_CAM_RST_L",
+ "AP_BRD_ID2",
+ "BRIJ_SUSPEND",
+ "AP_BRD_ID0",
+ "AP_H1_SPI_MISO",
+ "AP_H1_SPI_MOSI",
+ "AP_H1_SPI_CLK",
+ "AP_H1_SPI_CS_L",
+ "",
+ "",
+ "",
+ "",
+ "H1_AP_INT_ODL",
+ "",
+ "UART_AP_TX_DBG_RX",
+ "UART_DBG_TX_AP_RX",
+ "",
+ "",
+ "FORCED_USB_BOOT",
+ "AMP_BCLK",
+ "AMP_LRCLK",
+ "AMP_DIN",
+ "",
+ "HP_BCLK",
+ "HP_LRCLK",
+ "HP_DOUT",
+ "HP_DIN",
+ "HP_MCLK",
+ "AP_SKU_ID0",
+ "AP_EC_SPI_MISO",
+ "AP_EC_SPI_MOSI",
+ "AP_EC_SPI_CLK",
+ "AP_EC_SPI_CS_L",
+ "AP_SPI_CLK",
+ "AP_SPI_MOSI",
+ "AP_SPI_MISO",
+ /*
+ * AP_FLASH_WP_L is crossystem ABI. Schematics
+ * call it BIOS_FLASH_WP_L.
+ */
+ "AP_FLASH_WP_L",
+ "EN_PP3300_DX_EDP",
+ "AP_SPI_CS0_L",
+ "SD_CD_ODL",
+ "",
+ "",
+ "",
+ "",
+ "EN_FP_RAILS",
+ "UIM2_DATA",
+ "UIM2_CLK",
+ "UIM2_RST",
+ "UIM2_PRESENT_L",
+ "UIM1_DATA",
+ "UIM1_CLK",
+ "UIM1_RST",
+ "",
+ "",
+ "HUB_EN",
+ "",
+ "AP_SPI_FP_MISO",
+ "AP_SPI_FP_MOSI",
+ "AP_SPI_FP_CLK",
+ "AP_SPI_FP_CS_L",
+ "AP_SKU_ID1",
+ "AP_RST_REQ",
+ "",
+ "AP_BRD_ID1",
+ "AP_EC_INT_L",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "EDP_BRIJ_EN",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "",
+ "AP_TS_PEN_I2C_SDA",
+ "AP_TS_PEN_I2C_SCL",
+ "DP_HOT_PLUG_DET",
+ "EC_IN_RW_ODL";
+};
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus
2021-02-25 22:13 ` [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus Douglas Anderson
@ 2021-02-26 17:14 ` Matthias Kaehlcke
2021-02-26 18:45 ` Stephen Boyd
1 sibling, 0 replies; 33+ messages in thread
From: Matthias Kaehlcke @ 2021-02-26 17:14 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Stephen Boyd, Alexandru M Stan, Rob Clark,
Gwendal Grignou, Tzung-Bi Shih, Judy Hsiao, Andy Gross,
Rob Herring, devicetree, linux-arm-msm, linux-kernel
On Thu, Feb 25, 2021 at 02:13:10PM -0800, Douglas Anderson wrote:
> This is a trogdor variant. This is mostly a grab from the downstream
> tree with notable exceptions:
> - I skip -rev0. This was a super early build and there's no advantage
> of long term support.
> - I remove sound node since sound hasn't landed upstream yet.
>
> Cc: Gwendal Grignou <gwendal@chromium.org>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: Tzung-Bi Shih <tzungbi@chromium.org>
> Cc: Judy Hsiao <judyhsiao@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Matches downstream except for the sound node and -rev0, which are
mentioned in the commit message. Also looks sane to me otherwise
from a high level inspection.
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus
2021-02-25 22:13 ` [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus Douglas Anderson
2021-02-26 17:14 ` Matthias Kaehlcke
@ 2021-02-26 18:45 ` Stephen Boyd
2021-02-27 0:55 ` Doug Anderson
1 sibling, 1 reply; 33+ messages in thread
From: Stephen Boyd @ 2021-02-26 18:45 UTC (permalink / raw)
To: Bjorn Andersson, Douglas Anderson
Cc: Alexandru M Stan, Matthias Kaehlcke, Rob Clark, Douglas Anderson,
Gwendal Grignou, Tzung-Bi Shih, Judy Hsiao, Andy Gross,
Rob Herring, devicetree, linux-arm-msm, linux-kernel
Quoting Douglas Anderson (2021-02-25 14:13:10)
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> new file mode 100644
> index 000000000000..5def9953d82b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> @@ -0,0 +1,249 @@
[...]
> +
> +/*
> + * There's no SAR sensor, so i2c5 is re-purposed. We leave the
> + * proximity@28 node under i2c5 (from trogdor.dtsi) since it's "disabled"
> + * and doesn't hurt.
> + */
> +i2c_wlc: &i2c5 {
> + /* Currently not connected to anything; see b/168652326 */
> +};
Can we remove this? As far as I know this will always be this way and
thus doesn't provide anything meaningful to leave this bug comment here
that doesn't work for people.
> +
> +&i2c7 {
> + status = "disabled";
> +};
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus
2021-02-26 18:45 ` Stephen Boyd
@ 2021-02-27 0:55 ` Doug Anderson
0 siblings, 0 replies; 33+ messages in thread
From: Doug Anderson @ 2021-02-27 0:55 UTC (permalink / raw)
To: Stephen Boyd
Cc: Bjorn Andersson, Alexandru M Stan, Matthias Kaehlcke, Rob Clark,
Gwendal Grignou, Tzung-Bi Shih, Judy Hsiao, Andy Gross,
Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm, LKML
Hi,
On Fri, Feb 26, 2021 at 10:45 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Douglas Anderson (2021-02-25 14:13:10)
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > new file mode 100644
> > index 000000000000..5def9953d82b
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > @@ -0,0 +1,249 @@
> [...]
> > +
> > +/*
> > + * There's no SAR sensor, so i2c5 is re-purposed. We leave the
> > + * proximity@28 node under i2c5 (from trogdor.dtsi) since it's "disabled"
> > + * and doesn't hurt.
> > + */
> > +i2c_wlc: &i2c5 {
> > + /* Currently not connected to anything; see b/168652326 */
> > +};
>
> Can we remove this? As far as I know this will always be this way and
> thus doesn't provide anything meaningful to leave this bug comment here
> that doesn't work for people.
Yeah, that sounds good. We just want to delete this whole comment and the node.
That seems like enough reason to repost the series. I'll plan to do
it early next week. Of course, I wouldn't object to any of these
things:
* This patch landing and having the node and I'll do a follow-up patch
to remove it.
* Bjorn removing the comment and node as he applies.
-Doug
^ permalink raw reply [flat|nested] 33+ messages in thread