From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52CA2C47094 for ; Mon, 7 Jun 2021 17:48:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33D80610A8 for ; Mon, 7 Jun 2021 17:48:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbhFGRuD (ORCPT ); Mon, 7 Jun 2021 13:50:03 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:13353 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229997AbhFGRuD (ORCPT ); Mon, 7 Jun 2021 13:50:03 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623088091; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=MFuDFvHXYlR2gGa8jeKkSiXVOoZvWtSWsoYMxROMkaU=; b=Bgf6zsjgCTqIOyck6BMLRusUCOxe+UDs9S73Uu+IU2quVtUXHWJJLrpbIPCAu81dBwsjP3JP SH8pdfsuAQMocjz5bLwNSQIOBJMPLBLR1TfR5dLPGyCmyZG3sTjHmi1pme2jLfkvDEL8ZQ3j j0Wcfht5T0AvfqsOoJeJ1vWzmsw= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 60be5bd4f726fa41885a6c49 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 07 Jun 2021 17:48:04 GMT Sender: khsieh=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D122EC43460; Mon, 7 Jun 2021 17:48:03 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: khsieh) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5EB0FC4338A; Mon, 7 Jun 2021 17:48:02 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 07 Jun 2021 10:48:02 -0700 From: khsieh@codeaurora.org To: Bjorn Andersson Cc: robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, vkoul@kernel.org, agross@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, abhinavk@codeaurora.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node In-Reply-To: References: <1622736555-15775-1-git-send-email-khsieh@codeaurora.org> Message-ID: X-Sender: khsieh@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-06-05 22:07, Bjorn Andersson wrote: > On Thu 03 Jun 16:56 CDT 2021, khsieh@codeaurora.org wrote: > >> On 2021-06-03 09:53, Bjorn Andersson wrote: >> > On Thu 03 Jun 11:09 CDT 2021, Kuogee Hsieh wrote: > [..] >> > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > [..] >> > > + power-domains = <&rpmhpd SC7180_CX>; >> > >> > Just curious, but isn't the DP block in the MDSS_GDCS? Or do we need to >> > mention CX here in order for the opp framework to apply required-opps >> > of CX? >> >> yes, > > If you want me, or other maintainers, to spend any time reviewing or > applying your patches going forward then you need to actually bother > replying properly to the questions asked. > > Thanks, > Bjorn Sorry about the confusion. What I meant is that even though DP controller is in the MDSS_GDSC power domain, DP PHY/PLL sources out of CX. The DP link clocks have a direct impact on the CX voltage corners. Therefore, we need to mention the CX power domain here. And, since we can associate only one OPP table with one device, we picked the DP link clock over other clocks.