From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EE68C432BE for ; Wed, 1 Sep 2021 22:02:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 364446108E for ; Wed, 1 Sep 2021 22:02:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242837AbhIAWDA (ORCPT ); Wed, 1 Sep 2021 18:03:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242912AbhIAWC7 (ORCPT ); Wed, 1 Sep 2021 18:02:59 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 063F2C061575 for ; Wed, 1 Sep 2021 15:02:02 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id q21so1580607ljj.6 for ; Wed, 01 Sep 2021 15:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CnPQdzZMs4DyH5oLKknlerujheq7E0iK+rdK9Bg2xfk=; b=cgNmqIkTHsf1QnCRrUS/zZO11duHElqzfFhG7zlCMqbLJcms0JEvWTGlb8V+zHvoM5 iSdwddpYr4dEHkNrUztXq6Dj9wALUczIRB/F8xGLXrAeUTqmp77yHunL5wAl0/vsTvcL 9KQqxHpwKMBX6Ajnq8beVbkNEEXx2BpMsYkIvXajUQKuwWvyVQVZ8Qtv1m1nu1OhHOYr xFpqUP+NGlyySmqf6ZdzdoxOX+xotBKEbcwrbQ71GPWfbmlocxnFAuU48DYmI3MiURv7 oLCPxNDhV8PXYUPx1ZxrDDio8KIJyiZOhvHG4ptXvjVdUjyQbip0dp2v/zHwb21ekKH4 KxTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CnPQdzZMs4DyH5oLKknlerujheq7E0iK+rdK9Bg2xfk=; b=jCfOIBaoIttKMrLFUqXSRrUPOiOaZttB7S3bDNOA0+VS0e9L3CBI3G/ogQiCWjy5u4 btRQPq+OuuULhlk8np/W7OL3eM+bzTR6LyJ9cT4p/Q0aJwJhG9cRd9K1jyc8WTeZIqYt oybV9o8GNIP5XCX2sP6RiKyUak6ryzY20kNcofKCtPevAgsq2eS+MRsqOkpR4yB6WPnk 84mC6rsiKSt361Aiai80hslMIOXXrTA/6nO826mcdRqhru9EaowXIbjmsjApRH0JbC1N OK8j+/S5d12kLbOWaDDkyr6YHZYWyzeCbStmiG+kkDKfZXQ1cevdC4ZC/LzojCa857Vc wgvg== X-Gm-Message-State: AOAM533J/v87BwIrRUBG+OTp2kjyeLeEIZ52F8sI5LznVQTi+lbyX0E0 raqGhwvqRPZWTzduSARP0UuGMA== X-Google-Smtp-Source: ABdhPJyaXhC41uRSeOf+R0AotjM8nRToFIF6cqB5moPon/c3QALTANIK4zHrWwQ9vYCcen9WP3JHdA== X-Received: by 2002:a2e:8511:: with SMTP id j17mr1410329lji.407.1630533720327; Wed, 01 Sep 2021 15:02:00 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id d21sm4432ljo.70.2021.09.01.15.01.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 15:01:59 -0700 (PDT) Subject: Re: [PATCH v4 1/5] interconnect: qcom: sdm660: Commonize RPM-QoS To: AngeloGioacchino Del Regno , Yassine Oudjana , Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring Cc: AngeloGioacchino Del Regno , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo , Marijn Suijten , Konrad Dybcio References: <20210901121518.152481-1-y.oudjana@protonmail.com> <20210901121518.152481-2-y.oudjana@protonmail.com> <9af0f031-101e-53b4-514e-9ead44320f4e@somainline.org> From: Dmitry Baryshkov Message-ID: Date: Thu, 2 Sep 2021 01:01:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <9af0f031-101e-53b4-514e-9ead44320f4e@somainline.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 01/09/2021 21:48, AngeloGioacchino Del Regno wrote: > Il 01/09/21 14:15, Yassine Oudjana ha scritto: >> SoCs such as MSM8996 also control bus QoS in a similar fashion to SDM660, >> with some paths being controlled by RPM and others directly by the AP. >> Move relevant functions and defines to a new object so that they can >> be used >> in multiple drivers. >> >> Signed-off-by: Yassine Oudjana > > Hey guys! > > I'm waiting for the interconnect RPM-QoS commonization to be merged as I > have fresh > interconnect drivers for MSM8998 and MSM8976, ready to send, that are > also using > the very same QoS mechanism as SDM660. We were also looking onto this. I'd propose to merge sdm660 code into main icc-rpm.c instead of splitting it into separate file. We have enabled QoS for apq8096 (msm8916) and msm8939. See https://lore.kernel.org/linux-arm-msm/20210818015732.1717810-1-dmitry.baryshkov@linaro.org/ for the reference. I'm waiting for Shawn to publish v2 of his fix, then I can post v2 of my patchset. > > Yassine, please check Shawn's recent patches for SDM660 interconnect, > which are > fixing some bits for the QoS implementation and adding some required > clocks to the > SDM660 interconnect driver. > > Adding Shawn to the Ccs as to make him aware of this patch; > also adding Marijn and Konrad from SoMainline as probably interested > parties. > > Cheers! > - Angelo -- With best wishes Dmitry