From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D65C1C433FE for ; Thu, 28 Oct 2021 21:44:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7A6D61106 for ; Thu, 28 Oct 2021 21:44:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231244AbhJ1Vqs (ORCPT ); Thu, 28 Oct 2021 17:46:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231235AbhJ1Vqr (ORCPT ); Thu, 28 Oct 2021 17:46:47 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41040C061745 for ; Thu, 28 Oct 2021 14:44:20 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 192so5525765wme.3 for ; Thu, 28 Oct 2021 14:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=0RhGGQzcIi3zcTecjJfp6FKx+6kPry0RwLyaHiAGLj4=; b=kJhpxrun7s4s5VH3YwjVxgVdiu1SU/T4TZeE//zn8gIU9i3JqVlVMCTeeBYImtH/C/ tHBcAZQf5UxCJBweIPjX7bHDGU+7e8TNKExmIkkqT2KbV7nJviZ7V0mcSiLsWwfNwlII zIgmrE+WIE1Lq2zmImXz/Lp6ix39qwz+tTZ7uwJVSQEJHBGg2mrB+oZ3bSAGZ460jP99 LXsHjApyqwqMsQD0kYWv5VlcOTBso9kAXOaJkSVGXVLuJhspSI+dy7yXDMEhH3426hAg BKSTmA8cqJ/NxNOXfTmo3bK79wymsCzMKs5p3fPipHCdwO97Q5MSL3xktjVmF7NB9L1e d0vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0RhGGQzcIi3zcTecjJfp6FKx+6kPry0RwLyaHiAGLj4=; b=bbBOc+AZzsOWg6Kh58UEyfme8dlJRLVEOwOArH4PHt75Au9SmyiZMChRJCSS+fBaLZ tPrf04lAM5MxZNJwwAEXGuEyYZvID4vws5fxj8sIav98GNCNzfXPP9JcfsxUK4ify3ic SP2PYZvl3QaMFw11Fd1m8CRMFRJSiRPhaFqQcvPCu1pera2ZK4UYi6I0nuuVI3UZKCwq XFzSyAAxRGB8T6AJDXGDTvkUnGHa53hiF2hQcW4maCUdAhHkOEn6zOQ9yC8zvvvI0JPA U+minH/YGe8+rxknST9B8B58kwurDBWNAU4DK/QTMA+ZfextqZoEYT+Gq+WoWpWNkAyg yTMg== X-Gm-Message-State: AOAM5336gVyvVPusjCif6zaBIFY0DxqcwqeMOUljN1hrs+oD3vRl01OU F2cnIsapU2Qpevf0KvBNJEWDqw== X-Google-Smtp-Source: ABdhPJwcZUOjijr33iqRtUL+GqvZxscUsC6nbCC2XWMrvW0XXkL2STxSDlcdtVSZlJKDXsMfoxDraQ== X-Received: by 2002:a05:600c:3782:: with SMTP id o2mr15287078wmr.102.1635457457478; Thu, 28 Oct 2021 14:44:17 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id g10sm4133306wmq.13.2021.10.28.14.44.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Oct 2021 14:44:17 -0700 (PDT) Message-ID: Date: Thu, 28 Oct 2021 22:46:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [RESEND PATCH v2 5/7] dt-bindings: usb: Add Qualcomm PMIC TCPM YAML schema Content-Language: en-US To: Rob Herring Cc: linux@roeck-us.net, heikki.krogerus@linux.intel.com, rdunlap@infradead.org, gregkh@linuxfoundation.org, bjorn.andersson@linaro.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, wcheng@codeaurora.org References: <20211028164941.831918-1-bryan.odonoghue@linaro.org> <20211028164941.831918-6-bryan.odonoghue@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 28/10/2021 21:43, Rob Herring wrote: > I don't understand these ports. The graph binding should be showing data > stream connections. It should look something like a block diagram of the > h/w components. Two different PHYs which live inside of the pm8150b USB typec/pdphy/charger block. The typec phy and power-delivery phy are not adjacent to each other typec@1500 charger@1600 pdphy@1700 The typec and pdphy pieces are being brought together into a standard Linux TCPM driver. Rather than have a TCPM device that starts @1500 and spans over the charger I've opted to have "virtual" TCPM device that has links to typec@1500 and pdphy@1700 via remote-endpoints That lets the end result dts look like this pm8150b_tcpm: pmic-tcpm { compatible = "qcom,pmic-tcpm"; status = "disabled"; ports { #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; pmic_tcpm_typec: endpoint { remote-endpoint = <&pmic_typec>; }; }; port@1 { reg = <1>; pmic_tcpm_pdphy: endpoint { remote-endpoint = <&pmic_pdphy>; }; }; }; }; pm8150b_typec: typec@1500 { compatible = "qcom,pm8150b-typec"; reg = <0x1500>; ports { #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; pmic_typec: endpoint { remote-endpoint = <&pmic_tcpm_typec>; }; }; }; }; pm8150b_pdphy: pdphy@1700 { compatible = "qcom,pm8150b-pdphy"; reg = <0x1700>; ports { #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; pmic_pdphy: endpoint { remote-endpoint = <&pmic_tcpm_pdphy>; }; }; }; }; at a later date we might want to add in the charger but, if we do we don't want that to be inside of a Linux TCPM device and I thought it would be a mess to have, since we try to keep addresses linear in DTS files pm8150b_tcpm: pmic-tcpm@1500 { compatible = "qcom,pmic-tcpm"; pm8150b_typec: typec@1500 { compatible = "qcom,pm8150b-typec"; reg = <0x1500>; ports { #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; pmic_typec: endpoint { remote-endpoint = <&pmic_tcpm_typec>; }; }; }; }; pm8150b_pdphy: pdphy@1700 { compatible = "qcom,pm8150b-pdphy"; reg = <0x1700>; ports { #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; pmic_pdphy: endpoint { remote-endpoint = <&pmic_tcpm_pdphy>; }; }; }; }; }; pm8150b_charger: pmic-charger@1600 { /* Consume electrons here */ }; --- bod