From: "Asutosh Das (asd)" <asutoshd@codeaurora.org>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
c_vkoul@quicinc.com, hongwus@codeaurora.org
Cc: Avri Altman <Avri.Altman@wdc.com>, Can Guo <cang@codeaurora.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, MSM <linux-arm-msm@vger.kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
Bart Van Assche <bvanassche@acm.org>,
Venkat Gopalakrishnan <venkatg@codeaurora.org>,
Tomas Winkler <tomas.winkler@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] scsi: ufshcd: Update the set frequency to devfreq
Date: Tue, 26 May 2020 10:17:16 -0700 [thread overview]
Message-ID: <f52a59df-5697-9e82-d12d-292ee9653f45@codeaurora.org> (raw)
In-Reply-To: <CAOCk7NrrBoO2k1M7XX0W6L2+efBbo-s6WVaKZx4EtSqNpCaUyA@mail.gmail.com>
Hi Jeffrey
On 5/25/2020 3:19 PM, Jeffrey Hugo wrote:
> On Wed, Mar 25, 2020 at 12:29 PM Asutosh Das <asutoshd@codeaurora.org> wrote:
>>
>> Currently, the frequency that devfreq provides the
>> driver to set always leads the clocks to be scaled up.
>> Hence, round the clock-rate to the nearest frequency
>> before deciding to scale.
>>
>> Also update the devfreq statistics of current frequency.
>>
>> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
>
> This change appears to cause issues for the Lenovo Miix 630, as
> identified by git bisect.
>
Thanks for reporting this.
> On 5.6-final, My boot log looks normal. On 5.7-rc7, the Lenovo Miix
> 630 rarely boots, usually stuck in some kind of infinite printk loop.
>
> If I disable some of the UFS logging, I can capture this from the
> logs, as soon as UFS inits -
>
> [ 4.353860] ufshcd-qcom 1da4000.ufshc: ufshcd_intr: Unhandled
> interrupt 0x00000000
> [ 4.359605] ufshcd-qcom 1da4000.ufshc: ufshcd_intr: Unhandled
> interrupt 0x00000000
> [ 4.365412] ufshcd-qcom 1da4000.ufshc: ufshcd_check_errors:
> saved_err 0x4 saved_uic_err 0x2
> [ 4.371121] ufshcd-qcom 1da4000.ufshc: hba->ufs_version = 0x210,
> hba->capabilities = 0x1587001f
> [ 4.376846] ufshcd-qcom 1da4000.ufshc: hba->outstanding_reqs =
> 0x100000, hba->outstanding_tasks = 0x0
> [ 4.382636] ufshcd-qcom 1da4000.ufshc: last_hibern8_exit_tstamp at
> 0 us, hibern8_exit_cnt = 0
> [ 4.388368] ufshcd-qcom 1da4000.ufshc: No record of pa_err
> [ 4.394001] ufshcd-qcom 1da4000.ufshc: dl_err[0] = 0x80000001 at 3873626 us
> [ 4.399577] ufshcd-qcom 1da4000.ufshc: No record of nl_err
> [ 4.405053] ufshcd-qcom 1da4000.ufshc: No record of tl_err
> [ 4.410464] ufshcd-qcom 1da4000.ufshc: No record of dme_err
> [ 4.415747] ufshcd-qcom 1da4000.ufshc: No record of auto_hibern8_err
> [ 4.420950] ufshcd-qcom 1da4000.ufshc: No record of fatal_err
> [ 4.426013] ufshcd-qcom 1da4000.ufshc: No record of link_startup_fail
> [ 4.430950] ufshcd-qcom 1da4000.ufshc: No record of resume_fail
> [ 4.435786] ufshcd-qcom 1da4000.ufshc: No record of suspend_fail
> [ 4.440538] ufshcd-qcom 1da4000.ufshc: dev_reset[0] = 0x0 at 3031009 us
> [ 4.445199] ufshcd-qcom 1da4000.ufshc: No record of host_reset
> [ 4.449750] ufshcd-qcom 1da4000.ufshc: No record of task_abort
> [ 4.454214] ufshcd-qcom 1da4000.ufshc: clk: core_clk, rate: 50000000
> [ 4.458590] ufshcd-qcom 1da4000.ufshc: clk: core_clk_unipro, rate: 37500000
>
> I don't understand how this change is breaking things, but it clearly is for me.
>
> What kind of additional data would be useful to get to the bottom of this?
>
++
Let me take a look and get back on this.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-05-26 17:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 18:28 [PATCH v2 0/3] UFS Clock Scaling fixes and enhancements Asutosh Das
2020-03-25 18:29 ` [PATCH v2 1/3] scsi: ufshcd: Update the set frequency to devfreq Asutosh Das
2020-05-25 22:19 ` Jeffrey Hugo
2020-05-26 17:17 ` Asutosh Das (asd) [this message]
2020-05-28 13:53 ` Jeffrey Hugo
2020-03-25 18:29 ` [PATCH v2 2/3] scsi: ufshcd: Let vendor override devfreq parameters Asutosh Das
2020-03-25 18:29 ` [PATCH v2 3/3] scsi: ufs-qcom: Override " Asutosh Das
2020-03-25 23:18 ` [PATCH v2 0/3] UFS Clock Scaling fixes and enhancements Avri Altman
2020-03-27 2:18 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f52a59df-5697-9e82-d12d-292ee9653f45@codeaurora.org \
--to=asutoshd@codeaurora.org \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=c_vkoul@quicinc.com \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
--cc=venkatg@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).