From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9747EC43460 for ; Wed, 12 May 2021 17:56:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E7CC61166 for ; Wed, 12 May 2021 17:56:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239674AbhELRsc (ORCPT ); Wed, 12 May 2021 13:48:32 -0400 Received: from gateway34.websitewelcome.com ([192.185.148.142]:48515 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344859AbhELRCy (ORCPT ); Wed, 12 May 2021 13:02:54 -0400 X-Greylist: delayed 1442 seconds by postgrey-1.27 at vger.kernel.org; Wed, 12 May 2021 13:02:54 EDT Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id E357A478D8 for ; Wed, 12 May 2021 11:37:25 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id grrRluK0cMGeEgrrRlzLo5; Wed, 12 May 2021 11:37:25 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Kyq9KuIG2zdCKlIloTSlN2gRTDBH/PRFSECmIEkdnb8=; b=uIijnBcYYSjbO3LEu5TWaSRHNf 4FvxoJSrD2IeDRCmFaFhY717HPT7GnS3cIVs8BgycE23xI1ztnDwX+3KLZRyTiTcsNGUV+LFGb1/m +RGJK8bF/7lvliMuV1xuwB0SASlEXYG/H7uwfqqeXFN3/yBUyfVV79lzP91ydnujlDjfjOedwiENe UviQHapORxa6CFHOni3fDtXLZc2e+sWqDxZmkmIi/2FqOSwdT5596P0gTqW/2eSrbNtRorJo8bAe/ emsRSbsTRFr6ZUsfHqsvH0Bl6SIENTJ/NHzpOyXvvF60sDJ/UQC5oZ03AQtLJCiiyM+0sE/llYSAQ PH8BuUWQ==; Received: from 187-162-31-110.static.axtel.net ([187.162.31.110]:52952 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1lgrrN-003Xfo-Rz; Wed, 12 May 2021 11:37:21 -0500 Subject: Re: [PATCH][next] media: venus: hfi_msgs.h: Replace one-element arrays with flexible-array members To: Stanimir Varbanov , "Gustavo A. R. Silva" , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20210211001044.GA69612@embeddedor> From: "Gustavo A. R. Silva" Message-ID: Date: Wed, 12 May 2021 11:37:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.31.110 X-Source-L: No X-Exim-ID: 1lgrrN-003Xfo-Rz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-31-110.static.axtel.net ([192.168.15.8]) [187.162.31.110]:52952 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 7 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5/12/21 06:39, Stanimir Varbanov wrote: > Hi, > > On 5/11/21 6:46 PM, Gustavo A. R. Silva wrote: >> Hi all, >> >> Friendly ping: >> >> We are about to be able to globally enable -Warray-bounds and, these are one of >> the last out-of-bounds warnings in linux-next. >> >> Could someone take this, please? > > This one introduces regressions, so I cannot take it. It needs some more > work. Please, share with me the errors or warnings you see with this. So, I can have an idea of what is going on. Unfortunately, I don't have access to the test suite or hardware to test this. Thanks! -- Gustavo >> >> Thanks >> -- >> Gustavo >> >> On 2/10/21 18:10, Gustavo A. R. Silva wrote: >>> There is a regular need in the kernel to provide a way to declare having >>> a dynamically sized set of trailing elements in a structure. Kernel code >>> should always use “flexible array members”[1] for these cases. The older >>> style of one-element or zero-length arrays should no longer be used[2]. >>> >>> Use flexible-array members in struct hfi_msg_sys_property_info_pkt and >>> hfi_msg_session_property_info_pkt instead of one-element arrays. >>> >>> Also, this helps with the ongoing efforts to enable -Warray-bounds by >>> fixing the following warnings: >>> >>> CC [M] drivers/media/platform/qcom/venus/hfi_msgs.o >>> drivers/media/platform/qcom/venus/hfi_msgs.c: In function ‘hfi_sys_property_info’: >>> drivers/media/platform/qcom/venus/hfi_msgs.c:246:35: warning: array subscript 1 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds] >>> 246 | if (req_bytes < 128 || !pkt->data[1] || pkt->num_properties > 1) >>> | ~~~~~~~~~^~~ >>> drivers/media/platform/qcom/venus/hfi_msgs.c: In function ‘hfi_session_prop_info’: >>> drivers/media/platform/qcom/venus/hfi_msgs.c:342:62: warning: array subscript 1 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds] >>> 342 | if (!req_bytes || req_bytes % sizeof(*buf_req) || !pkt->data[1]) >>> | ~~~~~~~~~^~~ >>> >>> [1] https://en.wikipedia.org/wiki/Flexible_array_member >>> [2] https://www.kernel.org/doc/html/v5.9/process/deprecated.html#zero-length-and-one-element-arrays >>> >>> Link: https://github.com/KSPP/linux/issues/79 >>> Link: https://github.com/KSPP/linux/issues/109 >>> Build-tested-by: >>> Link: https://lore.kernel.org/lkml/6023dd80.MmTeFf8SzwX0iK7%2F%25lkp@intel.com/ >>> Signed-off-by: Gustavo A. R. Silva >>> --- >>> drivers/media/platform/qcom/venus/hfi_msgs.h | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/media/platform/qcom/venus/hfi_msgs.h b/drivers/media/platform/qcom/venus/hfi_msgs.h >>> index 526d9f5b487b..e2d2ccfbdd24 100644 >>> --- a/drivers/media/platform/qcom/venus/hfi_msgs.h >>> +++ b/drivers/media/platform/qcom/venus/hfi_msgs.h >>> @@ -113,7 +113,7 @@ struct hfi_msg_sys_ping_ack_pkt { >>> struct hfi_msg_sys_property_info_pkt { >>> struct hfi_pkt_hdr hdr; >>> u32 num_properties; >>> - u32 data[1]; >>> + u32 data[]; >>> }; >>> >>> struct hfi_msg_session_load_resources_done_pkt { >>> @@ -233,7 +233,7 @@ struct hfi_msg_session_parse_sequence_header_done_pkt { >>> struct hfi_msg_session_property_info_pkt { >>> struct hfi_session_hdr_pkt shdr; >>> u32 num_properties; >>> - u32 data[1]; >>> + u32 data[]; >>> }; >>> >>> struct hfi_msg_session_release_resources_done_pkt { >>> >