From: Alex Elder <elder@ieee.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Shawn Guo <shawn.guo@linaro.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Alex Elder <elder@kernel.org>,
Steev Klimaszewski <steev@kali.org>,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipa: Declare IPA firmware with MODULE_FIRMWARE()
Date: Mon, 27 Sep 2021 15:30:11 -0500 [thread overview]
Message-ID: <f85b8088-6efd-5f3b-d064-f61afd273a3b@ieee.org> (raw)
In-Reply-To: <YVIc77g464EpLtyN@ripper>
On 9/27/21 2:35 PM, Bjorn Andersson wrote:
> On Sat 25 Sep 23:55 PDT 2021, Shawn Guo wrote:
>
>> Declare IPA firmware with MODULE_FIRMWARE(), so that initramfs tools can
>> build the firmware into initramfs image or warn on missing of the
>> firmware.
>>
>> W: Possible missing firmware /lib/firmware/ipa_fws.mdt for module ipa
>>
>> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
>> ---
>> drivers/net/ipa/ipa_main.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
>> index cdfa98a76e1f..264bebc78d1e 100644
>> --- a/drivers/net/ipa/ipa_main.c
>> +++ b/drivers/net/ipa/ipa_main.c
>> @@ -545,6 +545,8 @@ static int ipa_firmware_load(struct device *dev)
>> return ret;
>> }
>>
>> +MODULE_FIRMWARE(IPA_FW_PATH_DEFAULT);
>
> I think it's fair to say that no device that is capable of running
> mkinitcpio should actually use IPA_FW_PATH_DEFAULT, but rather some
> device-specific firmware file.
Actually, yes, I should have thought of that too.
The default used here just specifies the path name
used *if the firmware file name is not specified in
the DTB*.
So I don't think this is correct regardless of whether
the MDT file is split or not. I think that's what
Bjorn is saying here.
-Alex
>
> Regards,
> Bjorn
>
>> +
>> static const struct of_device_id ipa_match[] = {
>> {
>> .compatible = "qcom,msm8998-ipa",
>> --
>> 2.17.1
>>
prev parent reply other threads:[~2021-09-27 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 6:55 [PATCH] net: ipa: Declare IPA firmware with MODULE_FIRMWARE() Shawn Guo
2021-09-26 13:46 ` Shawn Guo
2021-09-27 16:07 ` Alex Elder
2021-09-27 19:35 ` Bjorn Andersson
2021-09-27 20:30 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f85b8088-6efd-5f3b-d064-f61afd273a3b@ieee.org \
--to=elder@ieee.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).