linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Caleb Connolly <caleb@connolly.tech>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath10k: demote chan info without scan request warning
Date: Fri, 18 Jun 2021 18:34:50 +0000	[thread overview]
Message-ID: <f983af18-6a17-4cf1-a577-a86e4498b212@connolly.tech> (raw)
In-Reply-To: <871r96yw6z.fsf@codeaurora.org>



On 13/06/2021 10:01 am, Kalle Valo wrote:
> Caleb Connolly <caleb@connolly.tech> writes:
>
>> Hi Kalle,
>>
>> On 12/06/2021 11:36 am, Kalle Valo wrote:
>>> Caleb Connolly <caleb@connolly.tech> wrote:
>>>
>>>> Some devices/firmwares cause this to be printed every 5-15 seconds,
>>>> though it has no impact on functionality. Demote this to a debug
>>>> message.
>>>>
>>>> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
>>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>
>> Is this meant to be an Ack?
>
> No, my patchwork script has few quirks and it actually takes the quoted
> text from my pending branch, not from your actual email. That's why you
> see my s-o-b there. I haven't bothered to fix that yet, but hopefully
> one day.
>
>>> On what hardware and firmware version do you see this?
>>
>> I see this on SDM845 and MSM8998 platforms, specifically the OnePlus 6
>> devices, PocoPhone F1 and OnePlus 5.
>> On the OnePlus 6 (SDM845) we are stuck with the following signed vendor fw:
>>
>> [    9.339873] ath10k_snoc 18800000.wifi: qmi chip_id 0x30214
>> chip_family 0x4001 board_id 0xff soc_id 0x40030001
>> [    9.339897] ath10k_snoc 18800000.wifi: qmi fw_version 0x20060029
>> fw_build_timestamp 2019-07-12 02:14 fw_build_id
>> QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c8-00041-QCAHLSWMTPLZ-1
>>
>> The OnePlus 5 (MSM8998) is using firmware:
>>
>> [ 6096.956799] ath10k_snoc 18800000.wifi: qmi chip_id 0x30214
>> chip_family 0x4001 board_id 0xff soc_id 0x40010002
>> [ 6096.956824] ath10k_snoc 18800000.wifi: qmi fw_version 0x1007007e
>> fw_build_timestamp 2020-04-14 22:45 fw_build_id
>> QC_IMAGE_VERSION_STRING=WLAN.HL.1.0.c6-00126-QCAHLSWMTPLZ-1.211883.1.278648.
>
> Thanks, I'll include this information to the commit log and then apply
> the patch. And I'll assume you have also tested this patch on those
> platforms so that I can add a Tested-on tag?
Yeah, go ahead. Sorry for the late reply!
>
> BTW, ath10k should strip that ugly "QC_IMAGE_VERSION_STRING=" string in
> the firmware version. Patches very welcome :)
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>

--
Kind Regards,
Caleb


  reply	other threads:[~2021-06-18 18:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-22 17:18 [PATCH] ath10k: demote chan info without scan request warning Caleb Connolly
2021-06-12 10:36 ` Kalle Valo
2021-06-12 13:00   ` Caleb Connolly
2021-06-13  9:01     ` Kalle Valo
2021-06-18 18:34       ` Caleb Connolly [this message]
2021-06-19  9:13 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f983af18-6a17-4cf1-a577-a86e4498b212@connolly.tech \
    --to=caleb@connolly.tech \
    --cc=ath10k@lists.infradead.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).