From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C2F5C48BE8 for ; Fri, 18 Jun 2021 18:35:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD860613E9 for ; Fri, 18 Jun 2021 18:35:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231250AbhFRShN (ORCPT ); Fri, 18 Jun 2021 14:37:13 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]:57889 "EHLO mail-4322.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbhFRShN (ORCPT ); Fri, 18 Jun 2021 14:37:13 -0400 X-Greylist: delayed 2642 seconds by postgrey-1.27 at vger.kernel.org; Fri, 18 Jun 2021 14:37:12 EDT Date: Fri, 18 Jun 2021 18:34:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connolly.tech; s=protonmail; t=1624041301; bh=gPJStNIBkyU+EiKyKIcmWvO+oVN/hGtsoDaeZGrgtAM=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=Ccq/7+LgItQsJkh0Xxxpd8NbhZbrDXI7N1Xv3NWVjpArRTWpOqEKSmPKYNXjz1ZuJ jn4T306aVgOByi+oKKxx8GE/hLOIEHqzl0C1EsmpEPJV3v7Eosw2QIfqlBDTNzjHjc VJhJswathmzV+6z5Uz5oUuoKcnZePuKdaboC+rx8= To: Kalle Valo From: Caleb Connolly Cc: "David S. Miller" , Jakub Kicinski , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Caleb Connolly Subject: Re: [PATCH] ath10k: demote chan info without scan request warning Message-ID: In-Reply-To: <871r96yw6z.fsf@codeaurora.org> References: <20210522171609.299611-1-caleb@connolly.tech> <20210612103640.2FD93C433F1@smtp.codeaurora.org> <871r96yw6z.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 13/06/2021 10:01 am, Kalle Valo wrote: > Caleb Connolly writes: > >> Hi Kalle, >> >> On 12/06/2021 11:36 am, Kalle Valo wrote: >>> Caleb Connolly wrote: >>> >>>> Some devices/firmwares cause this to be printed every 5-15 seconds, >>>> though it has no impact on functionality. Demote this to a debug >>>> message. >>>> >>>> Signed-off-by: Caleb Connolly >>>> Signed-off-by: Kalle Valo >> >> Is this meant to be an Ack? > > No, my patchwork script has few quirks and it actually takes the quoted > text from my pending branch, not from your actual email. That's why you > see my s-o-b there. I haven't bothered to fix that yet, but hopefully > one day. > >>> On what hardware and firmware version do you see this? >> >> I see this on SDM845 and MSM8998 platforms, specifically the OnePlus 6 >> devices, PocoPhone F1 and OnePlus 5. >> On the OnePlus 6 (SDM845) we are stuck with the following signed vendor = fw: >> >> [ 9.339873] ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 >> chip_family 0x4001 board_id 0xff soc_id 0x40030001 >> [ 9.339897] ath10k_snoc 18800000.wifi: qmi fw_version 0x20060029 >> fw_build_timestamp 2019-07-12 02:14 fw_build_id >> QC_IMAGE_VERSION_STRING=3DWLAN.HL.2.0.c8-00041-QCAHLSWMTPLZ-1 >> >> The OnePlus 5 (MSM8998) is using firmware: >> >> [ 6096.956799] ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 >> chip_family 0x4001 board_id 0xff soc_id 0x40010002 >> [ 6096.956824] ath10k_snoc 18800000.wifi: qmi fw_version 0x1007007e >> fw_build_timestamp 2020-04-14 22:45 fw_build_id >> QC_IMAGE_VERSION_STRING=3DWLAN.HL.1.0.c6-00126-QCAHLSWMTPLZ-1.211883.1.2= 78648. > > Thanks, I'll include this information to the commit log and then apply > the patch. And I'll assume you have also tested this patch on those > platforms so that I can add a Tested-on tag? Yeah, go ahead. Sorry for the late reply! > > BTW, ath10k should strip that ugly "QC_IMAGE_VERSION_STRING=3D" string in > the firmware version. Patches very welcome :) > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa= tches > -- Kind Regards, Caleb