From: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: agross@kernel.org, mturquette@baylibre.com,
bjorn.andersson@linaro.org, niklas.cassel@linaro.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] clk: qcom: apcs-msm8916: get parent clock names from DT
Date: Tue, 10 Sep 2019 11:34:45 +0200 [thread overview]
Message-ID: <fcac3f60-6a96-b3ee-f734-a03636fbbee4@linaro.org> (raw)
In-Reply-To: <20190910091437.CCA78208E4@mail.kernel.org>
On 9/10/19 11:14, Stephen Boyd wrote:
> Quoting Jorge Ramirez-Ortiz, Linaro (2019-09-09 09:54:08)
>> On 09/09/19 09:17:03, Stephen Boyd wrote:
>>> But now the binding is different for the same compatible. I'd prefer we
>>> keep using devm_clk_get() and use a device pointer here and reorder the
>>> map and parent arrays instead. The clocks property shouldn't change in a
>>> way that isn't "additive" so that we maintain backwards compatibility.
>>>
>>
>> but the backwards compatibility is fully maintained - that is the main reason
>> behind the change. the new stuff is that instead of hardcoding the
>> names in the source - like it is being done on the msm8916- we provide
>> the clocks in the dts node (a cleaner approach with the obvious
>> benefit of allowing new users to be added without having to modify the
>> sources).
>>
>
> This is not a backwards compatible change.
>
>>>> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
>>>> @@ -429,7 +429,8 @@
>>>> compatible = "qcom,msm8916-apcs-kpss-global", "syscon";
>>>> reg = <0xb011000 0x1000>;
>>>> #mbox-cells = <1>;
>>>> - clocks = <&a53pll>;
>>>> + clocks = <&gcc GPLL0_VOTE>, <&a53pll>;
>>>> + clock-names = "aux", "pll";
>>>> #clock-cells = <0>;
>>>> };
>>>>
>
> Because the "clocks" property changed from
>
> <&a53pll>
>
> to
>
> <&gcc GPLL0_VOTE>, <&a53pll>
>
> and that moves pll to cell 1 instead of cell 0.
>
>
what do you mean by backwards compatible? because this change does not
break previous clients.
next prev parent reply other threads:[~2019-09-10 9:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 16:45 [PATCH 1/5] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency Jorge Ramirez-Ortiz
2019-08-26 16:45 ` [PATCH 2/5] clk: qcom: apcs-msm8916: get parent clock names from DT Jorge Ramirez-Ortiz
2019-09-09 10:21 ` Stephen Boyd
2019-09-09 14:17 ` Jorge Ramirez-Ortiz, Linaro
2019-09-09 16:17 ` Stephen Boyd
2019-09-09 16:54 ` Jorge Ramirez-Ortiz, Linaro
2019-09-10 9:14 ` Stephen Boyd
2019-09-10 9:34 ` Jorge Ramirez [this message]
2019-09-10 9:40 ` Jorge Ramirez
2019-09-10 10:20 ` Stephen Boyd
2019-09-09 10:23 ` Stephen Boyd
2019-08-26 16:45 ` [PATCH 3/5] clk: qcom: hfpll: " Jorge Ramirez-Ortiz
2019-09-09 10:22 ` Stephen Boyd
2019-08-26 16:45 ` [PATCH 4/5] clk: qcom: hfpll: register as clock provider Jorge Ramirez-Ortiz
2019-09-09 10:22 ` Stephen Boyd
2019-08-26 16:45 ` [PATCH 5/5] clk: qcom: hfpll: CLK_IGNORE_UNUSED Jorge Ramirez-Ortiz
2019-09-09 10:23 ` Stephen Boyd
2019-09-05 7:30 ` [PATCH 1/5] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency Jorge Ramirez
2019-09-09 10:05 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcac3f60-6a96-b3ee-f734-a03636fbbee4@linaro.org \
--to=jorge.ramirez-ortiz@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=niklas.cassel@linaro.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).