From: Jishnu Prakash <jprakash@codeaurora.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
mka@chromium.org, linus.walleij@linaro.org, sboyd@codeaurora.org,
Jonathan.Cameron@huawei.com, smohanad@codeaurora.org,
kgunda@codeaurora.org, aghayal@codeaurora.org,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-iio@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: adc: Add PMIC7 ADC bindings
Date: Mon, 6 Apr 2020 17:15:21 +0530 [thread overview]
Message-ID: <fe8056c5-9480-a9a3-9626-5ebab8031b08@codeaurora.org> (raw)
In-Reply-To: <20200328165410.7db48818@archlinux>
Hi Jonathan,
On 3/28/2020 10:24 PM, Jonathan Cameron wrote:
> On Tue, 24 Mar 2020 21:14:09 +0530
> Jishnu Prakash <jprakash@codeaurora.org> wrote:
>
>> Add documentation for PMIC7 ADC peripheral. For PMIC7 ADC, all SW
>> communication to ADC goes through PMK8350, which communicates with
>> other PMICs through PBS.
>>
>> Signed-off-by: Jishnu Prakash <jprakash@codeaurora.org>
>> ---
>> .../bindings/iio/adc/qcom,spmi-vadc.yaml | 28 ++++++++++++++++------
>> 1 file changed, 21 insertions(+), 7 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
>> index 72db14c..20f010c 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
>> @@ -13,7 +13,7 @@ maintainers:
>> description: |
>> SPMI PMIC voltage ADC (VADC) provides interface to clients to read
>> voltage. The VADC is a 15-bit sigma-delta ADC.
>> - SPMI PMIC5 voltage ADC (ADC) provides interface to clients to read
>> + SPMI PMIC5/PMIC7 voltage ADC (ADC) provides interface to clients to read
>> voltage. The VADC is a 16-bit sigma-delta ADC.
>>
>> properties:
>> @@ -23,6 +23,7 @@ properties:
>> - qcom,spmi-adc5
>> - qcom,spmi-adc-rev2
>> - qcom,pms405-adc
>> + - qcom,spmi-adc7
>>
>> reg:
>> description: VADC base address in the SPMI PMIC register map
>> @@ -65,6 +66,8 @@ patternProperties:
>> description: |
>> ADC channel number.
>> See include/dt-bindings/iio/qcom,spmi-vadc.h
>> + For PMIC7 ADC, the channel numbers are specified separately per PMIC
>> + in the PMIC-specific files in include/dt-bindings/iio/.
> That makes me thing we really should have separate compatibles. The
> parts clearly have differences, even if we haven't needed to use them
> explicitly as yet.
I'm not sure what you mean by this. We have added a new compatible
property "qcom,spmi-adc7" for PMIC7 ADC.
>
>>
>> label:
>> description: |
>> @@ -72,7 +75,7 @@ patternProperties:
>> For thermistor inputs connected to generic AMUX or GPIO inputs
>> these can vary across platform for the same pins. Hence select
>> the platform schematics name for this channel. It is required
>> - for "qcom,spmi-adc5" and "qcom,spmi-adc-rev2".
>> + for "qcom,spmi-adc5", "qcom,spmi-adc7" and "qcom,spmi-adc-rev2".
>> allOf:
>> - $ref: /schemas/types.yaml#/definitions/string
>>
>>
next prev parent reply other threads:[~2020-04-06 11:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 15:44 [PATCH 0/3] iio: adc: Add support for QCOM SPMI PMIC7 ADC Jishnu Prakash
2020-03-24 15:44 ` [PATCH 1/3] iio: adc: Convert the QCOM SPMI ADC bindings to .yaml format Jishnu Prakash
2020-03-28 16:51 ` Jonathan Cameron
2020-04-06 11:41 ` Jishnu Prakash
2020-03-30 15:38 ` Rob Herring
2020-04-06 11:43 ` Jishnu Prakash
2020-04-03 12:04 ` Amit Kucheria
2020-04-06 11:44 ` Jishnu Prakash
2020-04-14 9:09 ` Amit Kucheria
2020-03-24 15:44 ` [PATCH 2/3] iio: adc: Add PMIC7 ADC bindings Jishnu Prakash
2020-03-28 16:54 ` Jonathan Cameron
2020-04-06 11:45 ` Jishnu Prakash [this message]
2020-04-06 16:05 ` Jonathan Cameron
2020-04-03 12:11 ` Amit Kucheria
2020-04-06 11:45 ` Jishnu Prakash
2020-03-24 15:44 ` [PATCH 3/3] iio: adc: Add support for PMIC7 ADC Jishnu Prakash
2020-03-24 16:33 ` Andy Shevchenko
2020-04-06 11:46 ` Jishnu Prakash
2020-03-28 17:04 ` Jonathan Cameron
2020-04-06 11:46 ` Jishnu Prakash
2020-03-31 20:06 ` Rob Herring
2020-04-06 11:47 ` Jishnu Prakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe8056c5-9480-a9a3-9626-5ebab8031b08@codeaurora.org \
--to=jprakash@codeaurora.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=aghayal@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kgunda@codeaurora.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=smohanad@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).