From: Bjorn Andersson <andersson@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
agross@kernel.org, conor+dt@kernel.org,
dmitry.baryshkov@linaro.org, jonathan@marek.ca,
konrad.dybcio@linaro.org, krzysztof.kozlowski+dt@linaro.org,
mturquette@baylibre.com, quic_tdas@quicinc.com,
robh+dt@kernel.org, vladimir.zapolskiy@linaro.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3.1 3/4] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC
Date: Wed, 25 Oct 2023 19:15:21 -0700 [thread overview]
Message-ID: <htdwp25oqvy6vmp6ff2z7ycmckvem2ejhitqonjgfzinqv5nds@rlfuary2ouc3> (raw)
In-Reply-To: <866d5582-a4e2-4b98-a291-6e41939bd9f3@linaro.org>
On Tue, Oct 24, 2023 at 10:40:04AM +0100, Bryan O'Donoghue wrote:
> On 24/10/2023 01:34, Stephen Boyd wrote:
> > Quoting Bryan O'Donoghue (2023-10-23 08:38:20)
> > > diff --git a/drivers/clk/qcom/camcc-sc8280xp.c b/drivers/clk/qcom/camcc-sc8280xp.c
> > > new file mode 100644
> > > index 000000000000..0631bd5fad57
> > > --- /dev/null
> > > +++ b/drivers/clk/qcom/camcc-sc8280xp.c
> > > @@ -0,0 +1,3048 @@
> > > +// SPDX-License-Identifier: GPL-2.0-only
> > > +/*
> > > + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > > + * Copyright (c) 2023, Linaro Ltd.
> > > + */
> > > +
> > > +#include <linux/clk-provider.h>
> > > +#include <linux/err.h>
> >
> > Is this include used?
> >
> > > +#include <linux/kernel.h>
> > > +#include <linux/module.h>
> > > +#include <linux/of_device.h>
> >
> > Should be mod_devicetable.h instead?
> >
> > > +#include <linux/of.h>
> >
> > Is this include used?
> >
> > > +#include <linux/pm_clock.h>
> > > +#include <linux/pm_runtime.h>
> > > +#include <linux/regmap.h>
> > > +#include <linux/pm_runtime.h>
> >
> > This got included twice.
> >
> > > +
> > > +#include <dt-bindings/clock/qcom,sc8280xp-camcc.h>
> > > +
> > > +#include "clk-alpha-pll.h"
>
> You're right, I didn't scrub the autogen headers.
>
> Update sent as v3.2.
>
Resubmitting one of the four patches as 3.2 confuses both me and the
tools. Please send a v4 of all 4 patches instead.
Regards,
Bjorn
next prev parent reply other threads:[~2023-10-26 2:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 15:38 [PATCH v3.1 0/4] Add sc8280xp CAMCC bindings and driver Bryan O'Donoghue
2023-10-23 15:38 ` [PATCH v3.1 1/4] dt-bindings: clock: Use gcc.yaml for common clock properties Bryan O'Donoghue
2023-10-23 15:38 ` [PATCH v3.1 2/4] dt-bindings: clock: Add SC8280XP CAMCC Bryan O'Donoghue
2023-10-23 15:38 ` [PATCH v3.1 3/4] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC Bryan O'Donoghue
2023-10-24 0:34 ` Stephen Boyd
2023-10-24 9:39 ` [PATCH v3.2] " Bryan O'Donoghue
2023-10-24 9:40 ` [PATCH v3.1 3/4] " Bryan O'Donoghue
2023-10-26 2:15 ` Bjorn Andersson [this message]
2023-10-26 10:13 ` [PATCH v4 0/4] Add sc8280xp CAMCC bindings and driver Bryan O'Donoghue
2023-10-26 10:13 ` [PATCH v4 1/4] dt-bindings: clock: Use gcc.yaml for common clock properties Bryan O'Donoghue
2023-10-26 10:13 ` [PATCH v4 2/4] dt-bindings: clock: Add SC8280XP CAMCC Bryan O'Donoghue
2023-10-26 10:13 ` [PATCH v4 3/4] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC Bryan O'Donoghue
2023-10-26 10:13 ` [PATCH v4 4/4] arm64: dts: qcom: sc8280xp: Add in CAMCC for sc8280xp Bryan O'Donoghue
2023-10-26 10:52 ` [PATCH v4 0/4] Add sc8280xp CAMCC bindings and driver Bryan O'Donoghue
2023-10-23 15:38 ` [PATCH v3.1 4/4] arm64: dts: qcom: sc8280xp: Add in CAMCC for sc8280xp Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=htdwp25oqvy6vmp6ff2z7ycmckvem2ejhitqonjgfzinqv5nds@rlfuary2ouc3 \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).